| Message ID | 20200305175651.4563-3-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/net: Make Net/CanBus can_receive() handlers return a boolean | expand |
On Thu, Mar 5, 2020 at 9:57 AM Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > > The smc91c111_can_receive() function simply returns a boolean value. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > hw/net/smc91c111.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/hw/net/smc91c111.c b/hw/net/smc91c111.c > index e9eb6f6c05..02be60c955 100644 > --- a/hw/net/smc91c111.c > +++ b/hw/net/smc91c111.c > @@ -130,16 +130,16 @@ static void smc91c111_update(smc91c111_state *s) > qemu_set_irq(s->irq, level); > } > > -static int smc91c111_can_receive(smc91c111_state *s) > +static bool smc91c111_can_receive(smc91c111_state *s) > { > if ((s->rcr & RCR_RXEN) == 0 || (s->rcr & RCR_SOFT_RST)) { > - return 1; > + return true; > } > if (s->allocated == (1 << NUM_PACKETS) - 1 || > s->rx_fifo_len == NUM_PACKETS) { > - return 0; > + return false; > } > - return 1; > + return true; > } > > static inline void smc91c111_flush_queued_packets(smc91c111_state *s) > -- > 2.21.1 > >
On 3/5/20 6:56 PM, Philippe Mathieu-Daudé wrote: > The smc91c111_can_receive() function simply returns a boolean value. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Reviewed-by: Cédric Le Goater <clg@kaod.org> > --- > hw/net/smc91c111.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/hw/net/smc91c111.c b/hw/net/smc91c111.c > index e9eb6f6c05..02be60c955 100644 > --- a/hw/net/smc91c111.c > +++ b/hw/net/smc91c111.c > @@ -130,16 +130,16 @@ static void smc91c111_update(smc91c111_state *s) > qemu_set_irq(s->irq, level); > } > > -static int smc91c111_can_receive(smc91c111_state *s) > +static bool smc91c111_can_receive(smc91c111_state *s) > { > if ((s->rcr & RCR_RXEN) == 0 || (s->rcr & RCR_SOFT_RST)) { > - return 1; > + return true; > } > if (s->allocated == (1 << NUM_PACKETS) - 1 || > s->rx_fifo_len == NUM_PACKETS) { > - return 0; > + return false; > } > - return 1; > + return true; > } > > static inline void smc91c111_flush_queued_packets(smc91c111_state *s) >
diff --git a/hw/net/smc91c111.c b/hw/net/smc91c111.c index e9eb6f6c05..02be60c955 100644 --- a/hw/net/smc91c111.c +++ b/hw/net/smc91c111.c @@ -130,16 +130,16 @@ static void smc91c111_update(smc91c111_state *s) qemu_set_irq(s->irq, level); } -static int smc91c111_can_receive(smc91c111_state *s) +static bool smc91c111_can_receive(smc91c111_state *s) { if ((s->rcr & RCR_RXEN) == 0 || (s->rcr & RCR_SOFT_RST)) { - return 1; + return true; } if (s->allocated == (1 << NUM_PACKETS) - 1 || s->rx_fifo_len == NUM_PACKETS) { - return 0; + return false; } - return 1; + return true; } static inline void smc91c111_flush_queued_packets(smc91c111_state *s)
The smc91c111_can_receive() function simply returns a boolean value. Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- hw/net/smc91c111.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)