diff mbox series

[net-next,3/7] tun: reject unsupported coalescing params

Message ID 20200306010602.1620354-4-kuba@kernel.org (mailing list archive)
State Not Applicable
Headers show
Series ethtool: consolidate irq coalescing - other drivers | expand

Commit Message

Jakub Kicinski March 6, 2020, 1:05 a.m. UTC
Set ethtool_ops->supported_coalesce_params to let
the core reject unsupported coalescing parameters.

This driver did not previously reject unsupported parameters.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
 drivers/net/tun.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Jason Wang March 6, 2020, 9:33 a.m. UTC | #1
On 2020/3/6 上午9:05, Jakub Kicinski wrote:
> Set ethtool_ops->supported_coalesce_params to let
> the core reject unsupported coalescing parameters.
>
> This driver did not previously reject unsupported parameters.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
>   drivers/net/tun.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/tun.c b/drivers/net/tun.c
> index 79f248cb282d..9e8f23519e82 100644
> --- a/drivers/net/tun.c
> +++ b/drivers/net/tun.c
> @@ -3597,6 +3597,7 @@ static int tun_set_coalesce(struct net_device *dev,
>   }
>   
>   static const struct ethtool_ops tun_ethtool_ops = {
> +	.supported_coalesce_params = ETHTOOL_COALESCE_RX_MAX_FRAMES,
>   	.get_drvinfo	= tun_get_drvinfo,
>   	.get_msglevel	= tun_get_msglevel,
>   	.set_msglevel	= tun_set_msglevel,


Acked-by: Jason Wang <jasowang@redhat.com>
diff mbox series

Patch

diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index 79f248cb282d..9e8f23519e82 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -3597,6 +3597,7 @@  static int tun_set_coalesce(struct net_device *dev,
 }
 
 static const struct ethtool_ops tun_ethtool_ops = {
+	.supported_coalesce_params = ETHTOOL_COALESCE_RX_MAX_FRAMES,
 	.get_drvinfo	= tun_get_drvinfo,
 	.get_msglevel	= tun_get_msglevel,
 	.set_msglevel	= tun_set_msglevel,