mbox series

[RESEND,v2,0/7] drm: drm_fb_helper cleanup.

Message ID 20200305120434.111091-1-pankaj.laxminarayan.bharadiya@intel.com (mailing list archive)
Headers show
Series drm: drm_fb_helper cleanup. | expand

Message

Pankaj Bharadiya March 5, 2020, 12:04 p.m. UTC
This series addresses below drm_fb_helper tasks from
Documentation/gpu/todo.rst.

- The max connector argument for drm_fb_helper_init() isn't used
  anymore and can be removed.

- The helper doesn't keep an array of connectors anymore so these can
  be removed: drm_fb_helper_single_add_all_connectors(),
  drm_fb_helper_add_one_connector() and
  drm_fb_helper_remove_one_connector().

Changes since v1:
   - Accumulated all review tags into individual commits (Emil, Daniel) 
   - Squashed warning fixes into the patch that introduced the
     warnings (into 5/7) (Laurent, Emil, Lyude)
   - Remove entire drm_fb_helper tasks from todo list. Daniel's
     "64914da24ea9 drm/fbdev-helper: don't force restores" fixes first
     one (Daniel)

Pankaj Bharadiya (7):
  drm: Remove unused arg from drm_fb_helper_init
  drm/radeon: remove radeon_fb_{add,remove}_connector functions
  drm/amdgpu: Remove drm_fb_helper_{add,remove}_one_connector calls
  drm/i915/display: Remove drm_fb_helper_{add,remove}_one_connector calls
  drm: Remove drm_fb_helper add, add all and remove connector calls
  drm/fb-helper: Remove drm_fb_helper add, add_all and remove connector functions
  drm/todo: Update drm_fb_helper tasks

 Documentation/gpu/todo.rst                    | 17 ------------
 drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c        |  5 +---
 .../display/amdgpu_dm/amdgpu_dm_mst_types.c   | 13 ---------
 drivers/gpu/drm/armada/armada_fbdev.c         |  8 +-----
 drivers/gpu/drm/bridge/tc358764.c             |  3 ---
 drivers/gpu/drm/drm_fb_helper.c               |  6 ++---
 drivers/gpu/drm/exynos/exynos_drm_dsi.c       |  1 -
 drivers/gpu/drm/exynos/exynos_drm_fbdev.c     | 10 +------
 drivers/gpu/drm/gma500/framebuffer.c          |  6 +----
 drivers/gpu/drm/i915/display/intel_dp_mst.c   | 12 ---------
 drivers/gpu/drm/i915/display/intel_fbdev.c    |  4 +--
 drivers/gpu/drm/msm/msm_fbdev.c               |  6 +----
 drivers/gpu/drm/nouveau/dispnv50/disp.c       |  7 -----
 drivers/gpu/drm/nouveau/nouveau_fbcon.c       |  6 +----
 drivers/gpu/drm/omapdrm/omap_fbdev.c          |  6 +----
 drivers/gpu/drm/radeon/radeon_dp_mst.c        | 10 -------
 drivers/gpu/drm/radeon/radeon_fb.c            | 19 +------------
 drivers/gpu/drm/radeon/radeon_mode.h          |  3 ---
 drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c |  9 +------
 drivers/gpu/drm/tegra/fb.c                    |  8 +-----
 include/drm/drm_fb_helper.h                   | 27 ++-----------------
 21 files changed, 15 insertions(+), 171 deletions(-)

Comments

Daniel Vetter March 6, 2020, 1:46 p.m. UTC | #1
On Thu, Mar 05, 2020 at 05:34:27PM +0530, Pankaj Bharadiya wrote:
> This series addresses below drm_fb_helper tasks from
> Documentation/gpu/todo.rst.
> 
> - The max connector argument for drm_fb_helper_init() isn't used
>   anymore and can be removed.
> 
> - The helper doesn't keep an array of connectors anymore so these can
>   be removed: drm_fb_helper_single_add_all_connectors(),
>   drm_fb_helper_add_one_connector() and
>   drm_fb_helper_remove_one_connector().

Entire series applied, thanks for doing this cleanup.
-Daniel

> 
> Changes since v1:
>    - Accumulated all review tags into individual commits (Emil, Daniel) 
>    - Squashed warning fixes into the patch that introduced the
>      warnings (into 5/7) (Laurent, Emil, Lyude)
>    - Remove entire drm_fb_helper tasks from todo list. Daniel's
>      "64914da24ea9 drm/fbdev-helper: don't force restores" fixes first
>      one (Daniel)
> 
> Pankaj Bharadiya (7):
>   drm: Remove unused arg from drm_fb_helper_init
>   drm/radeon: remove radeon_fb_{add,remove}_connector functions
>   drm/amdgpu: Remove drm_fb_helper_{add,remove}_one_connector calls
>   drm/i915/display: Remove drm_fb_helper_{add,remove}_one_connector calls
>   drm: Remove drm_fb_helper add, add all and remove connector calls
>   drm/fb-helper: Remove drm_fb_helper add, add_all and remove connector functions
>   drm/todo: Update drm_fb_helper tasks
> 
>  Documentation/gpu/todo.rst                    | 17 ------------
>  drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c        |  5 +---
>  .../display/amdgpu_dm/amdgpu_dm_mst_types.c   | 13 ---------
>  drivers/gpu/drm/armada/armada_fbdev.c         |  8 +-----
>  drivers/gpu/drm/bridge/tc358764.c             |  3 ---
>  drivers/gpu/drm/drm_fb_helper.c               |  6 ++---
>  drivers/gpu/drm/exynos/exynos_drm_dsi.c       |  1 -
>  drivers/gpu/drm/exynos/exynos_drm_fbdev.c     | 10 +------
>  drivers/gpu/drm/gma500/framebuffer.c          |  6 +----
>  drivers/gpu/drm/i915/display/intel_dp_mst.c   | 12 ---------
>  drivers/gpu/drm/i915/display/intel_fbdev.c    |  4 +--
>  drivers/gpu/drm/msm/msm_fbdev.c               |  6 +----
>  drivers/gpu/drm/nouveau/dispnv50/disp.c       |  7 -----
>  drivers/gpu/drm/nouveau/nouveau_fbcon.c       |  6 +----
>  drivers/gpu/drm/omapdrm/omap_fbdev.c          |  6 +----
>  drivers/gpu/drm/radeon/radeon_dp_mst.c        | 10 -------
>  drivers/gpu/drm/radeon/radeon_fb.c            | 19 +------------
>  drivers/gpu/drm/radeon/radeon_mode.h          |  3 ---
>  drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c |  9 +------
>  drivers/gpu/drm/tegra/fb.c                    |  8 +-----
>  include/drm/drm_fb_helper.h                   | 27 ++-----------------
>  21 files changed, 15 insertions(+), 171 deletions(-)
> 
> -- 
> 2.20.1
>