| Message ID | 1584070036-26447-4-git-send-email-peng.fan@nxp.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | imx: drop dependency on ARM64 | expand |
On Fri, Mar 13, 2020 at 4:34 AM <peng.fan@nxp.com> wrote: > > From: Peng Fan <peng.fan@nxp.com> > > Select ARM_GIC_V3, then it is able to use gic v3 driver in aarch32 > mode linux on aarch64 hardware. For aarch64 mode, it not hurts > to select ARM_GIC_V3. > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- Acked-by: Arnd Bergmann <arnd@arndb.de> > diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig > index 70019cefa617..0b69024296d5 100644 > --- a/drivers/soc/imx/Kconfig > +++ b/drivers/soc/imx/Kconfig > @@ -21,6 +21,7 @@ config SOC_IMX8M > bool "i.MX8M SoC family support" > depends on ARCH_MXC || COMPILE_TEST > default ARCH_MXC && ARM64 > + select ARM_GIC_V3 It would seem sensible to also drop the dependency on the 'default' Arnd
Hi Arnd, > Subject: Re: [PATCH 3/3] soc: imx: select ARM_GIC_V3 for i.MX8M > > On Fri, Mar 13, 2020 at 4:34 AM <peng.fan@nxp.com> wrote: > > > > From: Peng Fan <peng.fan@nxp.com> > > > > Select ARM_GIC_V3, then it is able to use gic v3 driver in aarch32 > > mode linux on aarch64 hardware. For aarch64 mode, it not hurts to > > select ARM_GIC_V3. > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > --- > > Acked-by: Arnd Bergmann <arnd@arndb.de> > > > diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig index > > 70019cefa617..0b69024296d5 100644 > > --- a/drivers/soc/imx/Kconfig > > +++ b/drivers/soc/imx/Kconfig > > @@ -21,6 +21,7 @@ config SOC_IMX8M > > bool "i.MX8M SoC family support" > > depends on ARCH_MXC || COMPILE_TEST > > default ARCH_MXC && ARM64 > > + select ARM_GIC_V3 > > It would seem sensible to also drop the dependency on the 'default' If drop default, we need enable this config option in ARM64 defconfig, I would leave it as is for now. Thanks, Peng. > > Arnd > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.infr > adead.org%2Fmailman%2Flistinfo%2Flinux-arm-kernel&data=02%7C01 > %7Cpeng.fan%40nxp.com%7Ca28680bc024f478a8c4008d7c736ef64%7C686 > ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637196911074143592&a > mp;sdata=jNEcrVlci7UEAhAftKBNSVc4b6%2F0Sm2aOYPIA9ajZl8%3D&re > served=0
On Mon, Mar 16, 2020 at 7:43 AM Peng Fan <peng.fan@nxp.com> wrote: > > Subject: Re: [PATCH 3/3] soc: imx: select ARM_GIC_V3 for i.MX8M > > > > On Fri, Mar 13, 2020 at 4:34 AM <peng.fan@nxp.com> wrote: > > > > > > From: Peng Fan <peng.fan@nxp.com> > > > > > > Select ARM_GIC_V3, then it is able to use gic v3 driver in aarch32 > > > mode linux on aarch64 hardware. For aarch64 mode, it not hurts to > > > select ARM_GIC_V3. > > > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > > --- > > > > Acked-by: Arnd Bergmann <arnd@arndb.de> > > > > > diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig index > > > 70019cefa617..0b69024296d5 100644 > > > --- a/drivers/soc/imx/Kconfig > > > +++ b/drivers/soc/imx/Kconfig > > > @@ -21,6 +21,7 @@ config SOC_IMX8M > > > bool "i.MX8M SoC family support" > > > depends on ARCH_MXC || COMPILE_TEST > > > default ARCH_MXC && ARM64 > > > + select ARM_GIC_V3 > > > > It would seem sensible to also drop the dependency on the 'default' > > If drop default, we need enable this config option in ARM64 defconfig, > I would leave it as is for now. I meant making it 'default ARCH_MXC' so it gets enabled for both 32-bit and 64-bit i.MX configurations, not just 64-bit. Arnd
Hi Arnd, > Subject: Re: [PATCH 3/3] soc: imx: select ARM_GIC_V3 for i.MX8M > > On Mon, Mar 16, 2020 at 7:43 AM Peng Fan <peng.fan@nxp.com> wrote: > > > Subject: Re: [PATCH 3/3] soc: imx: select ARM_GIC_V3 for i.MX8M > > > > > > On Fri, Mar 13, 2020 at 4:34 AM <peng.fan@nxp.com> wrote: > > > > > > > > From: Peng Fan <peng.fan@nxp.com> > > > > > > > > Select ARM_GIC_V3, then it is able to use gic v3 driver in aarch32 > > > > mode linux on aarch64 hardware. For aarch64 mode, it not hurts to > > > > select ARM_GIC_V3. > > > > > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > > > --- > > > > > > Acked-by: Arnd Bergmann <arnd@arndb.de> > > > > > > > diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig > > > > index > > > > 70019cefa617..0b69024296d5 100644 > > > > --- a/drivers/soc/imx/Kconfig > > > > +++ b/drivers/soc/imx/Kconfig > > > > @@ -21,6 +21,7 @@ config SOC_IMX8M > > > > bool "i.MX8M SoC family support" > > > > depends on ARCH_MXC || COMPILE_TEST > > > > default ARCH_MXC && ARM64 > > > > + select ARM_GIC_V3 > > > > > > It would seem sensible to also drop the dependency on the 'default' > > > > If drop default, we need enable this config option in ARM64 defconfig, > > I would leave it as is for now. > > I meant making it 'default ARCH_MXC' so it gets enabled for both 32-bit and > 64-bit i.MX configurations, not just 64-bit. Understand. I'll drop ARM64 and post v2 with your A-b. Thanks, Peng. > > Arnd
diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig index 70019cefa617..0b69024296d5 100644 --- a/drivers/soc/imx/Kconfig +++ b/drivers/soc/imx/Kconfig @@ -21,6 +21,7 @@ config SOC_IMX8M bool "i.MX8M SoC family support" depends on ARCH_MXC || COMPILE_TEST default ARCH_MXC && ARM64 + select ARM_GIC_V3 help If you say yes here you get support for the NXP i.MX8M family support, it will provide the SoC info like SoC family,