| Message ID | 1584606380-9972-1-git-send-email-Anson.Huang@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Daniel Lezcano |
| Headers | show |
| Series | thermal: imx_sc_thermal: Fix incorrect data type | expand |
On Thu, Mar 19, 2020 at 2:03 PM Anson Huang <Anson.Huang@nxp.com> wrote: > > The temperature value passed from SCU could be negative value, > the data type should be signed instead of unsigned. > > Fixes: ed0843633fee ("thermal: imx_sc: add i.MX system controller thermal support") > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org> > --- > drivers/thermal/imx_sc_thermal.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/thermal/imx_sc_thermal.c b/drivers/thermal/imx_sc_thermal.c > index dbb277a..a8723b1 100644 > --- a/drivers/thermal/imx_sc_thermal.c > +++ b/drivers/thermal/imx_sc_thermal.c > @@ -30,8 +30,8 @@ struct req_get_temp { > } __packed __aligned(4); > > struct resp_get_temp { > - u16 celsius; > - u8 tenths; > + s16 celsius; > + s8 tenths; > } __packed __aligned(4); > > struct imx_sc_msg_misc_get_temp { > -- > 2.7.4 >
On 19/03/2020 09:26, Anson Huang wrote: > The temperature value passed from SCU could be negative value, > the data type should be signed instead of unsigned. > > Fixes: ed0843633fee ("thermal: imx_sc: add i.MX system controller thermal support") > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> Applied, thanks > --- > drivers/thermal/imx_sc_thermal.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/thermal/imx_sc_thermal.c b/drivers/thermal/imx_sc_thermal.c > index dbb277a..a8723b1 100644 > --- a/drivers/thermal/imx_sc_thermal.c > +++ b/drivers/thermal/imx_sc_thermal.c > @@ -30,8 +30,8 @@ struct req_get_temp { > } __packed __aligned(4); > > struct resp_get_temp { > - u16 celsius; > - u8 tenths; > + s16 celsius; > + s8 tenths; > } __packed __aligned(4); > > struct imx_sc_msg_misc_get_temp { >
diff --git a/drivers/thermal/imx_sc_thermal.c b/drivers/thermal/imx_sc_thermal.c index dbb277a..a8723b1 100644 --- a/drivers/thermal/imx_sc_thermal.c +++ b/drivers/thermal/imx_sc_thermal.c @@ -30,8 +30,8 @@ struct req_get_temp { } __packed __aligned(4); struct resp_get_temp { - u16 celsius; - u8 tenths; + s16 celsius; + s8 tenths; } __packed __aligned(4); struct imx_sc_msg_misc_get_temp {
The temperature value passed from SCU could be negative value, the data type should be signed instead of unsigned. Fixes: ed0843633fee ("thermal: imx_sc: add i.MX system controller thermal support") Signed-off-by: Anson Huang <Anson.Huang@nxp.com> --- drivers/thermal/imx_sc_thermal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)