| Message ID | fe109d58eaa34d68cad0f34bb048f827b336e024.1584639664.git.alexander.riesen@cetitec.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | media: adv748x: add support for HDMI audio | expand |
Hi Alexander, Thank you for the patch. On Thu, Mar 19, 2020 at 06:41:48PM +0100, Alex Riesen wrote: > To follow the established practice of not depending on others to > pull everything in. > > Signed-off-by: Alexander Riesen <alexander.riesen@cetitec.com> Good idea. While at it, could you include "adv748x.h" as the very first header in at least one of the C files ? That will help ensuring the header stays self-contained in the future. > --- > drivers/media/i2c/adv748x/adv748x-afe.c | 2 -- > drivers/media/i2c/adv748x/adv748x-core.c | 2 -- > drivers/media/i2c/adv748x/adv748x-csi2.c | 2 -- > drivers/media/i2c/adv748x/adv748x-hdmi.c | 2 -- > drivers/media/i2c/adv748x/adv748x.h | 2 ++ > 5 files changed, 2 insertions(+), 8 deletions(-) > > diff --git a/drivers/media/i2c/adv748x/adv748x-afe.c b/drivers/media/i2c/adv748x/adv748x-afe.c > index dbbb1e4d6363..ab0479641c10 100644 > --- a/drivers/media/i2c/adv748x/adv748x-afe.c > +++ b/drivers/media/i2c/adv748x/adv748x-afe.c > @@ -11,8 +11,6 @@ > #include <linux/mutex.h> > #include <linux/v4l2-dv-timings.h> > > -#include <media/v4l2-ctrls.h> > -#include <media/v4l2-device.h> > #include <media/v4l2-dv-timings.h> > #include <media/v4l2-ioctl.h> > > diff --git a/drivers/media/i2c/adv748x/adv748x-core.c b/drivers/media/i2c/adv748x/adv748x-core.c > index c3fb113cef62..345f009de121 100644 > --- a/drivers/media/i2c/adv748x/adv748x-core.c > +++ b/drivers/media/i2c/adv748x/adv748x-core.c > @@ -20,8 +20,6 @@ > #include <linux/slab.h> > #include <linux/v4l2-dv-timings.h> > > -#include <media/v4l2-ctrls.h> > -#include <media/v4l2-device.h> > #include <media/v4l2-dv-timings.h> > #include <media/v4l2-fwnode.h> > #include <media/v4l2-ioctl.h> > diff --git a/drivers/media/i2c/adv748x/adv748x-csi2.c b/drivers/media/i2c/adv748x/adv748x-csi2.c > index c43ce5d78723..78d391009b5a 100644 > --- a/drivers/media/i2c/adv748x/adv748x-csi2.c > +++ b/drivers/media/i2c/adv748x/adv748x-csi2.c > @@ -8,8 +8,6 @@ > #include <linux/module.h> > #include <linux/mutex.h> > > -#include <media/v4l2-ctrls.h> > -#include <media/v4l2-device.h> > #include <media/v4l2-ioctl.h> > > #include "adv748x.h" > diff --git a/drivers/media/i2c/adv748x/adv748x-hdmi.c b/drivers/media/i2c/adv748x/adv748x-hdmi.c > index c557f8fdf11a..0dffcdf79ff2 100644 > --- a/drivers/media/i2c/adv748x/adv748x-hdmi.c > +++ b/drivers/media/i2c/adv748x/adv748x-hdmi.c > @@ -8,8 +8,6 @@ > #include <linux/module.h> > #include <linux/mutex.h> > > -#include <media/v4l2-ctrls.h> > -#include <media/v4l2-device.h> > #include <media/v4l2-dv-timings.h> > #include <media/v4l2-ioctl.h> > > diff --git a/drivers/media/i2c/adv748x/adv748x.h b/drivers/media/i2c/adv748x/adv748x.h > index fccb388ce179..09aab4138c3f 100644 > --- a/drivers/media/i2c/adv748x/adv748x.h > +++ b/drivers/media/i2c/adv748x/adv748x.h > @@ -19,6 +19,8 @@ > */ > > #include <linux/i2c.h> > +#include <media/v4l2-ctrls.h> > +#include <media/v4l2-device.h> > > #ifndef _ADV748X_H_ > #define _ADV748X_H_
Hi Laurent, Laurent Pinchart, Thu, Mar 19, 2020 18:48:02 +0100: > On Thu, Mar 19, 2020 at 06:41:48PM +0100, Alex Riesen wrote: > > To follow the established practice of not depending on others to > > pull everything in. > > Good idea. While at it, could you include "adv748x.h" as the very first > header in at least one of the C files ? That will help ensuring the > header stays self-contained in the future. Done.
diff --git a/drivers/media/i2c/adv748x/adv748x-afe.c b/drivers/media/i2c/adv748x/adv748x-afe.c index dbbb1e4d6363..ab0479641c10 100644 --- a/drivers/media/i2c/adv748x/adv748x-afe.c +++ b/drivers/media/i2c/adv748x/adv748x-afe.c @@ -11,8 +11,6 @@ #include <linux/mutex.h> #include <linux/v4l2-dv-timings.h> -#include <media/v4l2-ctrls.h> -#include <media/v4l2-device.h> #include <media/v4l2-dv-timings.h> #include <media/v4l2-ioctl.h> diff --git a/drivers/media/i2c/adv748x/adv748x-core.c b/drivers/media/i2c/adv748x/adv748x-core.c index c3fb113cef62..345f009de121 100644 --- a/drivers/media/i2c/adv748x/adv748x-core.c +++ b/drivers/media/i2c/adv748x/adv748x-core.c @@ -20,8 +20,6 @@ #include <linux/slab.h> #include <linux/v4l2-dv-timings.h> -#include <media/v4l2-ctrls.h> -#include <media/v4l2-device.h> #include <media/v4l2-dv-timings.h> #include <media/v4l2-fwnode.h> #include <media/v4l2-ioctl.h> diff --git a/drivers/media/i2c/adv748x/adv748x-csi2.c b/drivers/media/i2c/adv748x/adv748x-csi2.c index c43ce5d78723..78d391009b5a 100644 --- a/drivers/media/i2c/adv748x/adv748x-csi2.c +++ b/drivers/media/i2c/adv748x/adv748x-csi2.c @@ -8,8 +8,6 @@ #include <linux/module.h> #include <linux/mutex.h> -#include <media/v4l2-ctrls.h> -#include <media/v4l2-device.h> #include <media/v4l2-ioctl.h> #include "adv748x.h" diff --git a/drivers/media/i2c/adv748x/adv748x-hdmi.c b/drivers/media/i2c/adv748x/adv748x-hdmi.c index c557f8fdf11a..0dffcdf79ff2 100644 --- a/drivers/media/i2c/adv748x/adv748x-hdmi.c +++ b/drivers/media/i2c/adv748x/adv748x-hdmi.c @@ -8,8 +8,6 @@ #include <linux/module.h> #include <linux/mutex.h> -#include <media/v4l2-ctrls.h> -#include <media/v4l2-device.h> #include <media/v4l2-dv-timings.h> #include <media/v4l2-ioctl.h> diff --git a/drivers/media/i2c/adv748x/adv748x.h b/drivers/media/i2c/adv748x/adv748x.h index fccb388ce179..09aab4138c3f 100644 --- a/drivers/media/i2c/adv748x/adv748x.h +++ b/drivers/media/i2c/adv748x/adv748x.h @@ -19,6 +19,8 @@ */ #include <linux/i2c.h> +#include <media/v4l2-ctrls.h> +#include <media/v4l2-device.h> #ifndef _ADV748X_H_ #define _ADV748X_H_
To follow the established practice of not depending on others to pull everything in. Signed-off-by: Alexander Riesen <alexander.riesen@cetitec.com> --- drivers/media/i2c/adv748x/adv748x-afe.c | 2 -- drivers/media/i2c/adv748x/adv748x-core.c | 2 -- drivers/media/i2c/adv748x/adv748x-csi2.c | 2 -- drivers/media/i2c/adv748x/adv748x-hdmi.c | 2 -- drivers/media/i2c/adv748x/adv748x.h | 2 ++ 5 files changed, 2 insertions(+), 8 deletions(-)