[v3,0/5] platform/x86: intel_pmc_core: Add bug fixes or code

Message ID	cover.1583093898.git.gayatri.kammela@intel.com (mailing list archive)
Headers	show Return-Path: <SRS0=AYBp=4S=vger.kernel.org=platform-driver-x86-owner@kernel.org> From: Gayatri Kammela <gayatri.kammela@intel.com> To: platform-driver-x86@vger.kernel.org Cc: linux-kernel@vger.kernel.org, vishwanath.somayaji@intel.com, dvhart@infradead.org, mika.westerberg@intel.com, peterz@infradead.org, charles.d.prestopine@intel.com, Gayatri Kammela <gayatri.kammela@intel.com>, Chen Zhou <chenzhou10@huawei.com>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, David Box <david.e.box@intel.com> Subject: [PATCH v3 0/5] platform/x86: intel_pmc_core: Add bug fixes or code Date: Sun, 1 Mar 2020 12:44:21 -0800 Message-Id: <cover.1583093898.git.gayatri.kammela@intel.com> Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk
Series	platform/x86: intel_pmc_core: Add bug fixes or code \| expand [v3,0/5] platform/x86: intel_pmc_core: Add bug fixes or code [v3,1/5] platform/x86: intel_pmc_core: fix: Relocate pmc_core_slps0_display() and pmc_core_lpm_disp… [v3,2/5] platform/x86: intel_pmc_core: fix: Remove the duplicate if() to create debugfs entry for s… [v3,3/5] platform/x86: intel_pmc_core: fix: Add slp_s0_offset attribute back to tgl_reg_map [v3,4/5] platform/x86: intel_pmc_core: Make pmc_core_substate_res_show() generic [v3,5/5] platform/x86: intel_pmc_core: fix: Make pmc_core_lpm_display() generic for platforms that …

Kammela, Gayatri March 1, 2020, 8:44 p.m. UTC

Hi,

This patch series consists of bug fixes and code optimization for the
series https://patchwork.kernel.org/patch/11365325/

Patch 1: Relocate both pmc_core_slps0_display() and pmc_core_lpm_display()
Patch 2: Remove the duplicate if() condition to create debugfs entry
Patch 3: Add back slp_s0_offset attribute back to tgl_reg_map
Patch 4: Make pmc_core_substate_res_show() generic
Patch 5: Make pmc_core_lpm_display() generic

Changes since v1:
1) Changed the order of the patches i.e., patch 2 in v1 is made first in
   the order for v2.
2) Fixed the warnings reported by kbuild test robot.

Changes since v2:
1) Add "Make pmc_core_substate_res_show() generic" patch to v3.
2) Fixed the memory leak issue in pmc_core_lpm_display().
3) Moved patch 2 in v2 to the last in the series in v3.

Gayatri Kammela (5):
  platform/x86: intel_pmc_core: fix: Relocate pmc_core_slps0_display()
    and pmc_core_lpm_display() to outside of CONFIG_DEBUG_FS
  platform/x86: intel_pmc_core: fix: Remove the duplicate if() to create
    debugfs entry for substate_live_status_registers
  platform/x86: intel_pmc_core: fix: Add slp_s0_offset attribute back to
    tgl_reg_map
  platform/x86: intel_pmc_core: Make pmc_core_substate_res_show()
    generic
  platform/x86: intel_pmc_core: fix: Make pmc_core_lpm_display() generic
    for platforms that support sub-states

 drivers/platform/x86/intel_pmc_core.c | 148 +++++++++++++++-----------
 drivers/platform/x86/intel_pmc_core.h |   3 +-
 2 files changed, 85 insertions(+), 66 deletions(-)

base-commit: 7adb1e8aeeb5d4d88012568b2049599c1a247cf2

Cc: Chen Zhou <chenzhou10@huawei.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: David Box <david.e.box@intel.com>

Andy Shevchenko March 2, 2020, 12:54 p.m. UTC | #1

On Sun, Mar 01, 2020 at 12:44:21PM -0800, Gayatri Kammela wrote:
> Hi,
> 
> This patch series consists of bug fixes and code optimization for the
> series https://patchwork.kernel.org/patch/11365325/
> 

I had applied first four, the fifth requires additional work.
When send a new version, do it only for last one.

> Patch 1: Relocate both pmc_core_slps0_display() and pmc_core_lpm_display()
> Patch 2: Remove the duplicate if() condition to create debugfs entry
> Patch 3: Add back slp_s0_offset attribute back to tgl_reg_map
> Patch 4: Make pmc_core_substate_res_show() generic
> Patch 5: Make pmc_core_lpm_display() generic
> 
> Changes since v1:
> 1) Changed the order of the patches i.e., patch 2 in v1 is made first in
>    the order for v2.
> 2) Fixed the warnings reported by kbuild test robot.
> 
> Changes since v2:
> 1) Add "Make pmc_core_substate_res_show() generic" patch to v3.
> 2) Fixed the memory leak issue in pmc_core_lpm_display().
> 3) Moved patch 2 in v2 to the last in the series in v3.
> 
> Gayatri Kammela (5):
>   platform/x86: intel_pmc_core: fix: Relocate pmc_core_slps0_display()
>     and pmc_core_lpm_display() to outside of CONFIG_DEBUG_FS
>   platform/x86: intel_pmc_core: fix: Remove the duplicate if() to create
>     debugfs entry for substate_live_status_registers
>   platform/x86: intel_pmc_core: fix: Add slp_s0_offset attribute back to
>     tgl_reg_map
>   platform/x86: intel_pmc_core: Make pmc_core_substate_res_show()
>     generic
>   platform/x86: intel_pmc_core: fix: Make pmc_core_lpm_display() generic
>     for platforms that support sub-states
> 
>  drivers/platform/x86/intel_pmc_core.c | 148 +++++++++++++++-----------
>  drivers/platform/x86/intel_pmc_core.h |   3 +-
>  2 files changed, 85 insertions(+), 66 deletions(-)
> 
> base-commit: 7adb1e8aeeb5d4d88012568b2049599c1a247cf2
> 
> Cc: Chen Zhou <chenzhou10@huawei.com>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: David Box <david.e.box@intel.com>
> -- 
> 2.17.1
>

Kammela, Gayatri March 2, 2020, 6:29 p.m. UTC | #2

> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Sent: Monday, March 2, 2020 4:54 AM
> To: Kammela, Gayatri <gayatri.kammela@intel.com>
> Cc: platform-driver-x86@vger.kernel.org; linux-kernel@vger.kernel.org;
> Somayaji, Vishwanath <vishwanath.somayaji@intel.com>;
> dvhart@infradead.org; Westerberg, Mika <mika.westerberg@intel.com>;
> peterz@infradead.org; Prestopine, Charles D
> <charles.d.prestopine@intel.com>; Chen Zhou <chenzhou10@huawei.com>;
> Box, David E <david.e.box@intel.com>
> Subject: Re: [PATCH v3 0/5] platform/x86: intel_pmc_core: Add bug fixes or
> code
> 
> On Sun, Mar 01, 2020 at 12:44:21PM -0800, Gayatri Kammela wrote:
> > Hi,
> >
> > This patch series consists of bug fixes and code optimization for the
> > series https://patchwork.kernel.org/patch/11365325/
> >
> 
> I had applied first four, the fifth requires additional work.
> When send a new version, do it only for last one.

Thanks Andy! I will send the 5th patch alone in new version.

> 
> > Patch 1: Relocate both pmc_core_slps0_display() and
> > pmc_core_lpm_display() Patch 2: Remove the duplicate if() condition to
> > create debugfs entry Patch 3: Add back slp_s0_offset attribute back to
> > tgl_reg_map Patch 4: Make pmc_core_substate_res_show() generic Patch
> > 5: Make pmc_core_lpm_display() generic
> >
> > Changes since v1:
> > 1) Changed the order of the patches i.e., patch 2 in v1 is made first in
> >    the order for v2.
> > 2) Fixed the warnings reported by kbuild test robot.
> >
> > Changes since v2:
> > 1) Add "Make pmc_core_substate_res_show() generic" patch to v3.
> > 2) Fixed the memory leak issue in pmc_core_lpm_display().
> > 3) Moved patch 2 in v2 to the last in the series in v3.
> >
> > Gayatri Kammela (5):
> >   platform/x86: intel_pmc_core: fix: Relocate pmc_core_slps0_display()
> >     and pmc_core_lpm_display() to outside of CONFIG_DEBUG_FS
> >   platform/x86: intel_pmc_core: fix: Remove the duplicate if() to create
> >     debugfs entry for substate_live_status_registers
> >   platform/x86: intel_pmc_core: fix: Add slp_s0_offset attribute back to
> >     tgl_reg_map
> >   platform/x86: intel_pmc_core: Make pmc_core_substate_res_show()
> >     generic
> >   platform/x86: intel_pmc_core: fix: Make pmc_core_lpm_display() generic
> >     for platforms that support sub-states
> >
> >  drivers/platform/x86/intel_pmc_core.c | 148 +++++++++++++++-----------
> >  drivers/platform/x86/intel_pmc_core.h |   3 +-
> >  2 files changed, 85 insertions(+), 66 deletions(-)
> >
> > base-commit: 7adb1e8aeeb5d4d88012568b2049599c1a247cf2
> >
> > Cc: Chen Zhou <chenzhou10@huawei.com>
> > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Cc: David Box <david.e.box@intel.com>
> > --
> > 2.17.1
> >
> 
> --
> With Best Regards,
> Andy Shevchenko
>

Kammela, Gayatri March 19, 2020, 5:57 p.m. UTC | #3

> -----Original Message-----
> From: Kammela, Gayatri
> Sent: Monday, March 2, 2020 10:29 AM
> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: platform-driver-x86@vger.kernel.org; linux-kernel@vger.kernel.org;
> Somayaji, Vishwanath <vishwanath.somayaji@intel.com>;
> dvhart@infradead.org; Westerberg, Mika <mika.westerberg@intel.com>;
> peterz@infradead.org; Prestopine, Charles D
> <charles.d.prestopine@intel.com>; Chen Zhou <chenzhou10@huawei.com>;
> Box, David E <david.e.box@intel.com>
> Subject: RE: [PATCH v3 0/5] platform/x86: intel_pmc_core: Add bug fixes or
> code
> 
> > -----Original Message-----
> > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Sent: Monday, March 2, 2020 4:54 AM
> > To: Kammela, Gayatri <gayatri.kammela@intel.com>
> > Cc: platform-driver-x86@vger.kernel.org; linux-kernel@vger.kernel.org;
> > Somayaji, Vishwanath <vishwanath.somayaji@intel.com>;
> > dvhart@infradead.org; Westerberg, Mika <mika.westerberg@intel.com>;
> > peterz@infradead.org; Prestopine, Charles D
> > <charles.d.prestopine@intel.com>; Chen Zhou
> <chenzhou10@huawei.com>;
> > Box, David E <david.e.box@intel.com>
> > Subject: Re: [PATCH v3 0/5] platform/x86: intel_pmc_core: Add bug
> > fixes or code
> >
> > On Sun, Mar 01, 2020 at 12:44:21PM -0800, Gayatri Kammela wrote:
> > > Hi,
> > >
> > > This patch series consists of bug fixes and code optimization for
> > > the series https://patchwork.kernel.org/patch/11365325/
> > >
> >
> > I had applied first four, the fifth requires additional work.
> > When send a new version, do it only for last one.
> 
> Thanks Andy! I will send the 5th patch alone in new version.
> 

Hi Andy! I see first 3 patches are merged in for-next branch on 2/28 but not 4th patch. Can you please check? http://git.infradead.org/linux-platform-drivers-x86.git/shortlog/refs/heads/for-next

> >
> > > Patch 1: Relocate both pmc_core_slps0_display() and
> > > pmc_core_lpm_display() Patch 2: Remove the duplicate if() condition
> > > to create debugfs entry Patch 3: Add back slp_s0_offset attribute
> > > back to tgl_reg_map Patch 4: Make pmc_core_substate_res_show()
> > > generic Patch
> > > 5: Make pmc_core_lpm_display() generic
> > >
> > > Changes since v1:
> > > 1) Changed the order of the patches i.e., patch 2 in v1 is made first in
> > >    the order for v2.
> > > 2) Fixed the warnings reported by kbuild test robot.
> > >
> > > Changes since v2:
> > > 1) Add "Make pmc_core_substate_res_show() generic" patch to v3.
> > > 2) Fixed the memory leak issue in pmc_core_lpm_display().
> > > 3) Moved patch 2 in v2 to the last in the series in v3.
> > >
> > > Gayatri Kammela (5):
> > >   platform/x86: intel_pmc_core: fix: Relocate pmc_core_slps0_display()
> > >     and pmc_core_lpm_display() to outside of CONFIG_DEBUG_FS
> > >   platform/x86: intel_pmc_core: fix: Remove the duplicate if() to create
> > >     debugfs entry for substate_live_status_registers
> > >   platform/x86: intel_pmc_core: fix: Add slp_s0_offset attribute back to
> > >     tgl_reg_map
> > >   platform/x86: intel_pmc_core: Make pmc_core_substate_res_show()
> > >     generic
> > >   platform/x86: intel_pmc_core: fix: Make pmc_core_lpm_display()
> generic
> > >     for platforms that support sub-states
> > >
> > >  drivers/platform/x86/intel_pmc_core.c | 148 +++++++++++++++-----------
> > >  drivers/platform/x86/intel_pmc_core.h |   3 +-
> > >  2 files changed, 85 insertions(+), 66 deletions(-)
> > >
> > > base-commit: 7adb1e8aeeb5d4d88012568b2049599c1a247cf2
> > >
> > > Cc: Chen Zhou <chenzhou10@huawei.com>
> > > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > Cc: David Box <david.e.box@intel.com>
> > > --
> > > 2.17.1
> > >
> >
> > --
> > With Best Regards,
> > Andy Shevchenko
> >

Andy Shevchenko March 19, 2020, 6:06 p.m. UTC | #4

On Thu, Mar 19, 2020 at 05:57:06PM +0000, Kammela, Gayatri wrote:
> > -----Original Message-----
> > From: Kammela, Gayatri
> > Sent: Monday, March 2, 2020 10:29 AM
> > To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Cc: platform-driver-x86@vger.kernel.org; linux-kernel@vger.kernel.org;
> > Somayaji, Vishwanath <vishwanath.somayaji@intel.com>;
> > dvhart@infradead.org; Westerberg, Mika <mika.westerberg@intel.com>;
> > peterz@infradead.org; Prestopine, Charles D
> > <charles.d.prestopine@intel.com>; Chen Zhou <chenzhou10@huawei.com>;
> > Box, David E <david.e.box@intel.com>
> > Subject: RE: [PATCH v3 0/5] platform/x86: intel_pmc_core: Add bug fixes or
> > code
> > 
> > > -----Original Message-----
> > > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > Sent: Monday, March 2, 2020 4:54 AM
> > > To: Kammela, Gayatri <gayatri.kammela@intel.com>
> > > Cc: platform-driver-x86@vger.kernel.org; linux-kernel@vger.kernel.org;
> > > Somayaji, Vishwanath <vishwanath.somayaji@intel.com>;
> > > dvhart@infradead.org; Westerberg, Mika <mika.westerberg@intel.com>;
> > > peterz@infradead.org; Prestopine, Charles D
> > > <charles.d.prestopine@intel.com>; Chen Zhou
> > <chenzhou10@huawei.com>;
> > > Box, David E <david.e.box@intel.com>
> > > Subject: Re: [PATCH v3 0/5] platform/x86: intel_pmc_core: Add bug
> > > fixes or code
> > >
> > > On Sun, Mar 01, 2020 at 12:44:21PM -0800, Gayatri Kammela wrote:
> > > > Hi,
> > > >
> > > > This patch series consists of bug fixes and code optimization for
> > > > the series https://patchwork.kernel.org/patch/11365325/
> > > >
> > >
> > > I had applied first four, the fifth requires additional work.
> > > When send a new version, do it only for last one.
> > 
> > Thanks Andy! I will send the 5th patch alone in new version.
> > 
> 
> Hi Andy! I see first 3 patches are merged in for-next branch on 2/28 but not 4th patch. Can you please check? http://git.infradead.org/linux-platform-drivers-x86.git/shortlog/refs/heads/for-next


Is it in my review and testing queue?

Kammela, Gayatri March 19, 2020, 6:15 p.m. UTC | #5

> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Sent: Thursday, March 19, 2020 11:06 AM
> To: Kammela, Gayatri <gayatri.kammela@intel.com>
> Cc: platform-driver-x86@vger.kernel.org; linux-kernel@vger.kernel.org;
> Somayaji, Vishwanath <vishwanath.somayaji@intel.com>;
> dvhart@infradead.org; Westerberg, Mika <mika.westerberg@intel.com>;
> peterz@infradead.org; Prestopine, Charles D
> <charles.d.prestopine@intel.com>; Chen Zhou <chenzhou10@huawei.com>;
> Box, David E <david.e.box@intel.com>
> Subject: Re: [PATCH v3 0/5] platform/x86: intel_pmc_core: Add bug fixes or
> code
> 
> On Thu, Mar 19, 2020 at 05:57:06PM +0000, Kammela, Gayatri wrote:
> > > -----Original Message-----
> > > From: Kammela, Gayatri
> > > Sent: Monday, March 2, 2020 10:29 AM
> > > To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > Cc: platform-driver-x86@vger.kernel.org;
> > > linux-kernel@vger.kernel.org; Somayaji, Vishwanath
> > > <vishwanath.somayaji@intel.com>; dvhart@infradead.org; Westerberg,
> > > Mika <mika.westerberg@intel.com>; peterz@infradead.org; Prestopine,
> > > Charles D <charles.d.prestopine@intel.com>; Chen Zhou
> > > <chenzhou10@huawei.com>; Box, David E <david.e.box@intel.com>
> > > Subject: RE: [PATCH v3 0/5] platform/x86: intel_pmc_core: Add bug
> > > fixes or code
> > >
> > > > -----Original Message-----
> > > > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > > Sent: Monday, March 2, 2020 4:54 AM
> > > > To: Kammela, Gayatri <gayatri.kammela@intel.com>
> > > > Cc: platform-driver-x86@vger.kernel.org;
> > > > linux-kernel@vger.kernel.org; Somayaji, Vishwanath
> > > > <vishwanath.somayaji@intel.com>; dvhart@infradead.org;
> Westerberg,
> > > > Mika <mika.westerberg@intel.com>; peterz@infradead.org;
> > > > Prestopine, Charles D <charles.d.prestopine@intel.com>; Chen Zhou
> > > <chenzhou10@huawei.com>;
> > > > Box, David E <david.e.box@intel.com>
> > > > Subject: Re: [PATCH v3 0/5] platform/x86: intel_pmc_core: Add bug
> > > > fixes or code
> > > >
> > > > On Sun, Mar 01, 2020 at 12:44:21PM -0800, Gayatri Kammela wrote:
> > > > > Hi,
> > > > >
> > > > > This patch series consists of bug fixes and code optimization
> > > > > for the series https://patchwork.kernel.org/patch/11365325/
> > > > >
> > > >
> > > > I had applied first four, the fifth requires additional work.
> > > > When send a new version, do it only for last one.
> > >
> > > Thanks Andy! I will send the 5th patch alone in new version.
> > >
> >
> > Hi Andy! I see first 3 patches are merged in for-next branch on 2/28
> > but not 4th patch. Can you please check?
> > http://git.infradead.org/linux-platform-drivers-x86.git/shortlog/refs/
> > heads/for-next
> 
> 
> Is it in my review and testing queue?

I think it is archived and superseded https://patchwork.kernel.org/patch/11414379/

> 
> --
> With Best Regards,
> Andy Shevchenko
>

Andy Shevchenko March 20, 2020, 1:50 p.m. UTC | #6

On Thu, Mar 19, 2020 at 8:16 PM Kammela, Gayatri
<gayatri.kammela@intel.com> wrote:
>
> > Is it in my review and testing queue?
>
> I think it is archived and superseded https://patchwork.kernel.org/patch/11414379/

Now everything in for-next, check if something is missed and resend.

Kammela, Gayatri March 20, 2020, 5:34 p.m. UTC | #7

> -----Original Message-----
> From: Andy Shevchenko <andy.shevchenko@gmail.com>
> Sent: Friday, March 20, 2020 6:50 AM
> To: Kammela, Gayatri <gayatri.kammela@intel.com>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>; platform-
> driver-x86@vger.kernel.org; linux-kernel@vger.kernel.org; Somayaji,
> Vishwanath <vishwanath.somayaji@intel.com>; dvhart@infradead.org;
> Westerberg, Mika <mika.westerberg@intel.com>; peterz@infradead.org;
> Prestopine, Charles D <charles.d.prestopine@intel.com>; Chen Zhou
> <chenzhou10@huawei.com>; Box, David E <david.e.box@intel.com>
> Subject: Re: [PATCH v3 0/5] platform/x86: intel_pmc_core: Add bug fixes or
> code
> 
> On Thu, Mar 19, 2020 at 8:16 PM Kammela, Gayatri
> <gayatri.kammela@intel.com> wrote:
> >
> > > Is it in my review and testing queue?
> >
> > I think it is archived and superseded
> > https://patchwork.kernel.org/patch/11414379/
> 
> Now everything in for-next, check if something is missed and resend.
Thanks Andy! I just noticed 5th patch in this version is accepted but 4th is still showing superseded. To avoid confusion, I will resend the 4th patch alone.
> 
> --
> With Best Regards,
> Andy Shevchenko

[v3,0/5] platform/x86: intel_pmc_core: Add bug fixes or code

Message

Comments