| Message ID | 3218661.LZWGnKmheA@crow (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [RESUBMIT,1/1] hwmon: (tmp513) Fix build issue by selecting CONFIG_REGMAP_I2C | expand |
On Mon, Mar 23, 2020 at 10:50:18AM -0400, Mike Pagano wrote: > Thanks for the review, Guenter. > --- Please have a look into Documentation/process/submitting-patches.rst. This is not a resubmit, and above comments should come after ---, not before it. On top of that, it is corrupted (tabs replaced with spaces). Guenter > > This driver requires REGMAP_I2C to build. Select it by default in Kconfig. > Reported at gentoo bugzilla: https://bugs.gentoo.org/710790 > > Reported-by: Phil Stracchino <phils@caerllewys.net> > Signed-off-by: Mike Pagano <mpagano@gentoo.org> > --- > drivers/hwmon/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig > index 47ac20aee06f..530b4f29ba85 100644 > --- a/drivers/hwmon/Kconfig > +++ b/drivers/hwmon/Kconfig > @@ -1769,6 +1769,7 @@ config SENSORS_TMP421 > config SENSORS_TMP513 > tristate "Texas Instruments TMP513 and compatibles" > depends on I2C > + select REGMAP_I2C > help > If you say yes here you get support for Texas Instruments TMP512, > and TMP513 temperature and power supply sensor chips. > -- > 2.24.1 > >
diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig index 47ac20aee06f..530b4f29ba85 100644 --- a/drivers/hwmon/Kconfig +++ b/drivers/hwmon/Kconfig @@ -1769,6 +1769,7 @@ config SENSORS_TMP421 config SENSORS_TMP513 tristate "Texas Instruments TMP513 and compatibles" depends on I2C + select REGMAP_I2C help If you say yes here you get support for Texas Instruments TMP512, and TMP513 temperature and power supply sensor chips.
Thanks for the review, Guenter. --- This driver requires REGMAP_I2C to build. Select it by default in Kconfig. Reported at gentoo bugzilla: https://bugs.gentoo.org/710790 Reported-by: Phil Stracchino <phils@caerllewys.net> Signed-off-by: Mike Pagano <mpagano@gentoo.org> --- drivers/hwmon/Kconfig | 1 + 1 file changed, 1 insertion(+)