| Message ID | 5c6bef6462d135b748f58f8c2645c60234482f52.1584904896.git.mh12gx2825@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | staging: iio: adc: General code reformatting / cleanup patchset | expand |
On Mon, 2020-03-23 at 01:24 +0530, Deepak R Varma wrote: > [External] > > Re-indent enum labels as per coding style guidelines. Problem > detected by checkpatch script. > Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com> > Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com> > --- > > Changes since v2: > - None. Version number increment to follow patch series version. > > Changes since v1: > 1. Separated other change into a separate patch as suggested by > Greg KH. > > > drivers/iio/adc/ad7192.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c > index 8ec28aa8fa8a..02981f3d1794 100644 > --- a/drivers/iio/adc/ad7192.c > +++ b/drivers/iio/adc/ad7192.c > @@ -157,8 +157,8 @@ > */ > > enum { > - AD7192_SYSCALIB_ZERO_SCALE, > - AD7192_SYSCALIB_FULL_SCALE, > + AD7192_SYSCALIB_ZERO_SCALE, > + AD7192_SYSCALIB_FULL_SCALE, > }; > > struct ad7192_state {
On Mon, 2020-03-23 at 01:24 +0530, Deepak R Varma wrote: > [External] > > Re-indent enum labels as per coding style guidelines. Problem > detected by checkpatch script. It's customary to keep the review tags you receive from earlier patchsets in your next sets. Uou can now add it [typically before your Signed-off-by tag] starting with V3 and onwards. You don't need to send a V4 just for this. So, I added [for this]: Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com> > Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com> > --- > > Changes since v2: > - None. Version number increment to follow patch series version. > > Changes since v1: > 1. Separated other change into a separate patch as suggested by > Greg KH. > > > drivers/iio/adc/ad7192.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c > index 8ec28aa8fa8a..02981f3d1794 100644 > --- a/drivers/iio/adc/ad7192.c > +++ b/drivers/iio/adc/ad7192.c > @@ -157,8 +157,8 @@ > */ > > enum { > - AD7192_SYSCALIB_ZERO_SCALE, > - AD7192_SYSCALIB_FULL_SCALE, > + AD7192_SYSCALIB_ZERO_SCALE, > + AD7192_SYSCALIB_FULL_SCALE, > }; > > struct ad7192_state {
On Thu, 2020-03-26 at 08:19 +0000, Ardelean, Alexandru wrote: > [External] > > On Mon, 2020-03-23 at 01:24 +0530, Deepak R Varma wrote: > > [External] > > > > Re-indent enum labels as per coding style guidelines. Problem > > detected by checkpatch script. > > It's customary to keep the review tags you receive from earlier patchsets in > your next sets. > Uou can now add it [typically before your Signed-off-by tag] starting with V3 > and onwards. > You don't need to send a V4 just for this. > > So, I added [for this]: > > Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com> Wait; my bad; I am getting lost in emails now. I found a Reviewed-by tag on this set. Disregard this comment. > > > > Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com> > > --- > > > > Changes since v2: > > - None. Version number increment to follow patch series version. > > > > Changes since v1: > > 1. Separated other change into a separate patch as suggested by > > Greg KH. > > > > > > drivers/iio/adc/ad7192.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c > > index 8ec28aa8fa8a..02981f3d1794 100644 > > --- a/drivers/iio/adc/ad7192.c > > +++ b/drivers/iio/adc/ad7192.c > > @@ -157,8 +157,8 @@ > > */ > > > > enum { > > - AD7192_SYSCALIB_ZERO_SCALE, > > - AD7192_SYSCALIB_FULL_SCALE, > > + AD7192_SYSCALIB_ZERO_SCALE, > > + AD7192_SYSCALIB_FULL_SCALE, > > }; > > > > struct ad7192_state {
diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c index 8ec28aa8fa8a..02981f3d1794 100644 --- a/drivers/iio/adc/ad7192.c +++ b/drivers/iio/adc/ad7192.c @@ -157,8 +157,8 @@ */ enum { - AD7192_SYSCALIB_ZERO_SCALE, - AD7192_SYSCALIB_FULL_SCALE, + AD7192_SYSCALIB_ZERO_SCALE, + AD7192_SYSCALIB_FULL_SCALE, }; struct ad7192_state {
Re-indent enum labels as per coding style guidelines. Problem detected by checkpatch script. Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com> --- Changes since v2: - None. Version number increment to follow patch series version. Changes since v1: 1. Separated other change into a separate patch as suggested by Greg KH. drivers/iio/adc/ad7192.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)