| Message ID | 20200130163232.10446-8-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | python: Explicit usage of Python 3 | expand |
On 1/30/20 5:32 PM, Philippe Mathieu-Daudé wrote: > Patch created mechanically by running: > > $ chmod 644 $(git grep -lF '#!/usr/bin/env python' \ > | xargs grep -L 'if __name__.*__main__') > $ sed -i "/^#\!\/usr\/bin\/\(env\ \)\?python.\?$/d" \ > $(git grep -lF '#!/usr/bin/env python' \ > | xargs grep -L 'if __name__.*__main__') > > Reported-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> > Suggested-by: Stefan Hajnoczi <stefanha@redhat.com> > Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com> > Acked-by: Stefan Hajnoczi <stefanha@redhat.com> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > tests/acceptance/virtio_seg_max_adjust.py | 1 - > tests/acceptance/x86_cpu_model_versions.py | 1 - > 2 files changed, 2 deletions(-) > mode change 100755 => 100644 tests/acceptance/virtio_seg_max_adjust.py > > diff --git a/tests/acceptance/virtio_seg_max_adjust.py b/tests/acceptance/virtio_seg_max_adjust.py > old mode 100755 > new mode 100644 > index 5458573138..8d4f24da49 > --- a/tests/acceptance/virtio_seg_max_adjust.py > +++ b/tests/acceptance/virtio_seg_max_adjust.py > @@ -1,4 +1,3 @@ > -#!/usr/bin/env python > # > # Test virtio-scsi and virtio-blk queue settings for all machine types > # > diff --git a/tests/acceptance/x86_cpu_model_versions.py b/tests/acceptance/x86_cpu_model_versions.py > index 90558d9a71..01ff614ec2 100644 > --- a/tests/acceptance/x86_cpu_model_versions.py > +++ b/tests/acceptance/x86_cpu_model_versions.py > @@ -1,4 +1,3 @@ > -#!/usr/bin/env python > # > # Basic validation of x86 versioned CPU models and CPU model aliases > # > Thanks, applied to my python-next tree: https://gitlab.com/philmd/qemu/commits/python-next
Philippe Mathieu-Daudé <philmd@redhat.com> writes: > Patch created mechanically by running: > > $ chmod 644 $(git grep -lF '#!/usr/bin/env python' \ > | xargs grep -L 'if __name__.*__main__') > $ sed -i "/^#\!\/usr\/bin\/\(env\ \)\?python.\?$/d" \ > $(git grep -lF '#!/usr/bin/env python' \ > | xargs grep -L 'if __name__.*__main__') OK, but my question is why? Aren't shebangs considered good practice for finding the executable for a script? If the acceptance scripts are special in this regard we should say why in the commit message. > > Reported-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> > Suggested-by: Stefan Hajnoczi <stefanha@redhat.com> > Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com> > Acked-by: Stefan Hajnoczi <stefanha@redhat.com> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > tests/acceptance/virtio_seg_max_adjust.py | 1 - > tests/acceptance/x86_cpu_model_versions.py | 1 - > 2 files changed, 2 deletions(-) > mode change 100755 => 100644 tests/acceptance/virtio_seg_max_adjust.py > > diff --git a/tests/acceptance/virtio_seg_max_adjust.py b/tests/acceptance/virtio_seg_max_adjust.py > old mode 100755 > new mode 100644 > index 5458573138..8d4f24da49 > --- a/tests/acceptance/virtio_seg_max_adjust.py > +++ b/tests/acceptance/virtio_seg_max_adjust.py > @@ -1,4 +1,3 @@ > -#!/usr/bin/env python > # > # Test virtio-scsi and virtio-blk queue settings for all machine types > # > diff --git a/tests/acceptance/x86_cpu_model_versions.py b/tests/acceptance/x86_cpu_model_versions.py > index 90558d9a71..01ff614ec2 100644 > --- a/tests/acceptance/x86_cpu_model_versions.py > +++ b/tests/acceptance/x86_cpu_model_versions.py > @@ -1,4 +1,3 @@ > -#!/usr/bin/env python > # > # Basic validation of x86 versioned CPU models and CPU model aliases > #
diff --git a/tests/acceptance/virtio_seg_max_adjust.py b/tests/acceptance/virtio_seg_max_adjust.py old mode 100755 new mode 100644 index 5458573138..8d4f24da49 --- a/tests/acceptance/virtio_seg_max_adjust.py +++ b/tests/acceptance/virtio_seg_max_adjust.py @@ -1,4 +1,3 @@ -#!/usr/bin/env python # # Test virtio-scsi and virtio-blk queue settings for all machine types # diff --git a/tests/acceptance/x86_cpu_model_versions.py b/tests/acceptance/x86_cpu_model_versions.py index 90558d9a71..01ff614ec2 100644 --- a/tests/acceptance/x86_cpu_model_versions.py +++ b/tests/acceptance/x86_cpu_model_versions.py @@ -1,4 +1,3 @@ -#!/usr/bin/env python # # Basic validation of x86 versioned CPU models and CPU model aliases #
Patch created mechanically by running: $ chmod 644 $(git grep -lF '#!/usr/bin/env python' \ | xargs grep -L 'if __name__.*__main__') $ sed -i "/^#\!\/usr\/bin\/\(env\ \)\?python.\?$/d" \ $(git grep -lF '#!/usr/bin/env python' \ | xargs grep -L 'if __name__.*__main__') Reported-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> Suggested-by: Stefan Hajnoczi <stefanha@redhat.com> Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com> Acked-by: Stefan Hajnoczi <stefanha@redhat.com> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- tests/acceptance/virtio_seg_max_adjust.py | 1 - tests/acceptance/x86_cpu_model_versions.py | 1 - 2 files changed, 2 deletions(-) mode change 100755 => 100644 tests/acceptance/virtio_seg_max_adjust.py