Message ID | 20200323225254.12759-1-grygorii.strashko@ti.com (mailing list archive) |
---|---|
Headers | show |
Series | net: ethernet: ti: add networking support for k3 am65x/j721e soc | expand |
From: Grygorii Strashko <grygorii.strashko@ti.com> Date: Tue, 24 Mar 2020 00:52:43 +0200 > This v6 series adds basic networking support support TI K3 AM654x/J721E SoC which > have integrated Gigabit Ethernet MAC (Media Access Controller) into device MCU > domain and named MCU_CPSW0 (CPSW2G NUSS). ... Series applied, thank you.
Hi David, On Fri, 27 Mar 2020 at 05:02, David Miller <davem@davemloft.net> wrote: > > From: Grygorii Strashko <grygorii.strashko@ti.com> > Date: Tue, 24 Mar 2020 00:52:43 +0200 > > > This v6 series adds basic networking support support TI K3 AM654x/J721E SoC which > > have integrated Gigabit Ethernet MAC (Media Access Controller) into device MCU > > domain and named MCU_CPSW0 (CPSW2G NUSS). > ... > > Series applied, thank you. The build is now broken on net-next: arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi:303.23-309.6: ERROR (phandle_references): /interconnect@100000/interconnect@28380000/ethernet@46000000/ethernet-ports/port@1: Reference to non-existent node or label "mcu_conf" also defined at arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts:471.13-474.3 arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi:303.23-309.6: ERROR (phandle_references): /interconnect@100000/interconnect@28380000/ethernet@46000000/ethernet-ports/port@1: Reference to non-existent node or label "phy_gmii_sel" also defined at arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts:471.13-474.3 As Grygorii said: Patches 1-6 are intended for netdev, Patches 7-11 are intended for K3 Platform tree and provided here for testing purposes. Regards, -Vladimir
On 28/03/2020 03:53, Vladimir Oltean wrote: > Hi David, > > On Fri, 27 Mar 2020 at 05:02, David Miller <davem@davemloft.net> wrote: >> >> From: Grygorii Strashko <grygorii.strashko@ti.com> >> Date: Tue, 24 Mar 2020 00:52:43 +0200 >> >>> This v6 series adds basic networking support support TI K3 AM654x/J721E SoC which >>> have integrated Gigabit Ethernet MAC (Media Access Controller) into device MCU >>> domain and named MCU_CPSW0 (CPSW2G NUSS). >> ... >> >> Series applied, thank you. > > The build is now broken on net-next: > > arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi:303.23-309.6: ERROR > (phandle_references): > /interconnect@100000/interconnect@28380000/ethernet@46000000/ethernet-ports/port@1: > Reference to non-existent node > or label "mcu_conf" > > also defined at > arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts:471.13-474.3 > arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi:303.23-309.6: ERROR > (phandle_references): > /interconnect@100000/interconnect@28380000/ethernet@46000000/ethernet-ports/port@1: > Reference to non-existent node > or label "phy_gmii_sel" > > also defined at > arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts:471.13-474.3 > > As Grygorii said: > > Patches 1-6 are intended for netdev, Patches 7-11 are intended for K3 Platform > tree and provided here for testing purposes. Yeah, I think you are missing a dependency that was applied via the K3 branch earlier. They are in linux-next now, but I am not so sure how much that is going to help you. You could just drop the DT patches from this merge and let me apply them via the platform branch. -Tero -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
On 30/03/20 12:45 PM, Tero Kristo wrote: > On 28/03/2020 03:53, Vladimir Oltean wrote: >> Hi David, >> >> On Fri, 27 Mar 2020 at 05:02, David Miller <davem@davemloft.net> wrote: >>> >>> From: Grygorii Strashko <grygorii.strashko@ti.com> >>> Date: Tue, 24 Mar 2020 00:52:43 +0200 >>> >>>> This v6 series adds basic networking support support TI K3 >>>> AM654x/J721E SoC which >>>> have integrated Gigabit Ethernet MAC (Media Access Controller) into >>>> device MCU >>>> domain and named MCU_CPSW0 (CPSW2G NUSS). >>> ... >>> >>> Series applied, thank you. >> >> The build is now broken on net-next: >> >> arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi:303.23-309.6: ERROR >> (phandle_references): >> /interconnect@100000/interconnect@28380000/ethernet@46000000/ethernet-ports/port@1: >> >> Reference to non-existent node >> or label "mcu_conf" >> >> also defined at >> arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts:471.13-474.3 >> arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi:303.23-309.6: ERROR >> (phandle_references): >> /interconnect@100000/interconnect@28380000/ethernet@46000000/ethernet-ports/port@1: >> >> Reference to non-existent node >> or label "phy_gmii_sel" >> >> also defined at >> arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts:471.13-474.3 >> >> As Grygorii said: >> >> Patches 1-6 are intended for netdev, Patches 7-11 are intended for K3 >> Platform >> tree and provided here for testing purposes. > > Yeah, I think you are missing a dependency that was applied via the K3 > branch earlier. They are in linux-next now, but I am not so sure how > much that is going to help you. > > You could just drop the DT patches from this merge and let me apply them > via the platform branch. One other option would be that Dave merges your K3 tag which was sent to ARM SoC to net-next. Its based on v5.6-rc1, has no other dependencies, is already in linux-next, should be immutable and safe to merge. This has the advantage that no rebase is necessary on net-next. git://git.kernel.org/pub/scm/linux/kernel/git/kristo/linux tags/ti-k3-soc-for-v5.7 + ARM SoC maintainers for their information and any advise. Thanks, Sekhar
On 30/03/20 1:06 PM, Sekhar Nori wrote: > On 30/03/20 12:45 PM, Tero Kristo wrote: >> On 28/03/2020 03:53, Vladimir Oltean wrote: >>> Hi David, >>> >>> On Fri, 27 Mar 2020 at 05:02, David Miller <davem@davemloft.net> wrote: >>>> >>>> From: Grygorii Strashko <grygorii.strashko@ti.com> >>>> Date: Tue, 24 Mar 2020 00:52:43 +0200 >>>> >>>>> This v6 series adds basic networking support support TI K3 >>>>> AM654x/J721E SoC which >>>>> have integrated Gigabit Ethernet MAC (Media Access Controller) into >>>>> device MCU >>>>> domain and named MCU_CPSW0 (CPSW2G NUSS). >>>> ... >>>> >>>> Series applied, thank you. >>> >>> The build is now broken on net-next: >>> >>> arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi:303.23-309.6: ERROR >>> (phandle_references): >>> /interconnect@100000/interconnect@28380000/ethernet@46000000/ethernet-ports/port@1: >>> >>> Reference to non-existent node >>> or label "mcu_conf" >>> >>> also defined at >>> arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts:471.13-474.3 >>> arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi:303.23-309.6: ERROR >>> (phandle_references): >>> /interconnect@100000/interconnect@28380000/ethernet@46000000/ethernet-ports/port@1: >>> >>> Reference to non-existent node >>> or label "phy_gmii_sel" >>> >>> also defined at >>> arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts:471.13-474.3 >>> >>> As Grygorii said: >>> >>> Patches 1-6 are intended for netdev, Patches 7-11 are intended for K3 >>> Platform >>> tree and provided here for testing purposes. >> >> Yeah, I think you are missing a dependency that was applied via the K3 >> branch earlier. They are in linux-next now, but I am not so sure how >> much that is going to help you. >> >> You could just drop the DT patches from this merge and let me apply them >> via the platform branch. > > One other option would be that Dave merges your K3 tag which was sent to > ARM SoC to net-next. Its based on v5.6-rc1, has no other dependencies, > is already in linux-next, should be immutable and safe to merge. This > has the advantage that no rebase is necessary on net-next. > > git://git.kernel.org/pub/scm/linux/kernel/git/kristo/linux > tags/ti-k3-soc-for-v5.7 FWIW, I was able to reproduce the build failure reported by Vladimir on net-next, merge Tero's tag (above) cleanly into it, and see that ARM64 defconfig build on net-next succeeds after the merge. Thanks, Sekhar
Hi On 30/03/2020 11:28, Sekhar Nori wrote: > On 30/03/20 1:06 PM, Sekhar Nori wrote: >> On 30/03/20 12:45 PM, Tero Kristo wrote: >>> On 28/03/2020 03:53, Vladimir Oltean wrote: >>>> Hi David, >>>> >>>> On Fri, 27 Mar 2020 at 05:02, David Miller <davem@davemloft.net> wrote: >>>>> >>>>> From: Grygorii Strashko <grygorii.strashko@ti.com> >>>>> Date: Tue, 24 Mar 2020 00:52:43 +0200 >>>>> >>>>>> This v6 series adds basic networking support support TI K3 >>>>>> AM654x/J721E SoC which >>>>>> have integrated Gigabit Ethernet MAC (Media Access Controller) into >>>>>> device MCU >>>>>> domain and named MCU_CPSW0 (CPSW2G NUSS). >>>>> ... >>>>> >>>>> Series applied, thank you. >>>> >>>> The build is now broken on net-next: >>>> >>>> arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi:303.23-309.6: ERROR >>>> (phandle_references): >>>> /interconnect@100000/interconnect@28380000/ethernet@46000000/ethernet-ports/port@1: >>>> >>>> Reference to non-existent node >>>> or label "mcu_conf" >>>> >>>> also defined at >>>> arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts:471.13-474.3 >>>> arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi:303.23-309.6: ERROR >>>> (phandle_references): >>>> /interconnect@100000/interconnect@28380000/ethernet@46000000/ethernet-ports/port@1: >>>> >>>> Reference to non-existent node >>>> or label "phy_gmii_sel" >>>> >>>> also defined at >>>> arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts:471.13-474.3 >>>> >>>> As Grygorii said: >>>> >>>> Patches 1-6 are intended for netdev, Patches 7-11 are intended for K3 >>>> Platform >>>> tree and provided here for testing purposes. >>> >>> Yeah, I think you are missing a dependency that was applied via the K3 >>> branch earlier. They are in linux-next now, but I am not so sure how >>> much that is going to help you. >>> >>> You could just drop the DT patches from this merge and let me apply them >>> via the platform branch. >> >> One other option would be that Dave merges your K3 tag which was sent to >> ARM SoC to net-next. Its based on v5.6-rc1, has no other dependencies, >> is already in linux-next, should be immutable and safe to merge. This >> has the advantage that no rebase is necessary on net-next. >> >> git://git.kernel.org/pub/scm/linux/kernel/git/kristo/linux >> tags/ti-k3-soc-for-v5.7 > > FWIW, I was able to reproduce the build failure reported by Vladimir on > net-next, merge Tero's tag (above) cleanly into it, and see that ARM64 > defconfig build on net-next succeeds after the merge. Thank you Sekhar for checking this. I'm very sorry for introducing this issue. I've tried hard to avoid such issue, but still missed it (probably I have had to drop DT patches from last submission and send them separately). Sorry again.
Hi David, On Mon, 30 Mar 2020 at 21:14, Grygorii Strashko <grygorii.strashko@ti.com> wrote: > > Hi > > On 30/03/2020 11:28, Sekhar Nori wrote: > > On 30/03/20 1:06 PM, Sekhar Nori wrote: > >> On 30/03/20 12:45 PM, Tero Kristo wrote: > >>> On 28/03/2020 03:53, Vladimir Oltean wrote: > >>>> Hi David, > >>>> > >>>> On Fri, 27 Mar 2020 at 05:02, David Miller <davem@davemloft.net> wrote: > >>>>> > >>>>> From: Grygorii Strashko <grygorii.strashko@ti.com> > >>>>> Date: Tue, 24 Mar 2020 00:52:43 +0200 > >>>>> > >>>>>> This v6 series adds basic networking support support TI K3 > >>>>>> AM654x/J721E SoC which > >>>>>> have integrated Gigabit Ethernet MAC (Media Access Controller) into > >>>>>> device MCU > >>>>>> domain and named MCU_CPSW0 (CPSW2G NUSS). > >>>>> ... > >>>>> > >>>>> Series applied, thank you. > >>>> > >>>> The build is now broken on net-next: > >>>> > >>>> arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi:303.23-309.6: ERROR > >>>> (phandle_references): > >>>> /interconnect@100000/interconnect@28380000/ethernet@46000000/ethernet-ports/port@1: > >>>> > >>>> Reference to non-existent node > >>>> or label "mcu_conf" > >>>> > >>>> also defined at > >>>> arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts:471.13-474.3 > >>>> arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi:303.23-309.6: ERROR > >>>> (phandle_references): > >>>> /interconnect@100000/interconnect@28380000/ethernet@46000000/ethernet-ports/port@1: > >>>> > >>>> Reference to non-existent node > >>>> or label "phy_gmii_sel" > >>>> > >>>> also defined at > >>>> arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts:471.13-474.3 > >>>> > >>>> As Grygorii said: > >>>> > >>>> Patches 1-6 are intended for netdev, Patches 7-11 are intended for K3 > >>>> Platform > >>>> tree and provided here for testing purposes. > >>> > >>> Yeah, I think you are missing a dependency that was applied via the K3 > >>> branch earlier. They are in linux-next now, but I am not so sure how > >>> much that is going to help you. > >>> > >>> You could just drop the DT patches from this merge and let me apply them > >>> via the platform branch. > >> > >> One other option would be that Dave merges your K3 tag which was sent to > >> ARM SoC to net-next. Its based on v5.6-rc1, has no other dependencies, > >> is already in linux-next, should be immutable and safe to merge. This > >> has the advantage that no rebase is necessary on net-next. > >> > >> git://git.kernel.org/pub/scm/linux/kernel/git/kristo/linux > >> tags/ti-k3-soc-for-v5.7 > > > > FWIW, I was able to reproduce the build failure reported by Vladimir on > > net-next, merge Tero's tag (above) cleanly into it, and see that ARM64 > > defconfig build on net-next succeeds after the merge. > > Thank you Sekhar for checking this. > > I'm very sorry for introducing this issue. I've tried hard to avoid such issue, > but still missed it (probably I have had to drop DT patches from last submission > and send them separately). > > Sorry again. > > -- > Best regards, > grygorii I think the ARM64 build is now also broken on Linus' master branch, after the net-next merge? I am not quite sure if the device tree patches were supposed to land in mainline the way they did. Thanks, -Vladimir
From: Vladimir Oltean <olteanv@gmail.com> Date: Wed, 1 Apr 2020 21:27:04 +0300 > I think the ARM64 build is now also broken on Linus' master branch, > after the net-next merge? I am not quite sure if the device tree > patches were supposed to land in mainline the way they did. There's a fix in my net tree and it will go to Linus soon. There is no clear policy for dt change integration, and honestly I try to deal with the situation on a case by case basis.
>> I think the ARM64 build is now also broken on Linus' master branch, >> after the net-next merge? I am not quite sure if the device tree >> patches were supposed to land in mainline the way they did. > >There's a fix in my net tree and it will go to Linus soon. > >There is no clear policy for dt change integration, and honestly >I try to deal with the situation on a case by case basis. Yep, mainline aarch64-linux-gnu- builds are totally hosed. DTC fails the build very early on: https://travis-ci.com/github/ClangBuiltLinux/continuous-integration/jobs/311246218 https://travis-ci.com/github/ClangBuiltLinux/continuous-integration/jobs/311246270 There was no failure in -next, not sure how we skipped our canary in the coal mine.
On Wed, Apr 01, 2020 at 03:35:00PM -0700, Nick Desaulniers wrote: > >> I think the ARM64 build is now also broken on Linus' master branch, > >> after the net-next merge? I am not quite sure if the device tree > >> patches were supposed to land in mainline the way they did. > > > >There's a fix in my net tree and it will go to Linus soon. > > > >There is no clear policy for dt change integration, and honestly > >I try to deal with the situation on a case by case basis. > > Yep, mainline aarch64-linux-gnu- builds are totally hosed. DTC fails the build > very early on: > https://travis-ci.com/github/ClangBuiltLinux/continuous-integration/jobs/311246218 > https://travis-ci.com/github/ClangBuiltLinux/continuous-integration/jobs/311246270 > There was no failure in -next, not sure how we skipped our canary in the coal > mine. Yes, one of the things linux-next does a really good job at catching is build breakage so it would've been nice to have seen this there rather than end up with breakage in Linus' tree :( Was the timing just bad, or are we missing DT coverage or something else? Will
On 02/04/2020 12:42, Will Deacon wrote: > On Wed, Apr 01, 2020 at 03:35:00PM -0700, Nick Desaulniers wrote: >>>> I think the ARM64 build is now also broken on Linus' master branch, >>>> after the net-next merge? I am not quite sure if the device tree >>>> patches were supposed to land in mainline the way they did. >>> >>> There's a fix in my net tree and it will go to Linus soon. >>> >>> There is no clear policy for dt change integration, and honestly >>> I try to deal with the situation on a case by case basis. >> >> Yep, mainline aarch64-linux-gnu- builds are totally hosed. DTC fails the build >> very early on: >> https://travis-ci.com/github/ClangBuiltLinux/continuous-integration/jobs/311246218 >> https://travis-ci.com/github/ClangBuiltLinux/continuous-integration/jobs/311246270 >> There was no failure in -next, not sure how we skipped our canary in the coal >> mine. > > Yes, one of the things linux-next does a really good job at catching is > build breakage so it would've been nice to have seen this there rather > than end up with breakage in Linus' tree :( > > Was the timing just bad, or are we missing DT coverage or something else? It seems issue was not caught in -next because the patch that fixes the issue was already in -next before this series was pushed. Sorry for the mess again.
On Thu, Apr 2, 2020 at 4:05 AM Grygorii Strashko <grygorii.strashko@ti.com> wrote: > > > > On 02/04/2020 12:42, Will Deacon wrote: > > On Wed, Apr 01, 2020 at 03:35:00PM -0700, Nick Desaulniers wrote: > >>>> I think the ARM64 build is now also broken on Linus' master branch, > >>>> after the net-next merge? I am not quite sure if the device tree > >>>> patches were supposed to land in mainline the way they did. > >>> > >>> There's a fix in my net tree and it will go to Linus soon. > >>> > >>> There is no clear policy for dt change integration, and honestly > >>> I try to deal with the situation on a case by case basis. > >> > >> Yep, mainline aarch64-linux-gnu- builds are totally hosed. DTC fails the build > >> very early on: > >> https://travis-ci.com/github/ClangBuiltLinux/continuous-integration/jobs/311246218 > >> https://travis-ci.com/github/ClangBuiltLinux/continuous-integration/jobs/311246270 > >> There was no failure in -next, not sure how we skipped our canary in the coal > >> mine. > > > > Yes, one of the things linux-next does a really good job at catching is > > build breakage so it would've been nice to have seen this there rather > > than end up with breakage in Linus' tree :( > > > > Was the timing just bad, or are we missing DT coverage or something else? > > It seems issue was not caught in -next because the patch that fixes the issue was already in -next > before this series was pushed. > > Sorry for the mess again. No worries, it's just worthwhile to study failures. So IIUC, in this case: mainline was 5.6 the broken patch was merged in 5.7 merge window a fix was already in -next, but not slated for the new merge window. (Maybe scheduled for 5.8?) So it sounds like it can be dangerous to have 2 branches from 1 tree flow into -next, as the branch meant for a later release can mask failures in pull requests for the earlier release? Do we know what and where the fix currently is? Can we make sure it's sent to Linus for 5.7-rc1? (Or sooner?)
On 02/04/20 10:57 PM, Nick Desaulniers wrote: > On Thu, Apr 2, 2020 at 4:05 AM Grygorii Strashko > <grygorii.strashko@ti.com> wrote: >> >> >> >> On 02/04/2020 12:42, Will Deacon wrote: >>> On Wed, Apr 01, 2020 at 03:35:00PM -0700, Nick Desaulniers wrote: >>>>>> I think the ARM64 build is now also broken on Linus' master branch, >>>>>> after the net-next merge? I am not quite sure if the device tree >>>>>> patches were supposed to land in mainline the way they did. >>>>> >>>>> There's a fix in my net tree and it will go to Linus soon. >>>>> >>>>> There is no clear policy for dt change integration, and honestly >>>>> I try to deal with the situation on a case by case basis. >>>> >>>> Yep, mainline aarch64-linux-gnu- builds are totally hosed. DTC fails the build >>>> very early on: >>>> https://travis-ci.com/github/ClangBuiltLinux/continuous-integration/jobs/311246218 >>>> https://travis-ci.com/github/ClangBuiltLinux/continuous-integration/jobs/311246270 >>>> There was no failure in -next, not sure how we skipped our canary in the coal >>>> mine. >>> >>> Yes, one of the things linux-next does a really good job at catching is >>> build breakage so it would've been nice to have seen this there rather >>> than end up with breakage in Linus' tree :( >>> >>> Was the timing just bad, or are we missing DT coverage or something else? >> >> It seems issue was not caught in -next because the patch that fixes the issue was already in -next >> before this series was pushed. >> >> Sorry for the mess again. > > No worries, it's just worthwhile to study failures. So IIUC, in this case: > mainline was 5.6 > the broken patch was merged in 5.7 merge window > a fix was already in -next, but not slated for the new merge window. > (Maybe scheduled for 5.8?) No, the "fix" is scheduled to go into v5.7 kernel as well. It is here: git://git.kernel.org/pub/scm/linux/kernel/git/kristo/linux tags/ti-k3-soc-for-v5.7 This is already part of ARM SoC tree, and slated for v5.7 https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/log/?h=arm/dt Arnd, Olof, Can you please help by either queuing the arm/dt entirely or just the K3 SoC parts to Linus sooner than later? Thanks, Sekhar