| Message ID | 1313429190-29275-1-git-send-email-peterhuewe@gmx.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Peter, On Monday 15 August 2011 19:26:30 Peter Huewe wrote: > This patch fixes a typo which causes this build failure for the > avr32 defconfig: > > drivers/video/atmel_lcdfb.c:63: error: request for member 'xres_virtual' > in something not a structure or union > make[3]: *** [drivers/video/atmel_lcdfb.o] Error 1 > > The typo was introduced by 895607ec > "atmel_lcdfb: use display information in info not in var for panning" > > KernelVersion: Linux-next 20110812 > The typo was introduced through the fbdev tree. Thanks for the patch. I've already submitted the same patch (https://patchwork.kernel.org/patch/990792/) nearly a month ago to the linux- fbdev mailing list. Paul, can you please pick it up ? > Signed-off-by: Peter Huewe <peterhuewe@gmx.de> > --- > So much for compile testing... ;) > > drivers/video/atmel_lcdfb.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c > index 77153c6..63409c1 100644 > --- a/drivers/video/atmel_lcdfb.c > +++ b/drivers/video/atmel_lcdfb.c > @@ -60,7 +60,7 @@ static void atmel_lcdfb_update_dma2d(struct > atmel_lcdfb_info *sinfo, > > pixeloff = (var->xoffset * info->var.bits_per_pixel) & 0x1f; > > - dma2dcfg = (info-var.xres_virtual - info->var.xres) > + dma2dcfg = (info->var.xres_virtual - info->var.xres) > * info->var.bits_per_pixel / 8; > dma2dcfg |= pixeloff << ATMEL_LCDC_PIXELOFF_OFFSET; > lcdc_writel(sinfo, ATMEL_LCDC_DMA2DCFG, dma2dcfg);
Am Montag 15 August 2011, 19:31:27 schrieb Laurent Pinchart: > Thanks for the patch. I've already submitted the same patch > (https://patchwork.kernel.org/patch/990792/) nearly a month ago to the > linux- fbdev mailing list. Paul, can you please pick it up ? Ah okay, didn't see it. I usually look on the lkml if the problem was already fixed lately but somehow missed your patch. Since you've done exactly what my patch did you get my Reviewed-by: Peter Huewe <peterhuewe@gmx.de> Thanks, Peter -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Aug 15, 2011 at 07:43:07PM +0200, Peter Hüwe wrote: > Am Montag 15 August 2011, 19:31:27 schrieb Laurent Pinchart: > > Thanks for the patch. I've already submitted the same patch > > (https://patchwork.kernel.org/patch/990792/) nearly a month ago to the > > linux- fbdev mailing list. Paul, can you please pick it up ? > > Ah okay, didn't see it. I usually look on the lkml if the problem was already > fixed lately but somehow missed your patch. > > Since you've done exactly what my patch did you get my > Reviewed-by: Peter Huewe <peterhuewe@gmx.de> This bug was spotted during the review phase, too: https://patchwork.kernel.org/patch/878382/ Dunno if the wrong patch was picked up or the follow up patch never came around. Doesn't matter: Acked-by: Wolfram Sang <w.sang@pengutronix.de> Regards, Wolfram
On Monday 15 August 2011 23:26:59 Wolfram Sang wrote: > On Mon, Aug 15, 2011 at 07:43:07PM +0200, Peter Hüwe wrote: > > Am Montag 15 August 2011, 19:31:27 schrieb Laurent Pinchart: > > > Thanks for the patch. I've already submitted the same patch > > > (https://patchwork.kernel.org/patch/990792/) nearly a month ago to the > > > linux- fbdev mailing list. Paul, can you please pick it up ? > > > > Ah okay, didn't see it. I usually look on the lkml if the problem was > > already fixed lately but somehow missed your patch. > > > > Since you've done exactly what my patch did you get my > > Reviewed-by: Peter Huewe <peterhuewe@gmx.de> > > This bug was spotted during the review phase, too: > > https://patchwork.kernel.org/patch/878382/ > > Dunno if the wrong patch was picked up or the follow up patch never came > around. Doesn't matter: I've sent a v3 but v2 was picked up. I've then sent a fix on top of v2, but it hasn't made it through (yet). > Acked-by: Wolfram Sang <w.sang@pengutronix.de>
diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c index 77153c6..63409c1 100644 --- a/drivers/video/atmel_lcdfb.c +++ b/drivers/video/atmel_lcdfb.c @@ -60,7 +60,7 @@ static void atmel_lcdfb_update_dma2d(struct atmel_lcdfb_info *sinfo, pixeloff = (var->xoffset * info->var.bits_per_pixel) & 0x1f; - dma2dcfg = (info-var.xres_virtual - info->var.xres) + dma2dcfg = (info->var.xres_virtual - info->var.xres) * info->var.bits_per_pixel / 8; dma2dcfg |= pixeloff << ATMEL_LCDC_PIXELOFF_OFFSET; lcdc_writel(sinfo, ATMEL_LCDC_DMA2DCFG, dma2dcfg);
This patch fixes a typo which causes this build failure for the avr32 defconfig: drivers/video/atmel_lcdfb.c:63: error: request for member 'xres_virtual' in something not a structure or union make[3]: *** [drivers/video/atmel_lcdfb.o] Error 1 The typo was introduced by 895607ec "atmel_lcdfb: use display information in info not in var for panning" KernelVersion: Linux-next 20110812 The typo was introduced through the fbdev tree. Signed-off-by: Peter Huewe <peterhuewe@gmx.de> --- So much for compile testing... ;) drivers/video/atmel_lcdfb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)