| Message ID | 20200323095551.23500-1-mike.looijmans@topic.nl (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] dt-bindings: iio: accel: Add bmi088 accelerometer bindings | expand |
On Mon, 23 Mar 2020 10:55:51 +0100 Mike Looijmans <mike.looijmans@topic.nl> wrote: > This adds the device-tree bindings for the Bosch Sensortec BMI088 IMU, > the accelerometer part. > > Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> Hi Mike The binding should look to be as complete as possible, independent on what we are actually using in the driver. A quick glance at the datasheet shows me this device has 2 interrupt lines dedicated to the accelerometer and 2 power supplies, vddio and vdd. Interrupt lines for flexible parts like this are fiddly to do, so take a look at how we do this in other drivers. Hmm. the interrupt line to set a tag is 'interesting'. I'd ignore that for now... > --- > v2: convert to yaml format > > .../bindings/iio/accel/bosch,bmi088.yaml | 38 +++++++++++++++++++ > 1 file changed, 38 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml > > diff --git a/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml b/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml > new file mode 100644 > index 000000000000..715f79c3b2a9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml > @@ -0,0 +1,38 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/accel/bosch,bma400.yaml# Should reflect the compatible so include the accel part. > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Bosch BMI088 IMU accelerometer part > + > +maintainers: > + - Mike Looijmans <mike.looijmans@topic.nl> > + > +description: | > + Acceleration part of the IMU sensor with an SPI interface > + > + Specifications about the sensor can be found at: > + https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmi088-ds001.pdf > + > +properties: > + compatible: > + enum: > + - bosch,bmi088_accel > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +examples: > + - | > + spi { > + bmi088_accel@1 { > + compatible = "bosch,bmi088_accel"; > + reg = <1>; > + spi-max-frequency = <10000000>; > + }; > + };
Interleaved comments below. I'll send a v6 bundle with the updated bindings. On 28-03-2020 16:19, Jonathan Cameron wrote: > On Mon, 23 Mar 2020 10:55:51 +0100 > Mike Looijmans <mike.looijmans@topic.nl> wrote: > >> This adds the device-tree bindings for the Bosch Sensortec BMI088 IMU, >> the accelerometer part. >> >> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> > Hi Mike > > The binding should look to be as complete as possible, independent on what > we are actually using in the driver. > > A quick glance at the datasheet shows me this device has 2 interrupt lines > dedicated to the accelerometer and 2 power supplies, vddio and vdd. > > Interrupt lines for flexible parts like this are fiddly to do, so take > a look at how we do this in other drivers. Hmm. the interrupt line to set > a tag is 'interesting'. I'd ignore that for now... Guess for the interrupts we can just suffice to say that MaxItems=2 and it's up to the driver to make sense of things. Power supplies are clear. > >> --- >> v2: convert to yaml format >> >> .../bindings/iio/accel/bosch,bmi088.yaml | 38 +++++++++++++++++++ >> 1 file changed, 38 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml >> >> diff --git a/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml b/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml >> new file mode 100644 >> index 000000000000..715f79c3b2a9 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml >> @@ -0,0 +1,38 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/iio/accel/bosch,bma400.yaml# > > Should reflect the compatible so include the accel part. Oops, copy/paste error... > >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Bosch BMI088 IMU accelerometer part >> + >> +maintainers: >> + - Mike Looijmans <mike.looijmans@topic.nl> >> + >> +description: | >> + Acceleration part of the IMU sensor with an SPI interface >> + >> + Specifications about the sensor can be found at: >> + https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmi088-ds001.pdf >> + >> +properties: >> + compatible: >> + enum: >> + - bosch,bmi088_accel >> + >> + reg: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + >> +examples: >> + - | >> + spi { >> + bmi088_accel@1 { >> + compatible = "bosch,bmi088_accel"; >> + reg = <1>; >> + spi-max-frequency = <10000000>; >> + }; >> + }; >
diff --git a/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml b/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml new file mode 100644 index 000000000000..715f79c3b2a9 --- /dev/null +++ b/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml @@ -0,0 +1,38 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/accel/bosch,bma400.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Bosch BMI088 IMU accelerometer part + +maintainers: + - Mike Looijmans <mike.looijmans@topic.nl> + +description: | + Acceleration part of the IMU sensor with an SPI interface + + Specifications about the sensor can be found at: + https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmi088-ds001.pdf + +properties: + compatible: + enum: + - bosch,bmi088_accel + + reg: + maxItems: 1 + +required: + - compatible + - reg + +examples: + - | + spi { + bmi088_accel@1 { + compatible = "bosch,bmi088_accel"; + reg = <1>; + spi-max-frequency = <10000000>; + }; + };
This adds the device-tree bindings for the Bosch Sensortec BMI088 IMU, the accelerometer part. Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> --- v2: convert to yaml format .../bindings/iio/accel/bosch,bmi088.yaml | 38 +++++++++++++++++++ 1 file changed, 38 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml