| Message ID | 20200327073636.13823-1-harigovi@codeaurora.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add support for rm69299 Visionox panel driver and add devicetree bindings for visionox panel | expand |
Hi Harigovindan On Fri, Mar 27, 2020 at 01:06:34PM +0530, Harigovindan P wrote: > Adding support for visionox rm69299 panel driver and adding bindings for the same panel. > > Harigovindan P (2): > dt-bindings: display: add visionox rm69299 panel variant > drm/panel: add support for rm69299 visionox panel driver I have only the first patch, which is now applied. Please resend second patch as it is lost somewhere. Sam > > .../display/panel/visionox,rm69299.yaml | 58 ++++ > drivers/gpu/drm/panel/Kconfig | 8 + > drivers/gpu/drm/panel/Makefile | 1 + > .../gpu/drm/panel/panel-visionox-rm69299.c | 295 ++++++++++++++++++ > 4 files changed, 362 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/visionox,rm69299.yaml > create mode 100644 drivers/gpu/drm/panel/panel-visionox-rm69299.c > > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Sam, On Sat, Mar 28, 2020 at 09:40:47PM +0100, Sam Ravnborg wrote: > Hi Harigovindan > > On Fri, Mar 27, 2020 at 01:06:34PM +0530, Harigovindan P wrote: > > Adding support for visionox rm69299 panel driver and adding bindings for the same panel. > > > > Harigovindan P (2): > > dt-bindings: display: add visionox rm69299 panel variant > > drm/panel: add support for rm69299 visionox panel driver > > I have only the first patch, which is now applied. > Please resend second patch as it is lost somewhere. Yes, it seems for v8, v9 and v10 only the bindings were sent, even though the cover letter and subject say it's a series of two patches. To my knowledge the latest version of the driver patch is this: https://patchwork.kernel.org/patch/11439689/
Hi Matthias. On Sun, Mar 29, 2020 at 10:44:17AM -0700, Matthias Kaehlcke wrote: > Hi Sam, > > On Sat, Mar 28, 2020 at 09:40:47PM +0100, Sam Ravnborg wrote: > > Hi Harigovindan > > > > On Fri, Mar 27, 2020 at 01:06:34PM +0530, Harigovindan P wrote: > > > Adding support for visionox rm69299 panel driver and adding bindings for the same panel. > > > > > > Harigovindan P (2): > > > dt-bindings: display: add visionox rm69299 panel variant > > > drm/panel: add support for rm69299 visionox panel driver > > > > I have only the first patch, which is now applied. > > Please resend second patch as it is lost somewhere. > > Yes, it seems for v8, v9 and v10 only the bindings were sent, even > though the cover letter and subject say it's a series of two patches. > > To my knowledge the latest version of the driver patch is this: > > https://patchwork.kernel.org/patch/11439689/ I did not go back and check, but I recall there was review feedback that is not yet addressed. I applied the patch here and checkpatch was not happy: total: 14 errors, 22 warnings, 11 checks, 314 lines checked Many of these are trivial indent or spaces used where tabs should be used. These needs to be fixed before the driver will be applied. And there was too much that I just did it while applying. Sam
On Mon, Mar 30, 2020 at 09:25:11PM +0200, Sam Ravnborg wrote: > Hi Matthias. > > On Sun, Mar 29, 2020 at 10:44:17AM -0700, Matthias Kaehlcke wrote: > > Hi Sam, > > > > On Sat, Mar 28, 2020 at 09:40:47PM +0100, Sam Ravnborg wrote: > > > Hi Harigovindan > > > > > > On Fri, Mar 27, 2020 at 01:06:34PM +0530, Harigovindan P wrote: > > > > Adding support for visionox rm69299 panel driver and adding bindings for the same panel. > > > > > > > > Harigovindan P (2): > > > > dt-bindings: display: add visionox rm69299 panel variant > > > > drm/panel: add support for rm69299 visionox panel driver > > > > > > I have only the first patch, which is now applied. > > > Please resend second patch as it is lost somewhere. > > > > Yes, it seems for v8, v9 and v10 only the bindings were sent, even > > though the cover letter and subject say it's a series of two patches. > > > > To my knowledge the latest version of the driver patch is this: > > > > https://patchwork.kernel.org/patch/11439689/ > > I did not go back and check, but I recall there was > review feedback that is not yet addressed. > > I applied the patch here and checkpatch was not happy: > total: 14 errors, 22 warnings, 11 checks, 314 lines checked > > Many of these are trivial indent or spaces used where tabs should be > used. > These needs to be fixed before the driver will be applied. > > And there was too much that I just did it while applying. Oh, I totally missed these, sure this needs to be addressed. Harigovindan, please also double check if there is any outstanding feedback that still needs to be addressed. Thanks Matthias