Message ID | 20200330113542.181752-5-adrian.ratiu@collabora.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | Genericize DW MIPI DSI bridge and add i.MX 6 driver | expand |
Hi Adrian, On Mon, Mar 30, 2020 at 8:34 AM Adrian Ratiu <adrian.ratiu@collabora.com> wrote: > > This adds support for the Synopsis DesignWare MIPI DSI v1.01 host > controller which is embedded in i.MX 6 SoCs. > > Based on following patches, but updated/extended to work with existing > support found in the kernel: > > - drm: imx: Support Synopsys DesignWare MIPI DSI host controller > Signed-off-by: Liu Ying <Ying.Liu@freescale.com> > > - ARM: dtsi: imx6qdl: Add support for MIPI DSI host controller > Signed-off-by: Liu Ying <Ying.Liu@freescale.com> This one looks like a devicetree patch, but this patch does not touch devicetree. > + ret = clk_prepare_enable(dsi->pllref_clk); > + if (ret) { > + dev_err(dev, "%s: Failed to enable pllref_clk\n", __func__); > + return ret; > + } > + > + dsi->mux_sel = syscon_regmap_lookup_by_phandle(dev->of_node, "fsl,gpr"); > + if (IS_ERR(dsi->mux_sel)) { > + ret = PTR_ERR(dsi->mux_sel); > + dev_err(dev, "%s: Failed to get GPR regmap: %d\n", > + __func__, ret); > + return ret; You should disable the dsi->pllref_clk clock prior to returning the error. > + dsi->mipi_dsi = dw_mipi_dsi_probe(pdev, pdata); > + if (IS_ERR(dsi->mipi_dsi)) { > + ret = PTR_ERR(dsi->mipi_dsi); > + dev_dbg(dev, "%s: Unable to probe DW DSI host device: %d\n", > + __func__, ret); > + return -ENODEV; Same here. You should disable the clock. Shouldn't you return 'ret' here instead of -ENODEV? > +module_platform_driver(imx_mipi_dsi_driver); > + > +MODULE_DESCRIPTION("i.MX6 MIPI DSI host controller driver"); > +MODULE_AUTHOR("Liu Ying <Ying.Liu@freescale.com>"); The freescale.com domain is no longer functional. Ying Liu's NXP address is victor.liu@nxp.com. You could probably add your entry as well.
Hello Fabio, Adrian: On Mon, 2020-03-30 at 08:49 -0300, Fabio Estevam wrote: > Hi Adrian, > > On Mon, Mar 30, 2020 at 8:34 AM Adrian Ratiu <adrian.ratiu@collabora.com> wrote: > > This adds support for the Synopsis DesignWare MIPI DSI v1.01 host > > controller which is embedded in i.MX 6 SoCs. > > > > Based on following patches, but updated/extended to work with existing > > support found in the kernel: > > > > - drm: imx: Support Synopsys DesignWare MIPI DSI host controller > > Signed-off-by: Liu Ying <Ying.Liu@freescale.com> > > > > - ARM: dtsi: imx6qdl: Add support for MIPI DSI host controller > > Signed-off-by: Liu Ying <Ying.Liu@freescale.com> > > This one looks like a devicetree patch, but this patch does not touch > devicetree. > > > + ret = clk_prepare_enable(dsi->pllref_clk); > > + if (ret) { > > + dev_err(dev, "%s: Failed to enable pllref_clk\n", __func__); > > + return ret; > > + } > > + > > + dsi->mux_sel = syscon_regmap_lookup_by_phandle(dev->of_node, "fsl,gpr"); > > + if (IS_ERR(dsi->mux_sel)) { > > + ret = PTR_ERR(dsi->mux_sel); > > + dev_err(dev, "%s: Failed to get GPR regmap: %d\n", > > + __func__, ret); > > + return ret; > > You should disable the dsi->pllref_clk clock prior to returning the error. > Another approach could be moving the clock on and off to to component_ops.{bind,unbind} (as rockhip driver does). What exactly is the PLL clock needed for? Would it make sense to move it some of the PHY power on/off? (Maybe not, but it's worthing checking). Also, it seems the other IP blocks have this PLL clock, so maybe it could be moved to the dw_mipi_dsi core? This could be something for a follow-up, to avoid creeping this series. Thanks, Ezequiel
On Mon, 30 Mar 2020, Fabio Estevam <festevam@gmail.com> wrote: > Hi Adrian, > > On Mon, Mar 30, 2020 at 8:34 AM Adrian Ratiu > <adrian.ratiu@collabora.com> wrote: >> >> This adds support for the Synopsis DesignWare MIPI DSI v1.01 >> host controller which is embedded in i.MX 6 SoCs. >> >> Based on following patches, but updated/extended to work with >> existing support found in the kernel: >> >> - drm: imx: Support Synopsys DesignWare MIPI DSI host >> controller >> Signed-off-by: Liu Ying <Ying.Liu@freescale.com> >> >> - ARM: dtsi: imx6qdl: Add support for MIPI DSI host controller >> Signed-off-by: Liu Ying <Ying.Liu@freescale.com> > > This one looks like a devicetree patch, but this patch does not > touch devicetree. > >> + ret = clk_prepare_enable(dsi->pllref_clk); + if >> (ret) { + dev_err(dev, "%s: Failed to enable >> pllref_clk\n", __func__); + return ret; + } >> + + dsi->mux_sel = >> syscon_regmap_lookup_by_phandle(dev->of_node, "fsl,gpr"); + >> if (IS_ERR(dsi->mux_sel)) { + ret = >> PTR_ERR(dsi->mux_sel); + dev_err(dev, "%s: Failed >> to get GPR regmap: %d\n", + __func__, >> ret); + return ret; > > You should disable the dsi->pllref_clk clock prior to returning > the error. > >> + dsi->mipi_dsi = dw_mipi_dsi_probe(pdev, pdata); + >> if (IS_ERR(dsi->mipi_dsi)) { + ret = >> PTR_ERR(dsi->mipi_dsi); + dev_dbg(dev, "%s: >> Unable to probe DW DSI host device: %d\n", + >> __func__, ret); + return -ENODEV; > > Same here. You should disable the clock. Shouldn't you return > 'ret' here instead of -ENODEV? > >> +module_platform_driver(imx_mipi_dsi_driver); + >> +MODULE_DESCRIPTION("i.MX6 MIPI DSI host controller driver"); >> +MODULE_AUTHOR("Liu Ying <Ying.Liu@freescale.com>"); > > The freescale.com domain is no longer functional. > > Ying Liu's NXP address is victor.liu@nxp.com. You could probably > add your entry as well. Hi Fabio, All the issues you pointed out are valid and will be addressed in v6 (including the device tree ones). Thank you, much appreciated, Adrian
On Mon, 30 Mar 2020, Ezequiel Garcia <ezequiel@collabora.com> wrote: > Hello Fabio, Adrian: > > On Mon, 2020-03-30 at 08:49 -0300, Fabio Estevam wrote: >> Hi Adrian, On Mon, Mar 30, 2020 at 8:34 AM Adrian Ratiu >> <adrian.ratiu@collabora.com> wrote: >> > This adds support for the Synopsis DesignWare MIPI DSI v1.01 >> > host controller which is embedded in i.MX 6 SoCs. Based on >> > following patches, but updated/extended to work with existing >> > support found in the kernel: - drm: imx: Support Synopsys >> > DesignWare MIPI DSI host controller >> > Signed-off-by: Liu Ying <Ying.Liu@freescale.com> >> > - ARM: dtsi: imx6qdl: Add support for MIPI DSI host >> > controller >> > Signed-off-by: Liu Ying <Ying.Liu@freescale.com> >> This one looks like a devicetree patch, but this patch does >> not touch devicetree. >> > + ret = clk_prepare_enable(dsi->pllref_clk); + if >> > (ret) { + dev_err(dev, "%s: Failed to enable >> > pllref_clk\n", __func__); + return ret; + >> > } + + dsi->mux_sel = >> > syscon_regmap_lookup_by_phandle(dev->of_node, "fsl,gpr"); + >> > if (IS_ERR(dsi->mux_sel)) { + ret = >> > PTR_ERR(dsi->mux_sel); + dev_err(dev, "%s: >> > Failed to get GPR regmap: %d\n", + >> > __func__, ret); + return ret; >> You should disable the dsi->pllref_clk clock prior to >> returning the error. > > Another approach could be moving the clock on and off to to > component_ops.{bind,unbind} (as rockhip driver does). > > What exactly is the PLL clock needed for? Would it make sense to > move it some of the PHY power on/off? (Maybe not, but it's > worthing checking). > > Also, it seems the other IP blocks have this PLL clock, so maybe > it could be moved to the dw_mipi_dsi core? This could be > something for a follow-up, to avoid creeping this series. Hi Ezequiel, pll is the video reference clock which drives the data lanes and yes all drivers have it as it's a basic requirement, so moving it to the common bridge is indeed a good idea, however this kind of driver refactoring is out of scope for this specific patch series, because, for now, I'd like to get the regmap and the imx6 driver in, once that is done we can think how to further abstract away common logic and slim down the existing drivers further. Basically I just want to avoid feature creep as I expect v6 to be ~ 8 patches big and the series is already over 1200 lines. Thank you, Adrian > > Thanks, > Ezequiel > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip
On Tue, 2020-03-31 at 00:31 +0300, Adrian Ratiu wrote: > On Mon, 30 Mar 2020, Ezequiel Garcia <ezequiel@collabora.com> > wrote: > > Hello Fabio, Adrian: > > > > On Mon, 2020-03-30 at 08:49 -0300, Fabio Estevam wrote: > > > Hi Adrian, On Mon, Mar 30, 2020 at 8:34 AM Adrian Ratiu > > > <adrian.ratiu@collabora.com> wrote: > > > > This adds support for the Synopsis DesignWare MIPI DSI v1.01 > > > > host controller which is embedded in i.MX 6 SoCs. Based on > > > > following patches, but updated/extended to work with existing > > > > support found in the kernel: - drm: imx: Support Synopsys > > > > DesignWare MIPI DSI host controller > > > > Signed-off-by: Liu Ying <Ying.Liu@freescale.com> > > > > - ARM: dtsi: imx6qdl: Add support for MIPI DSI host > > > > controller > > > > Signed-off-by: Liu Ying <Ying.Liu@freescale.com> > > > This one looks like a devicetree patch, but this patch does > > > not touch devicetree. > > > > + ret = clk_prepare_enable(dsi->pllref_clk); + if > > > > (ret) { + dev_err(dev, "%s: Failed to enable > > > > pllref_clk\n", __func__); + return ret; + > > > > } + + dsi->mux_sel = > > > > syscon_regmap_lookup_by_phandle(dev->of_node, "fsl,gpr"); + > > > > if (IS_ERR(dsi->mux_sel)) { + ret = > > > > PTR_ERR(dsi->mux_sel); + dev_err(dev, "%s: > > > > Failed to get GPR regmap: %d\n", + > > > > __func__, ret); + return ret; > > > You should disable the dsi->pllref_clk clock prior to > > > returning the error. > > > > Another approach could be moving the clock on and off to to > > component_ops.{bind,unbind} (as rockhip driver does). > > > > What exactly is the PLL clock needed for? Would it make sense to > > move it some of the PHY power on/off? (Maybe not, but it's > > worthing checking). > > > > Also, it seems the other IP blocks have this PLL clock, so maybe > > it could be moved to the dw_mipi_dsi core? This could be > > something for a follow-up, to avoid creeping this series. > > Hi Ezequiel, > > pll is the video reference clock which drives the data lanes and > yes all drivers have it as it's a basic requirement, so moving it > to the common bridge is indeed a good idea, however this kind of > driver refactoring is out of scope for this specific patch series, > because, for now, I'd like to get the regmap and the imx6 driver > in, once that is done we can think how to further abstract away > common logic and slim down the existing drivers further. > > Basically I just want to avoid feature creep as I expect v6 to be > ~ 8 patches big and the series is already over 1200 lines. > Oh, absolutely: if there's one thing I try to avoid is feature creep -- together with bikeshedding! Do note however, that you could move the PLL clock handling to component_ops.{bind,unbind} and maybe simplify the error handling. (BTW, great work!) Cheers, Ezequiel
On Tue, 31 Mar 2020, Ezequiel Garcia <ezequiel@collabora.com> wrote: > On Tue, 2020-03-31 at 00:31 +0300, Adrian Ratiu wrote: >> On Mon, 30 Mar 2020, Ezequiel Garcia <ezequiel@collabora.com> >> wrote: >> > Hello Fabio, Adrian: On Mon, 2020-03-30 at 08:49 -0300, >> > Fabio Estevam wrote: >> > > Hi Adrian, On Mon, Mar 30, 2020 at 8:34 AM Adrian Ratiu >> > > <adrian.ratiu@collabora.com> wrote: >> > > > This adds support for the Synopsis DesignWare MIPI DSI >> > > > v1.01 host controller which is embedded in i.MX 6 SoCs. >> > > > Based on following patches, but updated/extended to work >> > > > with existing support found in the kernel: - drm: imx: >> > > > Support Synopsys DesignWare MIPI DSI host controller >> > > > Signed-off-by: Liu Ying <Ying.Liu@freescale.com> >> > > > - ARM: dtsi: imx6qdl: Add support for MIPI DSI host >> > > > controller >> > > > Signed-off-by: Liu Ying <Ying.Liu@freescale.com> >> > > This one looks like a devicetree patch, but this patch >> > > does >> > > not touch devicetree. >> > > > + ret = clk_prepare_enable(dsi->pllref_clk); + >> > > > if (ret) { + dev_err(dev, "%s: Failed to >> > > > enable pllref_clk\n", __func__); + return >> > > > ret; + } + + dsi->mux_sel = >> > > > syscon_regmap_lookup_by_phandle(dev->of_node, "fsl,gpr"); >> > > > + if (IS_ERR(dsi->mux_sel)) { + ret = >> > > > PTR_ERR(dsi->mux_sel); + dev_err(dev, "%s: >> > > > Failed to get GPR regmap: %d\n", + __func__, ret); + >> > > > return ret; >> > > You should disable the dsi->pllref_clk clock prior to >> > > returning the error. >> > Another approach could be moving the clock on and off to to >> > component_ops.{bind,unbind} (as rockhip driver does). What >> > exactly is the PLL clock needed for? Would it make sense to >> > move it some of the PHY power on/off? (Maybe not, but it's >> > worthing checking). Also, it seems the other IP blocks >> > have this PLL clock, so maybe it could be moved to the >> > dw_mipi_dsi core? This could be something for a follow-up, >> > to avoid creeping this series. >> Hi Ezequiel, pll is the video reference clock which drives >> the data lanes and yes all drivers have it as it's a basic >> requirement, so moving it to the common bridge is indeed a >> good idea, however this kind of driver refactoring is out of >> scope for this specific patch series, because, for now, I'd >> like to get the regmap and the imx6 driver in, once that is >> done we can think how to further abstract away common logic >> and slim down the existing drivers further. Basically I just >> want to avoid feature creep as I expect v6 to be ~ 8 patches >> big and the series is already over 1200 lines. > > Oh, absolutely: if there's one thing I try to avoid is feature > creep -- together with bikeshedding! > > Do note however, that you could move the PLL clock handling to > component_ops.{bind,unbind} and maybe simplify the error > handling. > > (BTW, great work!) Thanks! I'll do the bind/unbind move for the new imx6 driver which I'm adding in this series to make it resemble the existing rockchip driver a bit more, then I'll stop short of further driver refactorings. > > Cheers, > Ezequiel
diff --git a/drivers/gpu/drm/imx/Kconfig b/drivers/gpu/drm/imx/Kconfig index 207bf7409dfb..b49e70e7f0fd 100644 --- a/drivers/gpu/drm/imx/Kconfig +++ b/drivers/gpu/drm/imx/Kconfig @@ -39,3 +39,10 @@ config DRM_IMX_HDMI depends on DRM_IMX help Choose this if you want to use HDMI on i.MX6. + +config DRM_IMX6_MIPI_DSI + tristate "Freescale i.MX6 DRM MIPI DSI" + select DRM_DW_MIPI_DSI + depends on DRM_IMX + help + Choose this if you want to use MIPI DSI on i.MX6. diff --git a/drivers/gpu/drm/imx/Makefile b/drivers/gpu/drm/imx/Makefile index 21cdcc2faabc..9a7843c59347 100644 --- a/drivers/gpu/drm/imx/Makefile +++ b/drivers/gpu/drm/imx/Makefile @@ -9,3 +9,4 @@ obj-$(CONFIG_DRM_IMX_TVE) += imx-tve.o obj-$(CONFIG_DRM_IMX_LDB) += imx-ldb.o obj-$(CONFIG_DRM_IMX_HDMI) += dw_hdmi-imx.o +obj-$(CONFIG_DRM_IMX6_MIPI_DSI) += dw_mipi_dsi-imx6.o diff --git a/drivers/gpu/drm/imx/dw_mipi_dsi-imx6.c b/drivers/gpu/drm/imx/dw_mipi_dsi-imx6.c new file mode 100644 index 000000000000..56b17d8670a2 --- /dev/null +++ b/drivers/gpu/drm/imx/dw_mipi_dsi-imx6.c @@ -0,0 +1,399 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * i.MX6 drm driver - MIPI DSI Host Controller + * + * Copyright (C) 2011-2015 Freescale Semiconductor, Inc. + */ + +#include <linux/clk.h> +#include <linux/component.h> +#include <linux/mfd/syscon.h> +#include <linux/mfd/syscon/imx6q-iomuxc-gpr.h> +#include <linux/module.h> +#include <linux/of_device.h> +#include <linux/regmap.h> +#include <linux/videodev2.h> +#include <drm/bridge/dw_mipi_dsi.h> +#include <drm/drm_crtc_helper.h> +#include <drm/drm_mipi_dsi.h> +#include <drm/drm_of.h> +#include <drm/drm_print.h> + +#include "imx-drm.h" + +#define DSI_PWR_UP 0x04 +#define RESET 0 +#define POWERUP BIT(0) + +#define DSI_PHY_IF_CTRL 0x5c +#define PHY_IF_CTRL_RESET 0x0 + +#define DSI_PHY_TST_CTRL0 0x64 +#define PHY_TESTCLK BIT(1) +#define PHY_UNTESTCLK 0 +#define PHY_TESTCLR BIT(0) +#define PHY_UNTESTCLR 0 + +#define DSI_PHY_TST_CTRL1 0x68 +#define PHY_TESTEN BIT(16) +#define PHY_UNTESTEN 0 +#define PHY_TESTDOUT(n) (((n) & 0xff) << 8) +#define PHY_TESTDIN(n) (((n) & 0xff) << 0) + +struct imx_mipi_dsi { + struct drm_encoder encoder; + struct device *dev; + struct regmap *mux_sel; + struct dw_mipi_dsi *mipi_dsi; + struct clk *pllref_clk; + + void __iomem *base; + unsigned int lane_mbps; +}; + +struct dphy_pll_testdin_map { + unsigned int max_mbps; + u8 testdin; +}; + +/* The table is based on 27MHz DPHY pll reference clock. */ +static const struct dphy_pll_testdin_map dptdin_map[] = { + {160, 0x04}, {180, 0x24}, {200, 0x44}, {210, 0x06}, + {240, 0x26}, {250, 0x46}, {270, 0x08}, {300, 0x28}, + {330, 0x48}, {360, 0x2a}, {400, 0x4a}, {450, 0x0c}, + {500, 0x2c}, {550, 0x0e}, {600, 0x2e}, {650, 0x10}, + {700, 0x30}, {750, 0x12}, {800, 0x32}, {850, 0x14}, + {900, 0x34}, {950, 0x54}, {1000, 0x74} +}; + +static inline struct imx_mipi_dsi *enc_to_dsi(struct drm_encoder *enc) +{ + return container_of(enc, struct imx_mipi_dsi, encoder); +} + +static void imx_mipi_dsi_set_ipu_di_mux(struct imx_mipi_dsi *dsi, int ipu_di) +{ + regmap_update_bits(dsi->mux_sel, IOMUXC_GPR3, + IMX6Q_GPR3_MIPI_MUX_CTL_MASK, + ipu_di << IMX6Q_GPR3_MIPI_MUX_CTL_SHIFT); +} + +static const struct drm_encoder_funcs imx_mipi_dsi_encoder_funcs = { + .destroy = imx_drm_encoder_destroy, +}; + +static bool imx_mipi_dsi_encoder_mode_fixup(struct drm_encoder *encoder, + const struct drm_display_mode *mode, + struct drm_display_mode *adj_mode) +{ + return true; +} + +static int imx_mipi_dsi_encoder_atomic_check(struct drm_encoder *encoder, + struct drm_crtc_state *crtc_state, + struct drm_connector_state *conn) +{ + struct imx_crtc_state *imx_crtc_state = to_imx_crtc_state(crtc_state); + + /* The following values are taken from dw_hdmi_imx_atomic_check */ + imx_crtc_state->bus_format = MEDIA_BUS_FMT_RGB888_1X24; + imx_crtc_state->di_hsync_pin = 2; + imx_crtc_state->di_vsync_pin = 3; + + return 0; +} + +static void imx_mipi_dsi_encoder_commit(struct drm_encoder *encoder) +{ + struct imx_mipi_dsi *dsi = enc_to_dsi(encoder); + int mux = drm_of_encoder_active_port_id(dsi->dev->of_node, encoder); + + imx_mipi_dsi_set_ipu_di_mux(dsi, mux); +} + +static void imx_mipi_dsi_encoder_disable(struct drm_encoder *encoder) +{ +} + +static const struct drm_encoder_helper_funcs imx_mipi_dsi_encoder_helpers = { + .mode_fixup = imx_mipi_dsi_encoder_mode_fixup, + .commit = imx_mipi_dsi_encoder_commit, + .disable = imx_mipi_dsi_encoder_disable, + .atomic_check = imx_mipi_dsi_encoder_atomic_check, +}; + +static int imx_mipi_dsi_register(struct drm_device *drm, + struct imx_mipi_dsi *dsi) +{ + int ret; + + ret = imx_drm_encoder_parse_of(drm, &dsi->encoder, dsi->dev->of_node); + if (ret) + return ret; + + drm_encoder_helper_add(&dsi->encoder, + &imx_mipi_dsi_encoder_helpers); + drm_encoder_init(drm, &dsi->encoder, &imx_mipi_dsi_encoder_funcs, + DRM_MODE_ENCODER_DSI, NULL); + return 0; +} + +static enum drm_mode_status imx_mipi_dsi_mode_valid(void *priv_data, + const struct drm_display_mode *mode) +{ + /* + * The VID_PKT_SIZE field in the DSI_VID_PKT_CFG + * register is 11-bit. + */ + if (mode->hdisplay > 0x7ff) + return MODE_BAD_HVALUE; + + /* + * The V_ACTIVE_LINES field in the DSI_VTIMING_CFG + * register is 11-bit. + */ + if (mode->vdisplay > 0x7ff) + return MODE_BAD_VVALUE; + + return MODE_OK; +} + + +static unsigned int max_mbps_to_testdin(unsigned int max_mbps) +{ + unsigned int i; + + for (i = 0; i < ARRAY_SIZE(dptdin_map); i++) + if (dptdin_map[i].max_mbps == max_mbps) + return dptdin_map[i].testdin; + + return -EINVAL; +} + +static inline void dsi_write(struct imx_mipi_dsi *dsi, u32 reg, u32 val) +{ + writel(val, dsi->base + reg); +} + +static int imx_mipi_dsi_phy_init(void *priv_data) +{ + struct imx_mipi_dsi *dsi = priv_data; + int testdin; + + testdin = max_mbps_to_testdin(dsi->lane_mbps); + if (testdin < 0) { + dev_err(dsi->dev, + "failed to get testdin for %dmbps lane clock\n", + dsi->lane_mbps); + return testdin; + } + + dsi_write(dsi, DSI_PHY_IF_CTRL, PHY_IF_CTRL_RESET); + dsi_write(dsi, DSI_PWR_UP, POWERUP); + + dsi_write(dsi, DSI_PHY_TST_CTRL0, PHY_UNTESTCLK | PHY_UNTESTCLR); + dsi_write(dsi, DSI_PHY_TST_CTRL1, PHY_TESTEN | PHY_TESTDOUT(0) | + PHY_TESTDIN(0x44)); + dsi_write(dsi, DSI_PHY_TST_CTRL0, PHY_TESTCLK | PHY_UNTESTCLR); + dsi_write(dsi, DSI_PHY_TST_CTRL0, PHY_UNTESTCLK | PHY_UNTESTCLR); + dsi_write(dsi, DSI_PHY_TST_CTRL1, PHY_UNTESTEN | PHY_TESTDOUT(0) | + PHY_TESTDIN(testdin)); + dsi_write(dsi, DSI_PHY_TST_CTRL0, PHY_TESTCLK | PHY_UNTESTCLR); + dsi_write(dsi, DSI_PHY_TST_CTRL0, PHY_UNTESTCLK | PHY_UNTESTCLR); + + return 0; +} + +static int imx_mipi_dsi_get_lane_mbps(void *priv_data, + const struct drm_display_mode *mode, + unsigned long mode_flags, u32 lanes, + u32 format, unsigned int *lane_mbps) +{ + struct imx_mipi_dsi *dsi = priv_data; + int bpp; + unsigned int i, target_mbps, mpclk; + unsigned long pllref; + + bpp = mipi_dsi_pixel_format_to_bpp(format); + if (bpp < 0) { + dev_err(dsi->dev, "failed to get bpp for pixel format %d\n", + format); + return bpp; + } + + pllref = clk_get_rate(dsi->pllref_clk); + if (pllref != 27000000) + dev_warn(dsi->dev, "expect 27MHz DPHY pll reference clock\n"); + + mpclk = DIV_ROUND_UP(mode->clock, MSEC_PER_SEC); + if (mpclk) { + /* take 1/0.7 blanking overhead into consideration */ + target_mbps = (mpclk * (bpp / lanes) * 10) / 7; + } else { + dev_dbg(dsi->dev, "use default 1Gbps DPHY pll clock\n"); + target_mbps = 1000; + } + + dev_dbg(dsi->dev, "target DPHY pll clock frequency is %uMbps\n", + target_mbps); + + for (i = 0; i < ARRAY_SIZE(dptdin_map); i++) { + if (target_mbps < dptdin_map[i].max_mbps) { + *lane_mbps = dptdin_map[i].max_mbps; + dsi->lane_mbps = *lane_mbps; + dev_dbg(dsi->dev, + "real DPHY pll clock frequency is %uMbps\n", + *lane_mbps); + return 0; + } + } + + dev_err(dsi->dev, "DPHY clock frequency %uMbps is out of range\n", + target_mbps); + + return -EINVAL; +} + +static int +dw_mipi_dsi_phy_get_timing(void *priv_data, unsigned int lane_mbps, + struct dw_mipi_dsi_dphy_timing *timing) +{ + timing->clk_hs2lp = 0x40; + timing->clk_lp2hs = 0x40; + timing->data_hs2lp = 0x40; + timing->data_lp2hs = 0x40; + + return 0; +} + +static const struct dw_mipi_dsi_phy_ops dw_mipi_dsi_imx6_phy_ops = { + .init = imx_mipi_dsi_phy_init, + .get_lane_mbps = imx_mipi_dsi_get_lane_mbps, + .get_timing = dw_mipi_dsi_phy_get_timing, +}; + +static struct dw_mipi_dsi_plat_data imx6q_mipi_dsi_drv_data = { + .max_data_lanes = 2, + .mode_valid = imx_mipi_dsi_mode_valid, + .phy_ops = &dw_mipi_dsi_imx6_phy_ops, +}; + +static const struct of_device_id imx_dsi_dt_ids[] = { + { + .compatible = "fsl,imx6q-mipi-dsi", + .data = &imx6q_mipi_dsi_drv_data, + }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, imx_dsi_dt_ids); + +static int imx_mipi_dsi_bind(struct device *dev, struct device *master, + void *data) +{ + struct imx_mipi_dsi *dsi = dev_get_drvdata(dev); + struct drm_device *drm = data; + int ret; + + ret = imx_mipi_dsi_register(drm, dsi); + if (ret) + return ret; + + ret = dw_mipi_dsi_bind(dsi->mipi_dsi, &dsi->encoder); + if (ret) + return ret; + + return 0; +} + +static void imx_mipi_dsi_unbind(struct device *dev, struct device *master, + void *data) +{ + struct imx_mipi_dsi *dsi = dev_get_drvdata(dev); + + return dw_mipi_dsi_unbind(dsi->mipi_dsi); +} + +static const struct component_ops imx_mipi_dsi_ops = { + .bind = imx_mipi_dsi_bind, + .unbind = imx_mipi_dsi_unbind, +}; + +static int imx_mipi_dsi_probe(struct platform_device *pdev) +{ + struct device *dev = &pdev->dev; + const struct of_device_id *of_id = of_match_device(imx_dsi_dt_ids, dev); + struct dw_mipi_dsi_plat_data *pdata = (struct dw_mipi_dsi_plat_data*) of_id->data; + struct imx_mipi_dsi *dsi; + struct resource *res; + int ret; + + dsi = devm_kzalloc(dev, sizeof(*dsi), GFP_KERNEL); + if (!dsi) + return -ENOMEM; + + dsi->dev = dev; + + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + dsi->base = devm_ioremap_resource(dev, res); + if (IS_ERR(dsi->base)) { + DRM_DEV_ERROR(dev, "Unable to get dsi registers\n"); + return PTR_ERR(dsi->base); + } + + dsi->pllref_clk = devm_clk_get(dev, "ref"); + if (IS_ERR(dsi->pllref_clk)) { + ret = PTR_ERR(dsi->pllref_clk); + dev_dbg(dev, "%s: Unable to get pll reference clock: %d\n", + __func__, ret); + return ret; + } + + ret = clk_prepare_enable(dsi->pllref_clk); + if (ret) { + dev_err(dev, "%s: Failed to enable pllref_clk\n", __func__); + return ret; + } + + dsi->mux_sel = syscon_regmap_lookup_by_phandle(dev->of_node, "fsl,gpr"); + if (IS_ERR(dsi->mux_sel)) { + ret = PTR_ERR(dsi->mux_sel); + dev_err(dev, "%s: Failed to get GPR regmap: %d\n", + __func__, ret); + return ret; + } + + dev_set_drvdata(dev, dsi); + + imx6q_mipi_dsi_drv_data.base = dsi->base; + imx6q_mipi_dsi_drv_data.priv_data = dsi; + + dsi->mipi_dsi = dw_mipi_dsi_probe(pdev, pdata); + if (IS_ERR(dsi->mipi_dsi)) { + ret = PTR_ERR(dsi->mipi_dsi); + dev_dbg(dev, "%s: Unable to probe DW DSI host device: %d\n", + __func__, ret); + return -ENODEV; + } + + return component_add(&pdev->dev, &imx_mipi_dsi_ops); +} + +static int imx_mipi_dsi_remove(struct platform_device *pdev) +{ + component_del(&pdev->dev, &imx_mipi_dsi_ops); + return 0; +} + +static struct platform_driver imx_mipi_dsi_driver = { + .probe = imx_mipi_dsi_probe, + .remove = imx_mipi_dsi_remove, + .driver = { + .of_match_table = imx_dsi_dt_ids, + .name = "dw-mipi-dsi-imx6", + }, +}; +module_platform_driver(imx_mipi_dsi_driver); + +MODULE_DESCRIPTION("i.MX6 MIPI DSI host controller driver"); +MODULE_AUTHOR("Liu Ying <Ying.Liu@freescale.com>"); +MODULE_LICENSE("GPL");