| Message ID | 20200130084941.60943-1-k.jensen@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [blktests] common/fio: do not use norandommap with verify | expand |
On Thu, Jan 30, 2020 at 09:49:41AM +0100, Klaus Jensen wrote: > As per the fio documentation, using norandommap with an async I/O engine > and I/O depth > 1, can cause verification errors. > > Signed-off-by: Klaus Jensen <k.jensen@samsung.com> Good catch, applied. Thanks!
On Feb 3 13:43, Omar Sandoval wrote: > On Thu, Jan 30, 2020 at 09:49:41AM +0100, Klaus Jensen wrote: > > As per the fio documentation, using norandommap with an async I/O engine > > and I/O depth > 1, can cause verification errors. > > > > Signed-off-by: Klaus Jensen <k.jensen@samsung.com> > > Good catch, applied. Thanks! Hi Omar, Looks like this got lost somewhere? Klaus
On Thu, Apr 02, 2020 at 01:25:09PM +0200, Klaus Birkelund Jensen wrote: > On Feb 3 13:43, Omar Sandoval wrote: > > On Thu, Jan 30, 2020 at 09:49:41AM +0100, Klaus Jensen wrote: > > > As per the fio documentation, using norandommap with an async I/O engine > > > and I/O depth > 1, can cause verification errors. > > > > > > Signed-off-by: Klaus Jensen <k.jensen@samsung.com> > > > > Good catch, applied. Thanks! > > Hi Omar, > > Looks like this got lost somewhere? You're right, not sure what happened there. Applied and pushed this time.
diff --git a/common/fio b/common/fio index 2e81b26b50f1..8bfad4238dda 100644 --- a/common/fio +++ b/common/fio @@ -180,7 +180,7 @@ _run_fio_rand_io() { _run_fio_verify_io() { _run_fio --name=verify --rw=randwrite --direct=1 --ioengine=libaio --bs=4k \ - --norandommap --iodepth=16 --verify=crc32c "$@" + --iodepth=16 --verify=crc32c "$@" } _fio_perf_report() {
As per the fio documentation, using norandommap with an async I/O engine and I/O depth > 1, can cause verification errors. Signed-off-by: Klaus Jensen <k.jensen@samsung.com> --- common/fio | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)