| Message ID | 20200402113344.16772-1-tangbin@cmss.chinamobile.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | crypto:amlogic - use platform_get_irq_optional() | expand |
Hi, On 02/04/2020 13:33, Tang Bin wrote: > In order to simply code,because platform_get_irq() already has > dev_err() message. > > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> > --- > drivers/crypto/amlogic/amlogic-gxl-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/crypto/amlogic/amlogic-gxl-core.c b/drivers/crypto/amlogic/amlogic-gxl-core.c > index 9d4ead2f7..37901bd81 100644 > --- a/drivers/crypto/amlogic/amlogic-gxl-core.c > +++ b/drivers/crypto/amlogic/amlogic-gxl-core.c > @@ -252,7 +252,7 @@ static int meson_crypto_probe(struct platform_device *pdev) > > mc->irqs = devm_kcalloc(mc->dev, MAXFLOW, sizeof(int), GFP_KERNEL); > for (i = 0; i < MAXFLOW; i++) { > - mc->irqs[i] = platform_get_irq(pdev, i); > + mc->irqs[i] = platform_get_irq_optional(pdev, i); > if (mc->irqs[i] < 0) { > dev_err(mc->dev, "Cannot get IRQ for flow %d\n", i); > return mc->irqs[i]; > NACK, the irq is not optional, I don't see why platform_get_irq_optional() should be used here and how it could "simply code". Neil
Hi, On 02/04/2020 17:29, tangbin@cmss.chinamobile.com wrote: > Dear Neil： > Thank you for your replay，maybe my description is not so clear。What I want to say is：In this place, when something goes wrong, platform_get_irq() will print an error message, and this function will print both，so if we want to avoid the situation of repeat output，we can remove dev_err() here or use platform_get_irq_optional() instead of platform_get_irq()。Thank you very much。 Please do not top-post. Since the irq is not optional, removing the dev_err() is the right way to go. Neil > > ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ > > > *From:* Neil Armstrong <mailto:narmstrong@baylibre.com> > *Date:* 2020-04-02 21:26 > *To:* Tang Bin <mailto:tangbin@cmss.chinamobile.com>; clabbe <mailto:clabbe@baylibre.com>; herbert <mailto:herbert@gondor.apana.org.au>; davem <mailto:davem@davemloft.net> > *CC:* linux-amlogic <mailto:linux-amlogic@lists.infradead.org>; linux-crypto <mailto:linux-crypto@vger.kernel.org>; linux-kernel <mailto:linux-kernel@vger.kernel.org> > *Subject:* Re: [PATCH] crypto:amlogic - use platform_get_irq_optional() > Hi, > > On 02/04/2020 13:33, Tang Bin wrote: > > In order to simply code,because platform_get_irq() already has > > dev_err() message. > > > > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> > > --- > > drivers/crypto/amlogic/amlogic-gxl-core.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/crypto/amlogic/amlogic-gxl-core.c b/drivers/crypto/amlogic/amlogic-gxl-core.c > > index 9d4ead2f7..37901bd81 100644 > > --- a/drivers/crypto/amlogic/amlogic-gxl-core.c > > +++ b/drivers/crypto/amlogic/amlogic-gxl-core.c > > @@ -252,7 +252,7 @@ static int meson_crypto_probe(struct platform_device *pdev) > > > > mc->irqs = devm_kcalloc(mc->dev, MAXFLOW, sizeof(int), GFP_KERNEL); > > for (i = 0; i < MAXFLOW; i++) { > > - mc->irqs[i] = platform_get_irq(pdev, i); > > + mc->irqs[i] = platform_get_irq_optional(pdev, i); > > if (mc->irqs[i] < 0) { > > dev_err(mc->dev, "Cannot get IRQ for flow %d\n", i); > > return mc->irqs[i]; > > > > NACK, the irq is not optional, I don't see why platform_get_irq_optional() should be used here > and how it could "simply code". > > Neil >
diff --git a/drivers/crypto/amlogic/amlogic-gxl-core.c b/drivers/crypto/amlogic/amlogic-gxl-core.c index 9d4ead2f7..37901bd81 100644 --- a/drivers/crypto/amlogic/amlogic-gxl-core.c +++ b/drivers/crypto/amlogic/amlogic-gxl-core.c @@ -252,7 +252,7 @@ static int meson_crypto_probe(struct platform_device *pdev) mc->irqs = devm_kcalloc(mc->dev, MAXFLOW, sizeof(int), GFP_KERNEL); for (i = 0; i < MAXFLOW; i++) { - mc->irqs[i] = platform_get_irq(pdev, i); + mc->irqs[i] = platform_get_irq_optional(pdev, i); if (mc->irqs[i] < 0) { dev_err(mc->dev, "Cannot get IRQ for flow %d\n", i); return mc->irqs[i];
In order to simply code,because platform_get_irq() already has dev_err() message. Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> --- drivers/crypto/amlogic/amlogic-gxl-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)