| Message ID | 20200306002202.176732-1-leonardo@linux.ibm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [RFC,1/1] ppc/spapr: Add hotplugged flag on DIMM LMBs on drmem_v2 | expand |
On Thu, Mar 05, 2020 at 09:22:02PM -0300, Leonardo Bras wrote: > On reboot, all memory that was previously added using object_add and > device_add is placed in this DIMM area. > > The new SPAPR_LMB_FLAGS_HOTPLUGGED flag helps Linux to put this memory in > the correct memory zone, so no unmovable allocations are made there, > allowing the object to be easily hot-removed by device_del and > object_del. > > Signed-off-by: Leonardo Bras <leonardo@linux.ibm.com> > > --- > The new flag was already proposed on Power Architecture documentation, > and it's waiting for approval. > > I would like to get your comments on this change, but it's still not > ready for being merged. This looks reasonable to me - at the very least it doesn't look like it could do much harm. > > Matching Linux change is here: > http://patchwork.ozlabs.org/patch/1249917/ > --- > hw/ppc/spapr.c | 3 ++- > include/hw/ppc/spapr.h | 1 + > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index cc10798be4..01611b7953 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -699,7 +699,8 @@ static int spapr_populate_drmem_v2(SpaprMachineState *spapr, void *fdt, > g_assert(drc); > elem = spapr_get_drconf_cell(size / lmb_size, addr, > spapr_drc_index(drc), node, > - SPAPR_LMB_FLAGS_ASSIGNED); > + (SPAPR_LMB_FLAGS_ASSIGNED | > + SPAPR_LMB_FLAGS_HOTPLUGGED); > QSIMPLEQ_INSERT_TAIL(&drconf_queue, elem, entry); > nr_entries++; > cur_addr = addr + size; > diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h > index 09110961a5..64a138d4d4 100644 > --- a/include/hw/ppc/spapr.h > +++ b/include/hw/ppc/spapr.h > @@ -870,6 +870,7 @@ int spapr_rtc_import_offset(SpaprRtcState *rtc, int64_t legacy_offset); > #define SPAPR_LMB_FLAGS_ASSIGNED 0x00000008 > #define SPAPR_LMB_FLAGS_DRC_INVALID 0x00000020 > #define SPAPR_LMB_FLAGS_RESERVED 0x00000080 > +#define SPAPR_LMB_FLAGS_HOTPLUGGED 0x00000100 > > void spapr_do_system_reset_on_cpu(CPUState *cs, run_on_cpu_data arg); >
On Tue, Mar 10, 2020 at 8:24 AM David Gibson <david@gibson.dropbear.id.au> wrote: > > On Thu, Mar 05, 2020 at 09:22:02PM -0300, Leonardo Bras wrote: > > On reboot, all memory that was previously added using object_add and > > device_add is placed in this DIMM area. > > > > The new SPAPR_LMB_FLAGS_HOTPLUGGED flag helps Linux to put this memory in > > the correct memory zone, so no unmovable allocations are made there, > > allowing the object to be easily hot-removed by device_del and > > object_del. > > > > Signed-off-by: Leonardo Bras <leonardo@linux.ibm.com> > > > > --- > > The new flag was already proposed on Power Architecture documentation, > > and it's waiting for approval. > > > > I would like to get your comments on this change, but it's still not > > ready for being merged. > > This looks reasonable to me - at the very least it doesn't look like > it could do much harm. Looks good to me, also tested with PowerKVM guests. Reviewed-by: Bharata B Rao <bharata@linux.ibm.com> Regards, Bharata.
Hello Bharata, thank you for reviewing and testing! During review of this new flag, it was suggested to change it's name to a better one (on platform's viewpoint). So I will have to change the flag name from SPAPR_LMB_FLAGS_HOTPLUGGED to SPAPR_LMB_FLAGS_HOTREMOVABLE. Everything should work the same as today. Best regards, Leonardo On Thu, 2020-04-02 at 14:46 +0530, Bharata B Rao wrote: > On Tue, Mar 10, 2020 at 8:24 AM David Gibson > <david@gibson.dropbear.id.au> wrote: > > On Thu, Mar 05, 2020 at 09:22:02PM -0300, Leonardo Bras wrote: > > > On reboot, all memory that was previously added using object_add and > > > device_add is placed in this DIMM area. > > > > > > The new SPAPR_LMB_FLAGS_HOTPLUGGED flag helps Linux to put this memory in > > > the correct memory zone, so no unmovable allocations are made there, > > > allowing the object to be easily hot-removed by device_del and > > > object_del. > > > > > > Signed-off-by: Leonardo Bras <leonardo@linux.ibm.com> > > > > > > --- > > > The new flag was already proposed on Power Architecture documentation, > > > and it's waiting for approval. > > > > > > I would like to get your comments on this change, but it's still not > > > ready for being merged. > > > > This looks reasonable to me - at the very least it doesn't look like > > it could do much harm. > > Looks good to me, also tested with PowerKVM guests. > > Reviewed-by: Bharata B Rao <bharata@linux.ibm.com> > > Regards, > Bharata.
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index cc10798be4..01611b7953 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -699,7 +699,8 @@ static int spapr_populate_drmem_v2(SpaprMachineState *spapr, void *fdt, g_assert(drc); elem = spapr_get_drconf_cell(size / lmb_size, addr, spapr_drc_index(drc), node, - SPAPR_LMB_FLAGS_ASSIGNED); + (SPAPR_LMB_FLAGS_ASSIGNED | + SPAPR_LMB_FLAGS_HOTPLUGGED); QSIMPLEQ_INSERT_TAIL(&drconf_queue, elem, entry); nr_entries++; cur_addr = addr + size; diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h index 09110961a5..64a138d4d4 100644 --- a/include/hw/ppc/spapr.h +++ b/include/hw/ppc/spapr.h @@ -870,6 +870,7 @@ int spapr_rtc_import_offset(SpaprRtcState *rtc, int64_t legacy_offset); #define SPAPR_LMB_FLAGS_ASSIGNED 0x00000008 #define SPAPR_LMB_FLAGS_DRC_INVALID 0x00000020 #define SPAPR_LMB_FLAGS_RESERVED 0x00000080 +#define SPAPR_LMB_FLAGS_HOTPLUGGED 0x00000100 void spapr_do_system_reset_on_cpu(CPUState *cs, run_on_cpu_data arg);
On reboot, all memory that was previously added using object_add and device_add is placed in this DIMM area. The new SPAPR_LMB_FLAGS_HOTPLUGGED flag helps Linux to put this memory in the correct memory zone, so no unmovable allocations are made there, allowing the object to be easily hot-removed by device_del and object_del. Signed-off-by: Leonardo Bras <leonardo@linux.ibm.com> --- The new flag was already proposed on Power Architecture documentation, and it's waiting for approval. I would like to get your comments on this change, but it's still not ready for being merged. Matching Linux change is here: http://patchwork.ozlabs.org/patch/1249917/ --- hw/ppc/spapr.c | 3 ++- include/hw/ppc/spapr.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-)