| Message ID | cover.1584620202.git.msuchanek@suse.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | Disable compat cruft on ppc64le v11 | expand |
You sent it twice ? Any difference between the two dispatch ? Christophe Le 19/03/2020 à 13:19, Michal Suchanek a écrit : > Less code means less bugs so add a knob to skip the compat stuff. > > Changes in v2: saner CONFIG_COMPAT ifdefs > Changes in v3: > - change llseek to 32bit instead of builing it unconditionally in fs > - clanup the makefile conditionals > - remove some ifdefs or convert to IS_DEFINED where possible > Changes in v4: > - cleanup is_32bit_task and current_is_64bit > - more makefile cleanup > Changes in v5: > - more current_is_64bit cleanup > - split off callchain.c 32bit and 64bit parts > Changes in v6: > - cleanup makefile after split > - consolidate read_user_stack_32 > - fix some checkpatch warnings > Changes in v7: > - add back __ARCH_WANT_SYS_LLSEEK to fix build with llseek > - remove leftover hunk > - add review tags > Changes in v8: > - consolidate valid_user_sp to fix it in the split callchain.c > - fix build errors/warnings with PPC64 !COMPAT and PPC32 > Changes in v9: > - remove current_is_64bit() > Chanegs in v10: > - rebase, sent together with the syscall cleanup > Changes in v11: > - rebase > - add MAINTAINERS pattern for ppc perf > > Michal Suchanek (8): > powerpc: Add back __ARCH_WANT_SYS_LLSEEK macro > powerpc: move common register copy functions from signal_32.c to > signal.c > powerpc/perf: consolidate read_user_stack_32 > powerpc/perf: consolidate valid_user_sp > powerpc/64: make buildable without CONFIG_COMPAT > powerpc/64: Make COMPAT user-selectable disabled on littleendian by > default. > powerpc/perf: split callchain.c by bitness > MAINTAINERS: perf: Add pattern that matches ppc perf to the perf > entry. > > MAINTAINERS | 2 + > arch/powerpc/Kconfig | 5 +- > arch/powerpc/include/asm/thread_info.h | 4 +- > arch/powerpc/include/asm/unistd.h | 1 + > arch/powerpc/kernel/Makefile | 6 +- > arch/powerpc/kernel/entry_64.S | 2 + > arch/powerpc/kernel/signal.c | 144 +++++++++- > arch/powerpc/kernel/signal_32.c | 140 ---------- > arch/powerpc/kernel/syscall_64.c | 6 +- > arch/powerpc/kernel/vdso.c | 3 +- > arch/powerpc/perf/Makefile | 5 +- > arch/powerpc/perf/callchain.c | 356 +------------------------ > arch/powerpc/perf/callchain.h | 20 ++ > arch/powerpc/perf/callchain_32.c | 196 ++++++++++++++ > arch/powerpc/perf/callchain_64.c | 174 ++++++++++++ > fs/read_write.c | 3 +- > 16 files changed, 556 insertions(+), 511 deletions(-) > create mode 100644 arch/powerpc/perf/callchain.h > create mode 100644 arch/powerpc/perf/callchain_32.c > create mode 100644 arch/powerpc/perf/callchain_64.c >
On Thu, Mar 19, 2020 at 01:36:56PM +0100, Christophe Leroy wrote: > You sent it twice ? Any difference between the two dispatch ? Some headers were broken the first time around. Thanks Michal > > Christophe > > Le 19/03/2020 à 13:19, Michal Suchanek a écrit : > > Less code means less bugs so add a knob to skip the compat stuff. > > > > Changes in v2: saner CONFIG_COMPAT ifdefs > > Changes in v3: > > - change llseek to 32bit instead of builing it unconditionally in fs > > - clanup the makefile conditionals > > - remove some ifdefs or convert to IS_DEFINED where possible > > Changes in v4: > > - cleanup is_32bit_task and current_is_64bit > > - more makefile cleanup > > Changes in v5: > > - more current_is_64bit cleanup > > - split off callchain.c 32bit and 64bit parts > > Changes in v6: > > - cleanup makefile after split > > - consolidate read_user_stack_32 > > - fix some checkpatch warnings > > Changes in v7: > > - add back __ARCH_WANT_SYS_LLSEEK to fix build with llseek > > - remove leftover hunk > > - add review tags > > Changes in v8: > > - consolidate valid_user_sp to fix it in the split callchain.c > > - fix build errors/warnings with PPC64 !COMPAT and PPC32 > > Changes in v9: > > - remove current_is_64bit() > > Chanegs in v10: > > - rebase, sent together with the syscall cleanup > > Changes in v11: > > - rebase > > - add MAINTAINERS pattern for ppc perf > > > > Michal Suchanek (8): > > powerpc: Add back __ARCH_WANT_SYS_LLSEEK macro > > powerpc: move common register copy functions from signal_32.c to > > signal.c > > powerpc/perf: consolidate read_user_stack_32 > > powerpc/perf: consolidate valid_user_sp > > powerpc/64: make buildable without CONFIG_COMPAT > > powerpc/64: Make COMPAT user-selectable disabled on littleendian by > > default. > > powerpc/perf: split callchain.c by bitness > > MAINTAINERS: perf: Add pattern that matches ppc perf to the perf > > entry. > > > > MAINTAINERS | 2 + > > arch/powerpc/Kconfig | 5 +- > > arch/powerpc/include/asm/thread_info.h | 4 +- > > arch/powerpc/include/asm/unistd.h | 1 + > > arch/powerpc/kernel/Makefile | 6 +- > > arch/powerpc/kernel/entry_64.S | 2 + > > arch/powerpc/kernel/signal.c | 144 +++++++++- > > arch/powerpc/kernel/signal_32.c | 140 ---------- > > arch/powerpc/kernel/syscall_64.c | 6 +- > > arch/powerpc/kernel/vdso.c | 3 +- > > arch/powerpc/perf/Makefile | 5 +- > > arch/powerpc/perf/callchain.c | 356 +------------------------ > > arch/powerpc/perf/callchain.h | 20 ++ > > arch/powerpc/perf/callchain_32.c | 196 ++++++++++++++ > > arch/powerpc/perf/callchain_64.c | 174 ++++++++++++ > > fs/read_write.c | 3 +- > > 16 files changed, 556 insertions(+), 511 deletions(-) > > create mode 100644 arch/powerpc/perf/callchain.h > > create mode 100644 arch/powerpc/perf/callchain_32.c > > create mode 100644 arch/powerpc/perf/callchain_64.c > >
Michal Suchanek's on March 19, 2020 10:19 pm: > Less code means less bugs so add a knob to skip the compat stuff. > > Changes in v2: saner CONFIG_COMPAT ifdefs > Changes in v3: > - change llseek to 32bit instead of builing it unconditionally in fs > - clanup the makefile conditionals > - remove some ifdefs or convert to IS_DEFINED where possible > Changes in v4: > - cleanup is_32bit_task and current_is_64bit > - more makefile cleanup > Changes in v5: > - more current_is_64bit cleanup > - split off callchain.c 32bit and 64bit parts > Changes in v6: > - cleanup makefile after split > - consolidate read_user_stack_32 > - fix some checkpatch warnings > Changes in v7: > - add back __ARCH_WANT_SYS_LLSEEK to fix build with llseek > - remove leftover hunk > - add review tags > Changes in v8: > - consolidate valid_user_sp to fix it in the split callchain.c > - fix build errors/warnings with PPC64 !COMPAT and PPC32 > Changes in v9: > - remove current_is_64bit() > Chanegs in v10: > - rebase, sent together with the syscall cleanup > Changes in v11: > - rebase > - add MAINTAINERS pattern for ppc perf These all look good to me. I had some minor comment about one patch but not really a big deal and there were more cleanups on top of it, so I don't mind if it's merged as is. Actually I think we have a bit of stack reading fixes for 64s radix now (not a bug fix as such, but we don't need the hash fault logic in radix), so if I get around to that I can propose the changes in that series. Thanks, Nick
Le 03/04/2020 à 09:25, Nicholas Piggin a écrit : > Michal Suchanek's on March 19, 2020 10:19 pm: >> Less code means less bugs so add a knob to skip the compat stuff. >> >> Changes in v2: saner CONFIG_COMPAT ifdefs >> Changes in v3: >> - change llseek to 32bit instead of builing it unconditionally in fs >> - clanup the makefile conditionals >> - remove some ifdefs or convert to IS_DEFINED where possible >> Changes in v4: >> - cleanup is_32bit_task and current_is_64bit >> - more makefile cleanup >> Changes in v5: >> - more current_is_64bit cleanup >> - split off callchain.c 32bit and 64bit parts >> Changes in v6: >> - cleanup makefile after split >> - consolidate read_user_stack_32 >> - fix some checkpatch warnings >> Changes in v7: >> - add back __ARCH_WANT_SYS_LLSEEK to fix build with llseek >> - remove leftover hunk >> - add review tags >> Changes in v8: >> - consolidate valid_user_sp to fix it in the split callchain.c >> - fix build errors/warnings with PPC64 !COMPAT and PPC32 >> Changes in v9: >> - remove current_is_64bit() >> Chanegs in v10: >> - rebase, sent together with the syscall cleanup >> Changes in v11: >> - rebase >> - add MAINTAINERS pattern for ppc perf > > These all look good to me. I had some minor comment about one patch but > not really a big deal and there were more cleanups on top of it, so I > don't mind if it's merged as is. > > Actually I think we have a bit of stack reading fixes for 64s radix now > (not a bug fix as such, but we don't need the hash fault logic in radix), > so if I get around to that I can propose the changes in that series. > As far as I can see, there is a v12 Christophe
Christophe Leroy's on April 3, 2020 5:26 pm: > > > Le 03/04/2020 à 09:25, Nicholas Piggin a écrit : >> Michal Suchanek's on March 19, 2020 10:19 pm: >>> Less code means less bugs so add a knob to skip the compat stuff. >>> >>> Changes in v2: saner CONFIG_COMPAT ifdefs >>> Changes in v3: >>> - change llseek to 32bit instead of builing it unconditionally in fs >>> - clanup the makefile conditionals >>> - remove some ifdefs or convert to IS_DEFINED where possible >>> Changes in v4: >>> - cleanup is_32bit_task and current_is_64bit >>> - more makefile cleanup >>> Changes in v5: >>> - more current_is_64bit cleanup >>> - split off callchain.c 32bit and 64bit parts >>> Changes in v6: >>> - cleanup makefile after split >>> - consolidate read_user_stack_32 >>> - fix some checkpatch warnings >>> Changes in v7: >>> - add back __ARCH_WANT_SYS_LLSEEK to fix build with llseek >>> - remove leftover hunk >>> - add review tags >>> Changes in v8: >>> - consolidate valid_user_sp to fix it in the split callchain.c >>> - fix build errors/warnings with PPC64 !COMPAT and PPC32 >>> Changes in v9: >>> - remove current_is_64bit() >>> Chanegs in v10: >>> - rebase, sent together with the syscall cleanup >>> Changes in v11: >>> - rebase >>> - add MAINTAINERS pattern for ppc perf >> >> These all look good to me. I had some minor comment about one patch but >> not really a big deal and there were more cleanups on top of it, so I >> don't mind if it's merged as is. >> >> Actually I think we have a bit of stack reading fixes for 64s radix now >> (not a bug fix as such, but we don't need the hash fault logic in radix), >> so if I get around to that I can propose the changes in that series. >> > > As far as I can see, there is a v12 For the most part I was looking at the patches in mpe's next-test tree on github, if that's the v12 series, same comment applies but it's a pretty small nitpick. Thanks, Nick
Nicholas Piggin <npiggin@gmail.com> writes: > Christophe Leroy's on April 3, 2020 5:26 pm: >> Le 03/04/2020 à 09:25, Nicholas Piggin a écrit : >>> Michal Suchanek's on March 19, 2020 10:19 pm: >>>> Less code means less bugs so add a knob to skip the compat stuff. >>>> >>>> Changes in v2: saner CONFIG_COMPAT ifdefs >>>> Changes in v3: >>>> - change llseek to 32bit instead of builing it unconditionally in fs >>>> - clanup the makefile conditionals >>>> - remove some ifdefs or convert to IS_DEFINED where possible >>>> Changes in v4: >>>> - cleanup is_32bit_task and current_is_64bit >>>> - more makefile cleanup >>>> Changes in v5: >>>> - more current_is_64bit cleanup >>>> - split off callchain.c 32bit and 64bit parts >>>> Changes in v6: >>>> - cleanup makefile after split >>>> - consolidate read_user_stack_32 >>>> - fix some checkpatch warnings >>>> Changes in v7: >>>> - add back __ARCH_WANT_SYS_LLSEEK to fix build with llseek >>>> - remove leftover hunk >>>> - add review tags >>>> Changes in v8: >>>> - consolidate valid_user_sp to fix it in the split callchain.c >>>> - fix build errors/warnings with PPC64 !COMPAT and PPC32 >>>> Changes in v9: >>>> - remove current_is_64bit() >>>> Chanegs in v10: >>>> - rebase, sent together with the syscall cleanup >>>> Changes in v11: >>>> - rebase >>>> - add MAINTAINERS pattern for ppc perf >>> >>> These all look good to me. I had some minor comment about one patch but >>> not really a big deal and there were more cleanups on top of it, so I >>> don't mind if it's merged as is. >>> >>> Actually I think we have a bit of stack reading fixes for 64s radix now >>> (not a bug fix as such, but we don't need the hash fault logic in radix), >>> so if I get around to that I can propose the changes in that series. >>> >> >> As far as I can see, there is a v12 > > For the most part I was looking at the patches in mpe's next-test > tree on github, if that's the v12 series, same comment applies but > it's a pretty small nitpick. Yeah I have v12 in my tree. This has floated around long enough (our fault), so I'm going to take it and we can fix anything up later. cheers
Less code means less bugs so add a knob to skip the compat stuff. Changes in v2: saner CONFIG_COMPAT ifdefs Changes in v3: - change llseek to 32bit instead of builing it unconditionally in fs - clanup the makefile conditionals - remove some ifdefs or convert to IS_DEFINED where possible Changes in v4: - cleanup is_32bit_task and current_is_64bit - more makefile cleanup Changes in v5: - more current_is_64bit cleanup - split off callchain.c 32bit and 64bit parts Changes in v6: - cleanup makefile after split - consolidate read_user_stack_32 - fix some checkpatch warnings Changes in v7: - add back __ARCH_WANT_SYS_LLSEEK to fix build with llseek - remove leftover hunk - add review tags Changes in v8: - consolidate valid_user_sp to fix it in the split callchain.c - fix build errors/warnings with PPC64 !COMPAT and PPC32 Changes in v9: - remove current_is_64bit() Chanegs in v10: - rebase, sent together with the syscall cleanup Changes in v11: - rebase - add MAINTAINERS pattern for ppc perf Michal Suchanek (8): powerpc: Add back __ARCH_WANT_SYS_LLSEEK macro powerpc: move common register copy functions from signal_32.c to signal.c powerpc/perf: consolidate read_user_stack_32 powerpc/perf: consolidate valid_user_sp powerpc/64: make buildable without CONFIG_COMPAT powerpc/64: Make COMPAT user-selectable disabled on littleendian by default. powerpc/perf: split callchain.c by bitness MAINTAINERS: perf: Add pattern that matches ppc perf to the perf entry. MAINTAINERS | 2 + arch/powerpc/Kconfig | 5 +- arch/powerpc/include/asm/thread_info.h | 4 +- arch/powerpc/include/asm/unistd.h | 1 + arch/powerpc/kernel/Makefile | 6 +- arch/powerpc/kernel/entry_64.S | 2 + arch/powerpc/kernel/signal.c | 144 +++++++++- arch/powerpc/kernel/signal_32.c | 140 ---------- arch/powerpc/kernel/syscall_64.c | 6 +- arch/powerpc/kernel/vdso.c | 3 +- arch/powerpc/perf/Makefile | 5 +- arch/powerpc/perf/callchain.c | 356 +------------------------ arch/powerpc/perf/callchain.h | 20 ++ arch/powerpc/perf/callchain_32.c | 196 ++++++++++++++ arch/powerpc/perf/callchain_64.c | 174 ++++++++++++ fs/read_write.c | 3 +- 16 files changed, 556 insertions(+), 511 deletions(-) create mode 100644 arch/powerpc/perf/callchain.h create mode 100644 arch/powerpc/perf/callchain_32.c create mode 100644 arch/powerpc/perf/callchain_64.c