| Message ID | 20200403142122.297283-2-maxime.chevallier@bootlin.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: rockchip: Introduce driver for the camera interface on PX30 | expand |
Hi Maxime, Am Freitag, 3. April 2020, 16:21:20 CEST schrieb Maxime Chevallier: > Add a documentation for the Rockchip Camera Interface controller > binding. > > This controller can be found on platforms such as the PX30 or the > RK3288, the PX30 being the only platform supported so far. > > Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com> > --- > .../bindings/media/rockchip-cif.yaml | 98 +++++++++++++++++++ > 1 file changed, 98 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/rockchip-cif.yaml > > diff --git a/Documentation/devicetree/bindings/media/rockchip-cif.yaml b/Documentation/devicetree/bindings/media/rockchip-cif.yaml > new file mode 100644 > index 000000000000..87fb5e136edd > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/rockchip-cif.yaml > @@ -0,0 +1,98 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/rockchip-cif.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Rockchip Camera Interface (CIF) > + > +maintainers: > + - Maxime Chevallier <maxime.chevallier@bootlin.com> > + > +description: |- > +Camera Interface for Rockcip platforms > + > +properties: > + compatible: > + const: rockchip,px30-cif > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: ACLK > + - description: HCLK > + - description: PCLK > + - description: CIF_OUT > + > + clock-names: > + items: > + - const: aclk_cif > + - const: hclk_cif > + - const: pclk_cif > + - const: cif_out names for clocks / reset are always local to the node/ip-block so there is no need to have that _cif in them. Also the pclk isn't coming from the cru but from some external source at least on px30 and rk3288 (and I guess others as well), so maybe that deserves a distinct name. Maybe something like aclk, hclk, pclkin or so? Also the cif_out clock is not actual part of the CIF block, on both the rk3288 and px30 (and probably the others too) it is generated in the SoC's clock controller and then just led to an output-pin on the soc, so I'd assume a peripheral wanting to use that would take care of setting+enabling that clock (similar to the i2s mclk)? > + > + resets: > + items: > + - description: Reset CIF A > + - description: Reset CIF H > + - description: Reset CIF PCLK IN > + > + reset-names: > + items: > + - const: rst_cif_a > + - const: rst_cif_h > + - const: rst_cif_pclkin Same here, maybe just "axi", "ahb", "pclkin" like the vop resets do? Heiko
On Fri, 3 Apr 2020 16:21:20 +0200, Maxime Chevallier wrote: > Add a documentation for the Rockchip Camera Interface controller > binding. > > This controller can be found on platforms such as the PX30 or the > RK3288, the PX30 being the only platform supported so far. > > Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com> > --- > .../bindings/media/rockchip-cif.yaml | 98 +++++++++++++++++++ > 1 file changed, 98 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/rockchip-cif.yaml > My bot found errors running 'make dt_binding_check' on your patch: Documentation/devicetree/bindings/media/rockchip-cif.yaml: while scanning a simple key in "<unicode string>", line 13, column 1 could not find expected ':' in "<unicode string>", line 15, column 1 Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/media/rockchip-cif.example.dts' failed make[1]: *** [Documentation/devicetree/bindings/media/rockchip-cif.example.dts] Error 1 make[1]: *** Waiting for unfinished jobs.... warning: no schema found in file: Documentation/devicetree/bindings/media/rockchip-cif.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/rockchip-cif.yaml: ignoring, error parsing file Makefile:1262: recipe for target 'dt_binding_check' failed make: *** [dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1266070 If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/media/rockchip-cif.yaml b/Documentation/devicetree/bindings/media/rockchip-cif.yaml new file mode 100644 index 000000000000..87fb5e136edd --- /dev/null +++ b/Documentation/devicetree/bindings/media/rockchip-cif.yaml @@ -0,0 +1,98 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/rockchip-cif.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Rockchip Camera Interface (CIF) + +maintainers: + - Maxime Chevallier <maxime.chevallier@bootlin.com> + +description: |- +Camera Interface for Rockcip platforms + +properties: + compatible: + const: rockchip,px30-cif + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + items: + - description: ACLK + - description: HCLK + - description: PCLK + - description: CIF_OUT + + clock-names: + items: + - const: aclk_cif + - const: hclk_cif + - const: pclk_cif + - const: cif_out + + resets: + items: + - description: Reset CIF A + - description: Reset CIF H + - description: Reset CIF PCLK IN + + reset-names: + items: + - const: rst_cif_a + - const: rst_cif_h + - const: rst_cif_pclkin + + power-domains: + maxItems: 1 + description: phandle to the associated power domain + + # See ./video-interfaces.txt for details + port: + type: object + additionalProperties: false + + properties: + endpoint: + type: object + + properties: + remote-endpoint: true + + required: + - remote-endpoint + + required: + - endpoint + +required: + - compatible + - reg + - interrupts + - clocks + +additionalProperties: false + +examples: + - | + cif: cif@ff490000 { + compatible = "rockchip,px30-cif"; + reg = <0x0 0xff490000 0x0 0x200>; + interrupts = <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cru ACLK_CIF>, <&cru HCLK_CIF>, <&cru PCLK_CIF>, <&cru SCLK_CIF_OUT>; + clock-names = "aclk_cif", "hclk_cif", "pclk_cif", "cif_out"; + resets = <&cru SRST_CIF_A>, <&cru SRST_CIF_H>, <&cru SRST_CIF_PCLKIN>; + reset-names = "rst_cif_a", "rst_cif_h", "rst_cif_pclkin"; + power-domains = <&power PX30_PD_VI>; + port { + cif_in: endpoint { + remote-endpoint = <&tw9900_out>; + }; + }; + }; +...
Add a documentation for the Rockchip Camera Interface controller binding. This controller can be found on platforms such as the PX30 or the RK3288, the PX30 being the only platform supported so far. Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com> --- .../bindings/media/rockchip-cif.yaml | 98 +++++++++++++++++++ 1 file changed, 98 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/rockchip-cif.yaml