| Message ID | 20200414120238.35704-1-yanaijie@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 8c42c0f72d7c4f295646d3eba73f62e5579b1732 |
| Headers | show |
| Series | clocksource: atmel-st: remove useless 'status' | expand |
On 14/04/2020 20:02:38+0800, Jason Yan wrote: > Fix the following coccicheck warning: > > drivers/clocksource/timer-atmel-st.c:142:6-12: Unneeded variable: > "status". Return "0" on line 166 > > Signed-off-by: Jason Yan <yanaijie@huawei.com> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > --- > drivers/clocksource/timer-atmel-st.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/clocksource/timer-atmel-st.c b/drivers/clocksource/timer-atmel-st.c > index ab0aabfae5f0..73e8aee445da 100644 > --- a/drivers/clocksource/timer-atmel-st.c > +++ b/drivers/clocksource/timer-atmel-st.c > @@ -139,7 +139,6 @@ static int > clkevt32k_next_event(unsigned long delta, struct clock_event_device *dev) > { > u32 alm; > - int status = 0; > unsigned int val; > > BUG_ON(delta < 2); > @@ -163,7 +162,7 @@ clkevt32k_next_event(unsigned long delta, struct clock_event_device *dev) > alm += delta; > regmap_write(regmap_st, AT91_ST_RTAR, alm); > > - return status; > + return 0; > } > > static struct clock_event_device clkevt = { > -- > 2.21.1 >
On 14/04/2020 14:02, Jason Yan wrote: > Fix the following coccicheck warning: > > drivers/clocksource/timer-atmel-st.c:142:6-12: Unneeded variable: > "status". Return "0" on line 166 > > Signed-off-by: Jason Yan <yanaijie@huawei.com> > --- Applied, thanks
diff --git a/drivers/clocksource/timer-atmel-st.c b/drivers/clocksource/timer-atmel-st.c index ab0aabfae5f0..73e8aee445da 100644 --- a/drivers/clocksource/timer-atmel-st.c +++ b/drivers/clocksource/timer-atmel-st.c @@ -139,7 +139,6 @@ static int clkevt32k_next_event(unsigned long delta, struct clock_event_device *dev) { u32 alm; - int status = 0; unsigned int val; BUG_ON(delta < 2); @@ -163,7 +162,7 @@ clkevt32k_next_event(unsigned long delta, struct clock_event_device *dev) alm += delta; regmap_write(regmap_st, AT91_ST_RTAR, alm); - return status; + return 0; } static struct clock_event_device clkevt = {
Fix the following coccicheck warning: drivers/clocksource/timer-atmel-st.c:142:6-12: Unneeded variable: "status". Return "0" on line 166 Signed-off-by: Jason Yan <yanaijie@huawei.com> --- drivers/clocksource/timer-atmel-st.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)