Message ID | ddee231f968fcf8a9558ff39f251fdd7b2357ff2.1586960617.git.mchehab+huawei@kernel.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | fs: convert remaining docs to ReST file format | expand |
On Wed, Apr 15, 2020 at 04:32:35PM +0200, Mauro Carvalho Chehab wrote: > There are two files called "patch-lookup", with different contents: > one is a ReST file, the other one is the text. > > As we'll be finishing the conversion of filesystem documents, > let's fist rename the text one, in order to avoid messing with > the existing ReST file. > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> > --- > .../filesystems/{path-lookup.txt => path-walking.txt} | 0 > Documentation/filesystems/porting.rst | 2 +- > fs/dcache.c | 6 +++--- > fs/namei.c | 2 +- > 4 files changed, 5 insertions(+), 5 deletions(-) > rename Documentation/filesystems/{path-lookup.txt => path-walking.txt} (100%) Wouldn't it make more sense to consolidate path-lookup.rst and path-lookup.txt into one file? The .txt one is less detailed and hasn't been updated since 2011, so maybe it should just be deleted? Perhaps there's something useful in it that should be salvaged, though. - Eric
Em Wed, 15 Apr 2020 19:00:06 -0700 Eric Biggers <ebiggers@kernel.org> escreveu: > On Wed, Apr 15, 2020 at 04:32:35PM +0200, Mauro Carvalho Chehab wrote: > > There are two files called "patch-lookup", with different contents: > > one is a ReST file, the other one is the text. > > > > As we'll be finishing the conversion of filesystem documents, > > let's fist rename the text one, in order to avoid messing with > > the existing ReST file. > > > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> > > --- > > .../filesystems/{path-lookup.txt => path-walking.txt} | 0 > > Documentation/filesystems/porting.rst | 2 +- > > fs/dcache.c | 6 +++--- > > fs/namei.c | 2 +- > > 4 files changed, 5 insertions(+), 5 deletions(-) > > rename Documentation/filesystems/{path-lookup.txt => path-walking.txt} (100%) > > Wouldn't it make more sense to consolidate path-lookup.rst and path-lookup.txt > into one file? The .txt one is less detailed and hasn't been updated since > 2011, so maybe it should just be deleted? Perhaps there's something useful in > it that should be salvaged, though. I'll keep this (and the next patch) on a separate branch. I'll try to take a look on it later and see if I can help checking if there are something there still useful, merging at path-lookup.rst. Thanks, Mauro
diff --git a/Documentation/filesystems/path-lookup.txt b/Documentation/filesystems/path-walking.txt similarity index 100% rename from Documentation/filesystems/path-lookup.txt rename to Documentation/filesystems/path-walking.txt diff --git a/Documentation/filesystems/porting.rst b/Documentation/filesystems/porting.rst index 26c093969573..8f7d25acf326 100644 --- a/Documentation/filesystems/porting.rst +++ b/Documentation/filesystems/porting.rst @@ -404,7 +404,7 @@ the callback. It used to be necessary to clean it there, but not anymore vfs now tries to do path walking in "rcu-walk mode", which avoids atomic operations and scalability hazards on dentries and inodes (see -Documentation/filesystems/path-lookup.txt). d_hash and d_compare changes +Documentation/filesystems/path-walking.txt). d_hash and d_compare changes (above) are examples of the changes required to support this. For more complex filesystem callbacks, the vfs drops out of rcu-walk mode before the fs call, so no changes are required to the filesystem. However, this is costly and loses diff --git a/fs/dcache.c b/fs/dcache.c index b280e07e162b..cf8d5893bd0e 100644 --- a/fs/dcache.c +++ b/fs/dcache.c @@ -2191,7 +2191,7 @@ static inline bool d_same_name(const struct dentry *dentry, * * __d_lookup_rcu is the dcache lookup function for rcu-walk name * resolution (store-free path walking) design described in - * Documentation/filesystems/path-lookup.txt. + * Documentation/filesystems/path-walking.txt. * * This is not to be used outside core vfs. * @@ -2239,7 +2239,7 @@ struct dentry *__d_lookup_rcu(const struct dentry *parent, * false-negative result. d_lookup() protects against concurrent * renames using rename_lock seqlock. * - * See Documentation/filesystems/path-lookup.txt for more details. + * See Documentation/filesystems/path-walking.txt for more details. */ hlist_bl_for_each_entry_rcu(dentry, node, b, d_hash) { unsigned seq; @@ -2362,7 +2362,7 @@ struct dentry *__d_lookup(const struct dentry *parent, const struct qstr *name) * false-negative result. d_lookup() protects against concurrent * renames using rename_lock seqlock. * - * See Documentation/filesystems/path-lookup.txt for more details. + * See Documentation/filesystems/path-walking.txt for more details. */ rcu_read_lock(); diff --git a/fs/namei.c b/fs/namei.c index a320371899cf..d1b53fea83d8 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -645,7 +645,7 @@ static bool legitimize_root(struct nameidata *nd) /* * Path walking has 2 modes, rcu-walk and ref-walk (see - * Documentation/filesystems/path-lookup.txt). In situations when we can't + * Documentation/filesystems/path-walking.txt). In situations when we can't * continue in RCU mode, we attempt to drop out of rcu-walk mode and grab * normal reference counts on dentries and vfsmounts to transition to ref-walk * mode. Refcounts are grabbed at the last known good point before rcu-walk
There are two files called "patch-lookup", with different contents: one is a ReST file, the other one is the text. As we'll be finishing the conversion of filesystem documents, let's fist rename the text one, in order to avoid messing with the existing ReST file. Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> --- .../filesystems/{path-lookup.txt => path-walking.txt} | 0 Documentation/filesystems/porting.rst | 2 +- fs/dcache.c | 6 +++--- fs/namei.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) rename Documentation/filesystems/{path-lookup.txt => path-walking.txt} (100%)