diff mbox series

[1/2] dt-bindings: vendor-prefixes: Add Check Point

Message ID 20200409043851.31217-1-paweldembicki@gmail.com (mailing list archive)
State New, archived
Headers show
Series [1/2] dt-bindings: vendor-prefixes: Add Check Point | expand

Commit Message

Pawel Dembicki April 9, 2020, 4:38 a.m. UTC
Check Point Software Technologies Ltd. is a company based in Israel and
USA. They manufacture network devices and provide software
products for IT security.

Signed-off-by: Pawel Dembicki <paweldembicki@gmail.com>
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Sam Ravnborg April 9, 2020, 6:10 a.m. UTC | #1
Hi Pawel.

On Thu, Apr 09, 2020 at 06:38:46AM +0200, Pawel Dembicki wrote:
> Check Point Software Technologies Ltd. is a company based in Israel and
> USA. They manufacture network devices and provide software
> products for IT security.
> 
> Signed-off-by: Pawel Dembicki <paweldembicki@gmail.com>
> ---
>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index d3891386d671..4033d8b38170 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -182,6 +182,8 @@ patternProperties:
>    "^ceva,.*":
>      description: Ceva, Inc.
>    "^chipidea,.*":
> +    description: Check Point Software Technologies Ltd.
> +  "^checkpoint,.*":
>      description: Chipidea, Inc
>    "^chipone,.*":
>      description: ChipOne

Please fix so the vendor-prefix entries are sorted alphabetically.
And fix so the descriptions comes right *after* the vendor-prefix.
Right now it is inserted wrong.

	Sam
Linus Walleij April 16, 2020, 10:57 a.m. UTC | #2
Hi Pawel,

On Thu, Apr 9, 2020 at 6:39 AM Pawel Dembicki <paweldembicki@gmail.com> wrote:

>    "^ceva,.*":
>      description: Ceva, Inc.
>    "^chipidea,.*":
> +    description: Check Point Software Technologies Ltd.
> +  "^checkpoint,.*":
>      description: Chipidea, Inc
>    "^chipone,.*":
>      description: ChipOne

This is wrong, you inserted your new vendor between the regexp
and description for chipidea and flipped the two lines in your
match.

Yours,
Linus Walleij
Pawel Dembicki April 16, 2020, 11:10 a.m. UTC | #3
On Thu, Apr 16, 2020 at 12:57  Linus Walleij <linus.walleij@linaro.org> wrote:
>
> Hi Pawel,
>

Hi Linus,

> On Thu, Apr 9, 2020 at 6:39 AM Pawel Dembicki <paweldembicki@gmail.com> wrote:
>
> >    "^ceva,.*":
> >      description: Ceva, Inc.
> >    "^chipidea,.*":
> > +    description: Check Point Software Technologies Ltd.
> > +  "^checkpoint,.*":
> >      description: Chipidea, Inc
> >    "^chipone,.*":
> >      description: ChipOne
>
> This is wrong, you inserted your new vendor between the regexp
> and description for chipidea and flipped the two lines in your
> match.

I prepared v2 of my patch and it was merged into next:
https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/commit/?h=dt/next&id=84a25ea9cfd9889acf1e1021cbd835277a1df71e
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index d3891386d671..4033d8b38170 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -182,6 +182,8 @@  patternProperties:
   "^ceva,.*":
     description: Ceva, Inc.
   "^chipidea,.*":
+    description: Check Point Software Technologies Ltd.
+  "^checkpoint,.*":
     description: Chipidea, Inc
   "^chipone,.*":
     description: ChipOne