diff mbox series

ARM: dts: bcm2835-rpi-zero-w: Fix led polarity

Message ID 20200418123522.6390-1-vincent.stehle@laposte.net (mailing list archive)
State Mainlined
Commit 58bb90ab415562eededb932455046924e65df342
Headers show
Series ARM: dts: bcm2835-rpi-zero-w: Fix led polarity | expand

Commit Message

Vincent Stehlé April 18, 2020, 12:35 p.m. UTC
The status "ACT" led on the Raspberry Pi Zero W is on when GPIO 47 is low.

This has been verified on a board and somewhat confirmed by both the GPIO
name ("STATUS_LED_N") and the reduced schematics [1].

[1]: https://www.raspberrypi.org/documentation/hardware/raspberrypi/schematics/rpi_SCH_ZeroW_1p1_reduced.pdf

Fixes: 2c7c040c73e9 ("ARM: dts: bcm2835: Add Raspberry Pi Zero W")
Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
Cc: Stefan Wahren <stefan.wahren@i2se.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>
---
 arch/arm/boot/dts/bcm2835-rpi-zero-w.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stefan Wahren April 19, 2020, 9:06 a.m. UTC | #1
Am 18.04.20 um 14:35 schrieb Vincent Stehlé:
> The status "ACT" led on the Raspberry Pi Zero W is on when GPIO 47 is low.
>
> This has been verified on a board and somewhat confirmed by both the GPIO
> name ("STATUS_LED_N") and the reduced schematics [1].
>
> [1]: https://www.raspberrypi.org/documentation/hardware/raspberrypi/schematics/rpi_SCH_ZeroW_1p1_reduced.pdf
>
> Fixes: 2c7c040c73e9 ("ARM: dts: bcm2835: Add Raspberry Pi Zero W")
> Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
> Cc: Stefan Wahren <stefan.wahren@i2se.com>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> ---

Tested-by: Stefan Wahren <stefan.wahren@i2se.com>

Thanks
Florian Fainelli April 21, 2020, 10:27 p.m. UTC | #2
On Sat, 18 Apr 2020 14:35:22 +0200, Vincent Stehlé <vincent.stehle@laposte.net> wrote:
> The status "ACT" led on the Raspberry Pi Zero W is on when GPIO 47 is low.
> 
> This has been verified on a board and somewhat confirmed by both the GPIO
> name ("STATUS_LED_N") and the reduced schematics [1].
> 
> [1]: https://www.raspberrypi.org/documentation/hardware/raspberrypi/schematics/rpi_SCH_ZeroW_1p1_reduced.pdf
> 
> Fixes: 2c7c040c73e9 ("ARM: dts: bcm2835: Add Raspberry Pi Zero W")
> Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
> Cc: Stefan Wahren <stefan.wahren@i2se.com>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> ---

Applied to devicetree/fixes, thanks!
--
Florian
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/bcm2835-rpi-zero-w.dts b/arch/arm/boot/dts/bcm2835-rpi-zero-w.dts
index 4c3f606e5b8d8..f65448c01e317 100644
--- a/arch/arm/boot/dts/bcm2835-rpi-zero-w.dts
+++ b/arch/arm/boot/dts/bcm2835-rpi-zero-w.dts
@@ -24,7 +24,7 @@  chosen {
 
 	leds {
 		act {
-			gpios = <&gpio 47 GPIO_ACTIVE_HIGH>;
+			gpios = <&gpio 47 GPIO_ACTIVE_LOW>;
 		};
 	};