[0/2] ASoC: rsnd: multi-SSI setup fixes

Message

Matthias Blankertz April 17, 2020, 3:30 p.m. UTC

Fix rsnd_dai_call() operations being performed twice for the master SSI
in multi-SSI setups, and fix the rsnd_ssi_stop operation for multi-SSI
setups.
The only visible effect of these issues was some "status check failed"
spam when the rsnd_ssi_stop was called, but overall the code is cleaner
now, and some questionable writes to the SSICR register which did not
lead to any observable misbehaviour but were contrary to the datasheet
are fixed.

Mark:
The first patch kind of reverts my "ASoC: rsnd: Fix parent SSI
start/stop in multi-SSI mode" from a few days ago and achieves the same
effect in a simpler fashion, if you would prefer a clean patch series
based on v5.6 drop me a note.

Greetings,
	Matthias


Matthias Blankertz (2):
  ASoC: rsnd: Don't treat master SSI in multi SSI setup as parent
  ASoC: rsnd: Fix "status check failed" spam for multi-SSI

 sound/soc/sh/rcar/ssi.c | 18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)

base-commit: 15a5760cb8b6d5c1ebbf1d2e1f0b77380ab68a82

Comments

Kuninori Morimoto April 19, 2020, 11:38 p.m. UTC | #1

Hi Matthias

> Fix rsnd_dai_call() operations being performed twice for the master SSI
> in multi-SSI setups, and fix the rsnd_ssi_stop operation for multi-SSI
> setups.
> The only visible effect of these issues was some "status check failed"
> spam when the rsnd_ssi_stop was called, but overall the code is cleaner
> now, and some questionable writes to the SSICR register which did not
> lead to any observable misbehaviour but were contrary to the datasheet
> are fixed.
> 
> Mark:
> The first patch kind of reverts my "ASoC: rsnd: Fix parent SSI
> start/stop in multi-SSI mode" from a few days ago and achieves the same
> effect in a simpler fashion, if you would prefer a clean patch series
> based on v5.6 drop me a note.

Nice catch !
For all patches

Acked-by: Kuninori Morimoto <[e-mail]>

Thank you for your help !!

Best regards
---
Kuninori Morimoto

Mark Brown April 20, 2020, 1:37 p.m. UTC | #2

On Fri, 17 Apr 2020 17:30:15 +0200, Matthias Blankertz wrote:
> Fix rsnd_dai_call() operations being performed twice for the master SSI
> in multi-SSI setups, and fix the rsnd_ssi_stop operation for multi-SSI
> setups.
> The only visible effect of these issues was some "status check failed"
> spam when the rsnd_ssi_stop was called, but overall the code is cleaner
> now, and some questionable writes to the SSICR register which did not
> lead to any observable misbehaviour but were contrary to the datasheet
> are fixed.
> 
> [...]

Applied to

	broonie/sound.git for-5.7

Thanks!

[1/2] ASoC: rsnd: Don't treat master SSI in multi SSI setup as parent
      commit: 0c258657ddfe81b4fc0183378d800c97ba0b7cdd
[2/2] ASoC: rsnd: Fix "status check failed" spam for multi-SSI
      commit: 54cb6221688660670a2e430892d7f4e6370263b8

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark