| Message ID | 20200419170810.5738-4-robh@kernel.org (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Modularizing Versatile Express | expand |
On Sun, Apr 19, 2020 at 7:08 PM Rob Herring <robh@kernel.org> wrote: > > CONFIG_VEXPRESS_CONFIG has 'default y if ARCH_VEXPRESS', so selecting is > unnecessary. It also prevents setting CONFIG_VEXPRESS_CONFIG to a module. > > Cc: Catalin Marinas <catalin.marinas@arm.com> > Cc: Will Deacon <will@kernel.org> > Cc: Liviu Dudau <liviu.dudau@arm.com> > Cc: Sudeep Holla <sudeep.holla@arm.com> > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Signed-off-by: Rob Herring <robh@kernel.org> > --- > arch/arm64/Kconfig.platforms | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > index 9c084f995e0f..5c38dc56b808 100644 > --- a/arch/arm64/Kconfig.platforms > +++ b/arch/arm64/Kconfig.platforms > @@ -278,7 +278,6 @@ config ARCH_VEXPRESS > select GPIOLIB > select PM > select PM_GENERIC_DOMAINS > - select VEXPRESS_CONFIG > help > This enables support for the ARMv8 software model (Versatile > Express). Nothing wrong with this change, but I'd fold it into the previous patch, as this 'select' was clearly meant to avoid a build failure on the previous one. Arnd
On Sun, Apr 19, 2020 at 12:07:56PM -0500, Rob Herring wrote: > CONFIG_VEXPRESS_CONFIG has 'default y if ARCH_VEXPRESS', so selecting is > unnecessary. It also prevents setting CONFIG_VEXPRESS_CONFIG to a module. > > Cc: Catalin Marinas <catalin.marinas@arm.com> > Cc: Will Deacon <will@kernel.org> > Cc: Liviu Dudau <liviu.dudau@arm.com> > Cc: Sudeep Holla <sudeep.holla@arm.com> Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms index 9c084f995e0f..5c38dc56b808 100644 --- a/arch/arm64/Kconfig.platforms +++ b/arch/arm64/Kconfig.platforms @@ -278,7 +278,6 @@ config ARCH_VEXPRESS select GPIOLIB select PM select PM_GENERIC_DOMAINS - select VEXPRESS_CONFIG help This enables support for the ARMv8 software model (Versatile Express).
CONFIG_VEXPRESS_CONFIG has 'default y if ARCH_VEXPRESS', so selecting is unnecessary. It also prevents setting CONFIG_VEXPRESS_CONFIG to a module. Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: Will Deacon <will@kernel.org> Cc: Liviu Dudau <liviu.dudau@arm.com> Cc: Sudeep Holla <sudeep.holla@arm.com> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Rob Herring <robh@kernel.org> --- arch/arm64/Kconfig.platforms | 1 - 1 file changed, 1 deletion(-)