| Message ID | 20200419170810.5738-9-robh@kernel.org (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Modularizing Versatile Express | expand |
On Sun, Apr 19, 2020 at 7:08 PM Rob Herring <robh@kernel.org> wrote: > > Enable building the vexpress-osc clock driver as a module. > > config CLK_VEXPRESS_OSC > - bool "Clock driver for Versatile Express OSC clock generators" > - depends on VEXPRESS_CONFIG || COMPILE_TEST > + tristate "Clock driver for Versatile Express OSC clock generators" > + depends on VEXPRESS_CONFIG Why do you remove the "|| COMPILE_TEST" here? Arnd
On Mon, Apr 20, 2020 at 10:28 AM Arnd Bergmann <arnd@arndb.de> wrote: > > On Sun, Apr 19, 2020 at 7:08 PM Rob Herring <robh@kernel.org> wrote: > > > > Enable building the vexpress-osc clock driver as a module. > > > > > config CLK_VEXPRESS_OSC > > - bool "Clock driver for Versatile Express OSC clock generators" > > - depends on VEXPRESS_CONFIG || COMPILE_TEST > > + tristate "Clock driver for Versatile Express OSC clock generators" > > + depends on VEXPRESS_CONFIG > > Why do you remove the "|| COMPILE_TEST" here? Looks like a rebasing error. I only added it in patch 5. It has to depend on VEXPRESS_CONFIG because devm_regmap_init_vexpress_config doesn't have an empty function. Rob
On Sun, Apr 19, 2020 at 12:08:01PM -0500, Rob Herring wrote: > Enable building the vexpress-osc clock driver as a module. > > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Liviu Dudau <liviu.dudau@arm.com> > Cc: Sudeep Holla <sudeep.holla@arm.com> > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > Cc: Michael Turquette <mturquette@baylibre.com> > Cc: Stephen Boyd <sboyd@kernel.org> > Cc: linux-clk@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > drivers/clk/versatile/Kconfig | 4 ++-- > drivers/clk/versatile/clk-vexpress-osc.c | 10 ++++------ > 2 files changed, 6 insertions(+), 8 deletions(-) > > diff --git a/drivers/clk/versatile/Kconfig b/drivers/clk/versatile/Kconfig > index 5bdd5c98990b..9de2396dcf9b 100644 > --- a/drivers/clk/versatile/Kconfig > +++ b/drivers/clk/versatile/Kconfig > @@ -15,8 +15,8 @@ config CLK_SP810 > of the ARM SP810 System Controller cell. > > config CLK_VEXPRESS_OSC > - bool "Clock driver for Versatile Express OSC clock generators" > - depends on VEXPRESS_CONFIG || COMPILE_TEST > + tristate "Clock driver for Versatile Express OSC clock generators" > + depends on VEXPRESS_CONFIG Looks good to me with the exception of COMPILE_TEST appearing in patch 5 and disappearing here. Which one should be the one to survive? Best regards, Liviu > default y if ARCH_VEXPRESS > ---help--- > Simple regmap-based driver driving clock generators on Versatile > diff --git a/drivers/clk/versatile/clk-vexpress-osc.c b/drivers/clk/versatile/clk-vexpress-osc.c > index 5bb1d5a714d0..b2b32fa2d7c3 100644 > --- a/drivers/clk/versatile/clk-vexpress-osc.c > +++ b/drivers/clk/versatile/clk-vexpress-osc.c > @@ -7,6 +7,7 @@ > #include <linux/clkdev.h> > #include <linux/clk-provider.h> > #include <linux/err.h> > +#include <linux/module.h> > #include <linux/of.h> > #include <linux/platform_device.h> > #include <linux/slab.h> > @@ -108,6 +109,7 @@ static const struct of_device_id vexpress_osc_of_match[] = { > { .compatible = "arm,vexpress-osc", }, > {} > }; > +MODULE_DEVICE_TABLE(of, vexpress_osc_of_match); > > static struct platform_driver vexpress_osc_driver = { > .driver = { > @@ -116,9 +118,5 @@ static struct platform_driver vexpress_osc_driver = { > }, > .probe = vexpress_osc_probe, > }; > - > -static int __init vexpress_osc_init(void) > -{ > - return platform_driver_register(&vexpress_osc_driver); > -} > -core_initcall(vexpress_osc_init); > +module_platform_driver(vexpress_osc_driver); > +MODULE_LICENSE("GPL v2"); > -- > 2.20.1 >
On Sun, Apr 19, 2020 at 12:08:01PM -0500, Rob Herring wrote: > Enable building the vexpress-osc clock driver as a module. > > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Liviu Dudau <liviu.dudau@arm.com> > Cc: Sudeep Holla <sudeep.holla@arm.com> > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > Cc: Michael Turquette <mturquette@baylibre.com> > Cc: Stephen Boyd <sboyd@kernel.org> > Cc: linux-clk@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > drivers/clk/versatile/Kconfig | 4 ++-- > drivers/clk/versatile/clk-vexpress-osc.c | 10 ++++------ > 2 files changed, 6 insertions(+), 8 deletions(-) > > diff --git a/drivers/clk/versatile/Kconfig b/drivers/clk/versatile/Kconfig > index 5bdd5c98990b..9de2396dcf9b 100644 > --- a/drivers/clk/versatile/Kconfig > +++ b/drivers/clk/versatile/Kconfig > @@ -15,8 +15,8 @@ config CLK_SP810 > of the ARM SP810 System Controller cell. > > config CLK_VEXPRESS_OSC > - bool "Clock driver for Versatile Express OSC clock generators" > - depends on VEXPRESS_CONFIG || COMPILE_TEST > + tristate "Clock driver for Versatile Express OSC clock generators" > + depends on VEXPRESS_CONFIG > default y if ARCH_VEXPRESS > ---help--- > Simple regmap-based driver driving clock generators on Versatile > diff --git a/drivers/clk/versatile/clk-vexpress-osc.c b/drivers/clk/versatile/clk-vexpress-osc.c > index 5bb1d5a714d0..b2b32fa2d7c3 100644 > --- a/drivers/clk/versatile/clk-vexpress-osc.c > +++ b/drivers/clk/versatile/clk-vexpress-osc.c > @@ -7,6 +7,7 @@ > #include <linux/clkdev.h> > #include <linux/clk-provider.h> > #include <linux/err.h> > +#include <linux/module.h> > #include <linux/of.h> > #include <linux/platform_device.h> > #include <linux/slab.h> > @@ -108,6 +109,7 @@ static const struct of_device_id vexpress_osc_of_match[] = { > { .compatible = "arm,vexpress-osc", }, > {} > }; > +MODULE_DEVICE_TABLE(of, vexpress_osc_of_match); > > static struct platform_driver vexpress_osc_driver = { > .driver = { > @@ -116,9 +118,5 @@ static struct platform_driver vexpress_osc_driver = { > }, > .probe = vexpress_osc_probe, > }; > - > -static int __init vexpress_osc_init(void) > -{ > - return platform_driver_register(&vexpress_osc_driver); > -} > -core_initcall(vexpress_osc_init); > +module_platform_driver(vexpress_osc_driver); I am not 100% sure of this. This might break the boot on CA9 and TC2 at-least. There are loads of MB peripherals that need this. This will break the boot. We need to check if all the dependent modules are also at module_initcall level and if they deal with deferred probe correctly. Lot of them are legacy and may happen to be working by carefully initcall level adjustments. I will take a look at it again. I must be able to run and check on TC2 though I seem to have removed the network cable on my TC2 or office n/w is acting crazy. I will check tomorrow again or run w/o network. -- Regards, Sudeep
On Wed, Apr 22, 2020 at 10:08:02PM +0100, Sudeep Holla wrote: > On Sun, Apr 19, 2020 at 12:08:01PM -0500, Rob Herring wrote: > > Enable building the vexpress-osc clock driver as a module. > > > > Cc: Linus Walleij <linus.walleij@linaro.org> > > Cc: Liviu Dudau <liviu.dudau@arm.com> > > Cc: Sudeep Holla <sudeep.holla@arm.com> > > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > > Cc: Michael Turquette <mturquette@baylibre.com> > > Cc: Stephen Boyd <sboyd@kernel.org> > > Cc: linux-clk@vger.kernel.org > > Signed-off-by: Rob Herring <robh@kernel.org> > > --- > > drivers/clk/versatile/Kconfig | 4 ++-- > > drivers/clk/versatile/clk-vexpress-osc.c | 10 ++++------ > > 2 files changed, 6 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/clk/versatile/Kconfig b/drivers/clk/versatile/Kconfig > > index 5bdd5c98990b..9de2396dcf9b 100644 > > --- a/drivers/clk/versatile/Kconfig > > +++ b/drivers/clk/versatile/Kconfig > > @@ -15,8 +15,8 @@ config CLK_SP810 > > of the ARM SP810 System Controller cell. > > > > config CLK_VEXPRESS_OSC > > - bool "Clock driver for Versatile Express OSC clock generators" > > - depends on VEXPRESS_CONFIG || COMPILE_TEST > > + tristate "Clock driver for Versatile Express OSC clock generators" > > + depends on VEXPRESS_CONFIG > > default y if ARCH_VEXPRESS > > ---help--- > > Simple regmap-based driver driving clock generators on Versatile > > diff --git a/drivers/clk/versatile/clk-vexpress-osc.c b/drivers/clk/versatile/clk-vexpress-osc.c > > index 5bb1d5a714d0..b2b32fa2d7c3 100644 > > --- a/drivers/clk/versatile/clk-vexpress-osc.c > > +++ b/drivers/clk/versatile/clk-vexpress-osc.c > > @@ -7,6 +7,7 @@ > > #include <linux/clkdev.h> > > #include <linux/clk-provider.h> > > #include <linux/err.h> > > +#include <linux/module.h> > > #include <linux/of.h> > > #include <linux/platform_device.h> > > #include <linux/slab.h> > > @@ -108,6 +109,7 @@ static const struct of_device_id vexpress_osc_of_match[] = { > > { .compatible = "arm,vexpress-osc", }, > > {} > > }; > > +MODULE_DEVICE_TABLE(of, vexpress_osc_of_match); > > > > static struct platform_driver vexpress_osc_driver = { > > .driver = { > > @@ -116,9 +118,5 @@ static struct platform_driver vexpress_osc_driver = { > > }, > > .probe = vexpress_osc_probe, > > }; > > - > > -static int __init vexpress_osc_init(void) > > -{ > > - return platform_driver_register(&vexpress_osc_driver); > > -} > > -core_initcall(vexpress_osc_init); > > +module_platform_driver(vexpress_osc_driver); > > I am not 100% sure of this. This might break the boot on CA9 and TC2 > at-least. There are loads of MB peripherals that need this. This will > break the boot. We need to check if all the dependent modules are also > at module_initcall level and if they deal with deferred probe correctly. > Lot of them are legacy and may happen to be working by carefully initcall > level adjustments. > OK I managed to try this on my TC2 and it fails to boot. However when I enable earlyprintk as I see no log without it, it boots just fine. I also checked adding initcall_debug and I may be wrong on the dependency part. The modules dependent on vexpress-osc are probed later correctly. This make it more difficult to debug as I don't have any debugger attached at the moment to look at the logbuf when it hangs without earlyprintk. -- Regards, Sudeep
On Thu, Apr 23, 2020 at 8:45 AM Sudeep Holla <sudeep.holla@arm.com> wrote: > > On Wed, Apr 22, 2020 at 10:08:02PM +0100, Sudeep Holla wrote: > > On Sun, Apr 19, 2020 at 12:08:01PM -0500, Rob Herring wrote: > > > Enable building the vexpress-osc clock driver as a module. > > > > > > Cc: Linus Walleij <linus.walleij@linaro.org> > > > Cc: Liviu Dudau <liviu.dudau@arm.com> > > > Cc: Sudeep Holla <sudeep.holla@arm.com> > > > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > > > Cc: Michael Turquette <mturquette@baylibre.com> > > > Cc: Stephen Boyd <sboyd@kernel.org> > > > Cc: linux-clk@vger.kernel.org > > > Signed-off-by: Rob Herring <robh@kernel.org> > > > --- > > > drivers/clk/versatile/Kconfig | 4 ++-- > > > drivers/clk/versatile/clk-vexpress-osc.c | 10 ++++------ > > > 2 files changed, 6 insertions(+), 8 deletions(-) > > > > > > diff --git a/drivers/clk/versatile/Kconfig b/drivers/clk/versatile/Kconfig > > > index 5bdd5c98990b..9de2396dcf9b 100644 > > > --- a/drivers/clk/versatile/Kconfig > > > +++ b/drivers/clk/versatile/Kconfig > > > @@ -15,8 +15,8 @@ config CLK_SP810 > > > of the ARM SP810 System Controller cell. > > > > > > config CLK_VEXPRESS_OSC > > > - bool "Clock driver for Versatile Express OSC clock generators" > > > - depends on VEXPRESS_CONFIG || COMPILE_TEST > > > + tristate "Clock driver for Versatile Express OSC clock generators" > > > + depends on VEXPRESS_CONFIG > > > default y if ARCH_VEXPRESS > > > ---help--- > > > Simple regmap-based driver driving clock generators on Versatile > > > diff --git a/drivers/clk/versatile/clk-vexpress-osc.c b/drivers/clk/versatile/clk-vexpress-osc.c > > > index 5bb1d5a714d0..b2b32fa2d7c3 100644 > > > --- a/drivers/clk/versatile/clk-vexpress-osc.c > > > +++ b/drivers/clk/versatile/clk-vexpress-osc.c > > > @@ -7,6 +7,7 @@ > > > #include <linux/clkdev.h> > > > #include <linux/clk-provider.h> > > > #include <linux/err.h> > > > +#include <linux/module.h> > > > #include <linux/of.h> > > > #include <linux/platform_device.h> > > > #include <linux/slab.h> > > > @@ -108,6 +109,7 @@ static const struct of_device_id vexpress_osc_of_match[] = { > > > { .compatible = "arm,vexpress-osc", }, > > > {} > > > }; > > > +MODULE_DEVICE_TABLE(of, vexpress_osc_of_match); > > > > > > static struct platform_driver vexpress_osc_driver = { > > > .driver = { > > > @@ -116,9 +118,5 @@ static struct platform_driver vexpress_osc_driver = { > > > }, > > > .probe = vexpress_osc_probe, > > > }; > > > - > > > -static int __init vexpress_osc_init(void) > > > -{ > > > - return platform_driver_register(&vexpress_osc_driver); > > > -} > > > -core_initcall(vexpress_osc_init); > > > +module_platform_driver(vexpress_osc_driver); > > > > I am not 100% sure of this. This might break the boot on CA9 and TC2 > > at-least. There are loads of MB peripherals that need this. This will > > break the boot. We need to check if all the dependent modules are also > > at module_initcall level and if they deal with deferred probe correctly. > > Lot of them are legacy and may happen to be working by carefully initcall > > level adjustments. > > > > OK I managed to try this on my TC2 and it fails to boot. However when I > enable earlyprintk as I see no log without it, it boots just fine. Well, the uart clocks for TC2 are all dependent on vexpress-osc. The console setup is going to fail to get the clocks and just fail as there's no deferred probe for consoles. We need some way to retrigger the console matching. > I also checked adding initcall_debug and I may be wrong on the dependency > part. The modules dependent on vexpress-osc are probed later correctly. > > This make it more difficult to debug as I don't have any debugger attached > at the moment to look at the logbuf when it hangs without earlyprintk. > > -- > Regards, > Sudeep
On Thu, Apr 23, 2020 at 10:53:40AM -0500, Rob Herring wrote: > On Thu, Apr 23, 2020 at 8:45 AM Sudeep Holla <sudeep.holla@arm.com> wrote: > > > > On Wed, Apr 22, 2020 at 10:08:02PM +0100, Sudeep Holla wrote: > > > On Sun, Apr 19, 2020 at 12:08:01PM -0500, Rob Herring wrote: > > > > Enable building the vexpress-osc clock driver as a module. > > > > > > > > Cc: Linus Walleij <linus.walleij@linaro.org> > > > > Cc: Liviu Dudau <liviu.dudau@arm.com> > > > > Cc: Sudeep Holla <sudeep.holla@arm.com> > > > > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > > > > Cc: Michael Turquette <mturquette@baylibre.com> > > > > Cc: Stephen Boyd <sboyd@kernel.org> > > > > Cc: linux-clk@vger.kernel.org > > > > Signed-off-by: Rob Herring <robh@kernel.org> > > > > --- > > > > drivers/clk/versatile/Kconfig | 4 ++-- > > > > drivers/clk/versatile/clk-vexpress-osc.c | 10 ++++------ > > > > 2 files changed, 6 insertions(+), 8 deletions(-) > > > > > > > > diff --git a/drivers/clk/versatile/Kconfig b/drivers/clk/versatile/Kconfig > > > > index 5bdd5c98990b..9de2396dcf9b 100644 > > > > --- a/drivers/clk/versatile/Kconfig > > > > +++ b/drivers/clk/versatile/Kconfig > > > > @@ -15,8 +15,8 @@ config CLK_SP810 > > > > of the ARM SP810 System Controller cell. > > > > > > > > config CLK_VEXPRESS_OSC > > > > - bool "Clock driver for Versatile Express OSC clock generators" > > > > - depends on VEXPRESS_CONFIG || COMPILE_TEST > > > > + tristate "Clock driver for Versatile Express OSC clock generators" > > > > + depends on VEXPRESS_CONFIG > > > > default y if ARCH_VEXPRESS > > > > ---help--- > > > > Simple regmap-based driver driving clock generators on Versatile > > > > diff --git a/drivers/clk/versatile/clk-vexpress-osc.c b/drivers/clk/versatile/clk-vexpress-osc.c > > > > index 5bb1d5a714d0..b2b32fa2d7c3 100644 > > > > --- a/drivers/clk/versatile/clk-vexpress-osc.c > > > > +++ b/drivers/clk/versatile/clk-vexpress-osc.c > > > > @@ -7,6 +7,7 @@ > > > > #include <linux/clkdev.h> > > > > #include <linux/clk-provider.h> > > > > #include <linux/err.h> > > > > +#include <linux/module.h> > > > > #include <linux/of.h> > > > > #include <linux/platform_device.h> > > > > #include <linux/slab.h> > > > > @@ -108,6 +109,7 @@ static const struct of_device_id vexpress_osc_of_match[] = { > > > > { .compatible = "arm,vexpress-osc", }, > > > > {} > > > > }; > > > > +MODULE_DEVICE_TABLE(of, vexpress_osc_of_match); > > > > > > > > static struct platform_driver vexpress_osc_driver = { > > > > .driver = { > > > > @@ -116,9 +118,5 @@ static struct platform_driver vexpress_osc_driver = { > > > > }, > > > > .probe = vexpress_osc_probe, > > > > }; > > > > - > > > > -static int __init vexpress_osc_init(void) > > > > -{ > > > > - return platform_driver_register(&vexpress_osc_driver); > > > > -} > > > > -core_initcall(vexpress_osc_init); > > > > +module_platform_driver(vexpress_osc_driver); > > > > > > I am not 100% sure of this. This might break the boot on CA9 and TC2 > > > at-least. There are loads of MB peripherals that need this. This will > > > break the boot. We need to check if all the dependent modules are also > > > at module_initcall level and if they deal with deferred probe correctly. > > > Lot of them are legacy and may happen to be working by carefully initcall > > > level adjustments. > > > > > > > OK I managed to try this on my TC2 and it fails to boot. However when I > > enable earlyprintk as I see no log without it, it boots just fine. > > Well, the uart clocks for TC2 are all dependent on vexpress-osc. The > console setup is going to fail to get the clocks and just fail as > there's no deferred probe for consoles. We need some way to retrigger > the console matching. > Ah right, I didn't bother to look at pl011 as I got it confused with Juno which has on-chip pl011. Sorry I don't know details of how early console hands over to the console. Just wondering how is the dependency resolved when earlyprintk is enabled. The partial log from $ dmesg | grep -i -E "("pl0"|"vexpress"|"console")" below when it boots earlyprintk. I see that console is enabled after vexpress_osc_driver_init is called. --->8 calling vexpress_syscfg_init+0x1/0xe @ 1 initcall vexpress_syscfg_init+0x1/0xe returned 0 after 0 usecs calling vexpress_sysreg_init+0x1/0x48 @ 1 probe of vexpress-syscfg.6.auto returned 1 after 0 usecs initcall vexpress_sysreg_init+0x1/0x48 returned 0 after 0 usecs calling vexpress_config_init+0x1/0xae @ 1 initcall vexpress_config_init+0x1/0xae returned 0 after 0 usecs calling pl011_init+0x1/0x38 @ 1 Serial: AMBA PL011 UART driver initcall pl011_init+0x1/0x38 returned 0 after 9765 usecs calling pl022_init+0x1/0xc @ 1 initcall pl022_init+0x1/0xc returned 0 after 0 usecs calling pl061_gpio_init+0x1/0xc @ 1 initcall pl061_gpio_init+0x1/0xc returned 0 after 31 usecs calling vexpress_osc_driver_init+0x1/0x10 @ 1 initcall vexpress_osc_driver_init+0x1/0x10 returned 0 after 231119 usecs calling vexpress_regulator_driver_init+0x1/0xe @ 1 initcall vexpress_regulator_driver_init+0x1/0xe returned 0 after 114764 usecs calling pl031_driver_init+0x1/0xc @ 1 initcall pl031_driver_init+0x1/0xc returned 0 after 25 usecs calling vexpress_reset_driver_init+0x1/0xe @ 1 initcall vexpress_reset_driver_init+0x1/0xe returned 0 after 594 usecs 1c090000.uart: ttyAMA0 at MMIO 0x1c090000 (irq = 30, base_baud = 0) is a PL011 rev2 printk: console [ttyAMA0] enabled printk: bootconsole [earlycon0] disabled 1c0a0000.uart: ttyAMA1 at MMIO 0x1c0a0000 (irq = 31, base_baud = 0) is a PL011 rev2 1c0b0000.uart: ttyAMA2 at MMIO 0x1c0b0000 (irq = 32, base_baud = 0) is a PL011 rev2 1c0c0000.uart: ttyAMA3 at MMIO 0x1c0c0000 (irq = 33, base_baud = 0) is a PL011 rev2 rtc-pl031 1c170000.rtc: registered as rtc0 rtc-pl031 1c170000.rtc: setting system clock to 2020-04-23T16:54:46 UTC (1587660886) --->8
diff --git a/drivers/clk/versatile/Kconfig b/drivers/clk/versatile/Kconfig index 5bdd5c98990b..9de2396dcf9b 100644 --- a/drivers/clk/versatile/Kconfig +++ b/drivers/clk/versatile/Kconfig @@ -15,8 +15,8 @@ config CLK_SP810 of the ARM SP810 System Controller cell. config CLK_VEXPRESS_OSC - bool "Clock driver for Versatile Express OSC clock generators" - depends on VEXPRESS_CONFIG || COMPILE_TEST + tristate "Clock driver for Versatile Express OSC clock generators" + depends on VEXPRESS_CONFIG default y if ARCH_VEXPRESS ---help--- Simple regmap-based driver driving clock generators on Versatile diff --git a/drivers/clk/versatile/clk-vexpress-osc.c b/drivers/clk/versatile/clk-vexpress-osc.c index 5bb1d5a714d0..b2b32fa2d7c3 100644 --- a/drivers/clk/versatile/clk-vexpress-osc.c +++ b/drivers/clk/versatile/clk-vexpress-osc.c @@ -7,6 +7,7 @@ #include <linux/clkdev.h> #include <linux/clk-provider.h> #include <linux/err.h> +#include <linux/module.h> #include <linux/of.h> #include <linux/platform_device.h> #include <linux/slab.h> @@ -108,6 +109,7 @@ static const struct of_device_id vexpress_osc_of_match[] = { { .compatible = "arm,vexpress-osc", }, {} }; +MODULE_DEVICE_TABLE(of, vexpress_osc_of_match); static struct platform_driver vexpress_osc_driver = { .driver = { @@ -116,9 +118,5 @@ static struct platform_driver vexpress_osc_driver = { }, .probe = vexpress_osc_probe, }; - -static int __init vexpress_osc_init(void) -{ - return platform_driver_register(&vexpress_osc_driver); -} -core_initcall(vexpress_osc_init); +module_platform_driver(vexpress_osc_driver); +MODULE_LICENSE("GPL v2");
Enable building the vexpress-osc clock driver as a module. Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Liviu Dudau <liviu.dudau@arm.com> Cc: Sudeep Holla <sudeep.holla@arm.com> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: Michael Turquette <mturquette@baylibre.com> Cc: Stephen Boyd <sboyd@kernel.org> Cc: linux-clk@vger.kernel.org Signed-off-by: Rob Herring <robh@kernel.org> --- drivers/clk/versatile/Kconfig | 4 ++-- drivers/clk/versatile/clk-vexpress-osc.c | 10 ++++------ 2 files changed, 6 insertions(+), 8 deletions(-)