| Message ID | 20200411033824.19389-1-chen.zhang@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | net/colo-compare.c: Expose "max_queue_size" to users and clean up | expand |
Hi Jason, Please review this series when you free. Thanks Zhang Chen > -----Original Message----- > From: Zhang, Chen <chen.zhang@intel.com> > Sent: Saturday, April 11, 2020 11:38 AM > To: Jason Wang <jasowang@redhat.com>; qemu-dev <qemu- > devel@nongnu.org> > Cc: Zhang Chen <zhangckid@gmail.com>; Zhang, Chen > <chen.zhang@intel.com> > Subject: [PATCH 0/2] net/colo-compare.c: Expose "max_queue_size" to > users and clean up > > From: Zhang Chen <chen.zhang@intel.com> > > This series make a way to config COLO "max_queue_size" parameters > according to user's scenarios and environments and do some clean up for > descriptions. > > Zhang Chen (2): > net/colo-compare.c: Expose compare "max_queue_size" to users > qemu-options.hx: Clean up and fix typo for colo-compare > > net/colo-compare.c | 43 > ++++++++++++++++++++++++++++++++++++++++++- > qemu-options.hx | 33 +++++++++++++++++---------------- > 2 files changed, 59 insertions(+), 17 deletions(-) > > -- > 2.17.1
On 2020/4/23 下午3:31, Zhang, Chen wrote: > Hi Jason, > > Please review this series when you free. > > Thanks > Zhang Chen > Sure. I wonder maybe it's better e.g you can review and collect the patches that looks good and send them to me periodically? Thanks
> -----Original Message----- > From: Jason Wang <jasowang@redhat.com> > Sent: Thursday, April 23, 2020 4:54 PM > To: Zhang, Chen <chen.zhang@intel.com>; qemu-dev <qemu- > devel@nongnu.org> > Cc: Zhang Chen <zhangckid@gmail.com> > Subject: Re: [PATCH 0/2] net/colo-compare.c: Expose "max_queue_size" to > users and clean up > > > On 2020/4/23 下午3:31, Zhang, Chen wrote: > > Hi Jason, > > > > Please review this series when you free. > > > > Thanks > > Zhang Chen > > > > Sure. > > I wonder maybe it's better e.g you can review and collect the patches that > looks good and send them to me periodically? OK, I will queue COLO related patch as one series to you. Do I need send a pull request? or just a big patch set? Thanks Zhang Chen > > Thanks
On 2020/4/23 下午4:59, Zhang, Chen wrote: > >> -----Original Message----- >> From: Jason Wang <jasowang@redhat.com> >> Sent: Thursday, April 23, 2020 4:54 PM >> To: Zhang, Chen <chen.zhang@intel.com>; qemu-dev <qemu- >> devel@nongnu.org> >> Cc: Zhang Chen <zhangckid@gmail.com> >> Subject: Re: [PATCH 0/2] net/colo-compare.c: Expose "max_queue_size" to >> users and clean up >> >> >> On 2020/4/23 下午3:31, Zhang, Chen wrote: >>> Hi Jason, >>> >>> Please review this series when you free. >>> >>> Thanks >>> Zhang Chen >>> >> Sure. >> >> I wonder maybe it's better e.g you can review and collect the patches that >> looks good and send them to me periodically? > OK, I will queue COLO related patch as one series to you. > Do I need send a pull request? or just a big patch set? I prefer big patch set. Thanks > > Thanks > Zhang Chen > >> Thanks
> -----Original Message----- > From: Jason Wang <jasowang@redhat.com> > Sent: Thursday, April 23, 2020 5:07 PM > To: Zhang, Chen <chen.zhang@intel.com>; qemu-dev <qemu- > devel@nongnu.org> > Cc: Zhang Chen <zhangckid@gmail.com> > Subject: Re: [PATCH 0/2] net/colo-compare.c: Expose "max_queue_size" to > users and clean up > > > On 2020/4/23 下午4:59, Zhang, Chen wrote: > > > >> -----Original Message----- > >> From: Jason Wang <jasowang@redhat.com> > >> Sent: Thursday, April 23, 2020 4:54 PM > >> To: Zhang, Chen <chen.zhang@intel.com>; qemu-dev <qemu- > >> devel@nongnu.org> > >> Cc: Zhang Chen <zhangckid@gmail.com> > >> Subject: Re: [PATCH 0/2] net/colo-compare.c: Expose "max_queue_size" > >> to users and clean up > >> > >> > >> On 2020/4/23 下午3:31, Zhang, Chen wrote: > >>> Hi Jason, > >>> > >>> Please review this series when you free. > >>> > >>> Thanks > >>> Zhang Chen > >>> > >> Sure. > >> > >> I wonder maybe it's better e.g you can review and collect the patches > >> that looks good and send them to me periodically? > > OK, I will queue COLO related patch as one series to you. > > Do I need send a pull request? or just a big patch set? > > > I prefer big patch set. OK, I got it. Thanks Zhang Chen > > Thanks > > > > > > Thanks > > Zhang Chen > > > >> Thanks
On 2020/4/11 上午11:38, Zhang Chen wrote: > From: Zhang Chen <chen.zhang@intel.com> > > This series make a way to config COLO "max_queue_size" parameters according to > user's scenarios and environments and do some clean up for descriptions. > > Zhang Chen (2): > net/colo-compare.c: Expose compare "max_queue_size" to users > qemu-options.hx: Clean up and fix typo for colo-compare > > net/colo-compare.c | 43 ++++++++++++++++++++++++++++++++++++++++++- > qemu-options.hx | 33 +++++++++++++++++---------------- > 2 files changed, 59 insertions(+), 17 deletions(-) Queued for 5.1. Thanks
On Fri, 24 Apr 2020 10:19:48 +0800 Jason Wang <jasowang@redhat.com> wrote: > On 2020/4/11 上午11:38, Zhang Chen wrote: > > From: Zhang Chen <chen.zhang@intel.com> > > > > This series make a way to config COLO "max_queue_size" parameters according to > > user's scenarios and environments and do some clean up for descriptions. > > > > Zhang Chen (2): > > net/colo-compare.c: Expose compare "max_queue_size" to users > > qemu-options.hx: Clean up and fix typo for colo-compare > > > > net/colo-compare.c | 43 ++++++++++++++++++++++++++++++++++++++++++- > > qemu-options.hx | 33 +++++++++++++++++---------------- > > 2 files changed, 59 insertions(+), 17 deletions(-) > > > Queued for 5.1. > > Thanks > > Hi, It looks like this hasn't been merged. Regards, Lukas Straub
> -----Original Message----- > From: Lukas Straub <lukasstraub2@web.de> > Sent: Saturday, June 20, 2020 1:47 AM > To: Jason Wang <jasowang@redhat.com> > Cc: Zhang, Chen <chen.zhang@intel.com>; qemu-dev <qemu- > devel@nongnu.org>; Zhang Chen <zhangckid@gmail.com> > Subject: Re: [PATCH 0/2] net/colo-compare.c: Expose "max_queue_size" to > users and clean up > > On Fri, 24 Apr 2020 10:19:48 +0800 > Jason Wang <jasowang@redhat.com> wrote: > > > On 2020/4/11 上午11:38, Zhang Chen wrote: > > > From: Zhang Chen <chen.zhang@intel.com> > > > > > > This series make a way to config COLO "max_queue_size" parameters > > > according to user's scenarios and environments and do some clean up for > descriptions. > > > > > > Zhang Chen (2): > > > net/colo-compare.c: Expose compare "max_queue_size" to users > > > qemu-options.hx: Clean up and fix typo for colo-compare > > > > > > net/colo-compare.c | 43 > ++++++++++++++++++++++++++++++++++++++++++- > > > qemu-options.hx | 33 +++++++++++++++++---------------- > > > 2 files changed, 59 insertions(+), 17 deletions(-) > > > > > > Queued for 5.1. > > > > Thanks > > > > > > Hi, > It looks like this hasn't been merged. Thanks Lukas. Hi Jason, I have double checked on upstream, looks missed this series. Thanks Zhang Chen > > Regards, > Lukas Straub
On 2020/6/23 上午9:47, Zhang, Chen wrote: > >> -----Original Message----- >> From: Lukas Straub <lukasstraub2@web.de> >> Sent: Saturday, June 20, 2020 1:47 AM >> To: Jason Wang <jasowang@redhat.com> >> Cc: Zhang, Chen <chen.zhang@intel.com>; qemu-dev <qemu- >> devel@nongnu.org>; Zhang Chen <zhangckid@gmail.com> >> Subject: Re: [PATCH 0/2] net/colo-compare.c: Expose "max_queue_size" to >> users and clean up >> >> On Fri, 24 Apr 2020 10:19:48 +0800 >> Jason Wang <jasowang@redhat.com> wrote: >> >>> On 2020/4/11 上午11:38, Zhang Chen wrote: >>>> From: Zhang Chen <chen.zhang@intel.com> >>>> >>>> This series make a way to config COLO "max_queue_size" parameters >>>> according to user's scenarios and environments and do some clean up for >> descriptions. >>>> Zhang Chen (2): >>>> net/colo-compare.c: Expose compare "max_queue_size" to users >>>> qemu-options.hx: Clean up and fix typo for colo-compare >>>> >>>> net/colo-compare.c | 43 >> ++++++++++++++++++++++++++++++++++++++++++- >>>> qemu-options.hx | 33 +++++++++++++++++---------------- >>>> 2 files changed, 59 insertions(+), 17 deletions(-) >>> >>> Queued for 5.1. >>> >>> Thanks >>> >>> >> Hi, >> It looks like this hasn't been merged. > Thanks Lukas. > Hi Jason, I have double checked on upstream, looks missed this series. > > Thanks > Zhang Chen Right, but unfortunately it can't be applied cleanly on master. Please send a new version. Sorry. Thanks > >> Regards, >> Lukas Straub
> -----Original Message----- > From: Jason Wang <jasowang@redhat.com> > Sent: Tuesday, June 23, 2020 1:54 PM > To: Zhang, Chen <chen.zhang@intel.com>; Lukas Straub > <lukasstraub2@web.de> > Cc: qemu-dev <qemu-devel@nongnu.org>; Zhang Chen > <zhangckid@gmail.com> > Subject: Re: [PATCH 0/2] net/colo-compare.c: Expose "max_queue_size" to > users and clean up > > > On 2020/6/23 上午9:47, Zhang, Chen wrote: > > > >> -----Original Message----- > >> From: Lukas Straub <lukasstraub2@web.de> > >> Sent: Saturday, June 20, 2020 1:47 AM > >> To: Jason Wang <jasowang@redhat.com> > >> Cc: Zhang, Chen <chen.zhang@intel.com>; qemu-dev <qemu- > >> devel@nongnu.org>; Zhang Chen <zhangckid@gmail.com> > >> Subject: Re: [PATCH 0/2] net/colo-compare.c: Expose "max_queue_size" > >> to users and clean up > >> > >> On Fri, 24 Apr 2020 10:19:48 +0800 > >> Jason Wang <jasowang@redhat.com> wrote: > >> > >>> On 2020/4/11 上午11:38, Zhang Chen wrote: > >>>> From: Zhang Chen <chen.zhang@intel.com> > >>>> > >>>> This series make a way to config COLO "max_queue_size" parameters > >>>> according to user's scenarios and environments and do some clean up > >>>> for > >> descriptions. > >>>> Zhang Chen (2): > >>>> net/colo-compare.c: Expose compare "max_queue_size" to users > >>>> qemu-options.hx: Clean up and fix typo for colo-compare > >>>> > >>>> net/colo-compare.c | 43 > >> ++++++++++++++++++++++++++++++++++++++++++- > >>>> qemu-options.hx | 33 +++++++++++++++++---------------- > >>>> 2 files changed, 59 insertions(+), 17 deletions(-) > >>> > >>> Queued for 5.1. > >>> > >>> Thanks > >>> > >>> > >> Hi, > >> It looks like this hasn't been merged. > > Thanks Lukas. > > Hi Jason, I have double checked on upstream, looks missed this series. > > > > Thanks > > Zhang Chen > > > Right, but unfortunately it can't be applied cleanly on master. > > Please send a new version. > > Sorry. It's OK, I have send V2 version of this series, please merge it. Thanks Zhang Chen > > Thanks > > > > > >> Regards, > >> Lukas Straub
From: Zhang Chen <chen.zhang@intel.com> This series make a way to config COLO "max_queue_size" parameters according to user's scenarios and environments and do some clean up for descriptions. Zhang Chen (2): net/colo-compare.c: Expose compare "max_queue_size" to users qemu-options.hx: Clean up and fix typo for colo-compare net/colo-compare.c | 43 ++++++++++++++++++++++++++++++++++++++++++- qemu-options.hx | 33 +++++++++++++++++---------------- 2 files changed, 59 insertions(+), 17 deletions(-)