diff mbox series

[3/5] generic/570: don't run this test on systems supporting userspace hibernate

Message ID 158768469040.3019327.7570482503352003021.stgit@magnolia (mailing list archive)
State Accepted
Headers show
Series fstests: random fixes | expand

Commit Message

Darrick J. Wong April 23, 2020, 11:31 p.m. UTC 
From: Darrick J. Wong <darrick.wong@oracle.com>

It turns out that userspace actually does need the ability to write to
an active swapfile if userspace hibernation (uswsusp) is enabled.
Therefore, this test doesn't apply under those conditions.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 tests/generic/570 |    1 +
 1 file changed, 1 insertion(+)

Comments

Christoph Hellwig April 24, 2020, 6:22 a.m. UTC | #1 
On Thu, Apr 23, 2020 at 04:31:30PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> It turns out that userspace actually does need the ability to write to
> an active swapfile if userspace hibernation (uswsusp) is enabled.
> Therefore, this test doesn't apply under those conditions.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

Looks good and fixes the spurious failures I'm seeing:

Reviewed-by: Christoph Hellwig <hch@lst.de>
diff mbox series

Patch

diff --git a/tests/generic/570 b/tests/generic/570
index d574f4b7..e5da2381 100755
--- a/tests/generic/570
+++ b/tests/generic/570
@@ -32,6 +32,7 @@  _supported_fs generic
 _require_test_program swapon
 _require_scratch_nocheck
 _require_block_device $SCRATCH_DEV
+test -e /dev/snapshot && _notrun "userspace hibernation to swap is enabled"
 
 rm -f $seqres.full