mbox series

[v2,00/10] drm/lima: add suspend/resume support

Message ID 20200421133551.31481-1-yuq825@gmail.com (mailing list archive)
Headers show
Series drm/lima: add suspend/resume support | expand

Message

Qiang Yu April 21, 2020, 1:35 p.m. UTC 
Suspend need to wait running jobs finish and put hardware in
poweroff state. Resume need to re-init hardware.

v2:
1. add misc patches to prepare enable runtime pm
2. fix pmu command wait time out on mali400 gpu
3. do power and clock gating when suspend
4. do runtime pm

Qiang Yu (10):
  drm/lima: use module_platform_driver helper
  drm/lima: print process name and pid when task error
  drm/lima: check vm != NULL in lima_vm_put
  drm/lima: always set page directory when switch vm
  drm/lima: add lima_devfreq_resume/suspend
  drm/lima: power down ip blocks when pmu exit
  drm/lima: add resume/suspend callback for each ip
  drm/lima: seperate clk/regulator enable/disable function
  drm/lima: add pm resume/suspend ops
  drm/lima: enable runtime pm

 drivers/gpu/drm/lima/lima_bcast.c    |  25 +++-
 drivers/gpu/drm/lima/lima_bcast.h    |   2 +
 drivers/gpu/drm/lima/lima_devfreq.c  |  24 ++++
 drivers/gpu/drm/lima/lima_devfreq.h  |   3 +
 drivers/gpu/drm/lima/lima_device.c   | 199 ++++++++++++++++++++++-----
 drivers/gpu/drm/lima/lima_device.h   |   5 +
 drivers/gpu/drm/lima/lima_dlbu.c     |  17 ++-
 drivers/gpu/drm/lima/lima_dlbu.h     |   2 +
 drivers/gpu/drm/lima/lima_drv.c      |  40 +++---
 drivers/gpu/drm/lima/lima_gp.c       |  21 ++-
 drivers/gpu/drm/lima/lima_gp.h       |   2 +
 drivers/gpu/drm/lima/lima_l2_cache.c |  37 +++--
 drivers/gpu/drm/lima/lima_l2_cache.h |   2 +
 drivers/gpu/drm/lima/lima_mmu.c      |  48 +++++--
 drivers/gpu/drm/lima/lima_mmu.h      |   2 +
 drivers/gpu/drm/lima/lima_pmu.c      |  77 ++++++++++-
 drivers/gpu/drm/lima/lima_pmu.h      |   2 +
 drivers/gpu/drm/lima/lima_pp.c       |  31 ++++-
 drivers/gpu/drm/lima/lima_pp.h       |   4 +
 drivers/gpu/drm/lima/lima_sched.c    |  63 ++++++---
 drivers/gpu/drm/lima/lima_vm.h       |   3 +-
 21 files changed, 496 insertions(+), 113 deletions(-)

Comments

Vasily Khoruzhick April 22, 2020, 5:51 a.m. UTC | #1 
On Tue, Apr 21, 2020 at 6:37 AM Qiang Yu <yuq825@gmail.com> wrote:
>
> Suspend need to wait running jobs finish and put hardware in
> poweroff state. Resume need to re-init hardware.
>
> v2:
> 1. add misc patches to prepare enable runtime pm
> 2. fix pmu command wait time out on mali400 gpu
> 3. do power and clock gating when suspend
> 4. do runtime pm
>
> Qiang Yu (10):
>   drm/lima: use module_platform_driver helper
>   drm/lima: print process name and pid when task error
>   drm/lima: check vm != NULL in lima_vm_put
>   drm/lima: always set page directory when switch vm
>   drm/lima: add lima_devfreq_resume/suspend
>   drm/lima: power down ip blocks when pmu exit
>   drm/lima: add resume/suspend callback for each ip
>   drm/lima: seperate clk/regulator enable/disable function

s/seperate/separate

I guess you can fix it before merging into drm-misc-next, no need to
respin whole patchset

>   drm/lima: add pm resume/suspend ops
>   drm/lima: enable runtime pm

Besides that, series is:

Reviewed-by: Vasily Khoruzhick <anarsoul@gmail.com>

>  drivers/gpu/drm/lima/lima_bcast.c    |  25 +++-
>  drivers/gpu/drm/lima/lima_bcast.h    |   2 +
>  drivers/gpu/drm/lima/lima_devfreq.c  |  24 ++++
>  drivers/gpu/drm/lima/lima_devfreq.h  |   3 +
>  drivers/gpu/drm/lima/lima_device.c   | 199 ++++++++++++++++++++++-----
>  drivers/gpu/drm/lima/lima_device.h   |   5 +
>  drivers/gpu/drm/lima/lima_dlbu.c     |  17 ++-
>  drivers/gpu/drm/lima/lima_dlbu.h     |   2 +
>  drivers/gpu/drm/lima/lima_drv.c      |  40 +++---
>  drivers/gpu/drm/lima/lima_gp.c       |  21 ++-
>  drivers/gpu/drm/lima/lima_gp.h       |   2 +
>  drivers/gpu/drm/lima/lima_l2_cache.c |  37 +++--
>  drivers/gpu/drm/lima/lima_l2_cache.h |   2 +
>  drivers/gpu/drm/lima/lima_mmu.c      |  48 +++++--
>  drivers/gpu/drm/lima/lima_mmu.h      |   2 +
>  drivers/gpu/drm/lima/lima_pmu.c      |  77 ++++++++++-
>  drivers/gpu/drm/lima/lima_pmu.h      |   2 +
>  drivers/gpu/drm/lima/lima_pp.c       |  31 ++++-
>  drivers/gpu/drm/lima/lima_pp.h       |   4 +
>  drivers/gpu/drm/lima/lima_sched.c    |  63 ++++++---
>  drivers/gpu/drm/lima/lima_vm.h       |   3 +-
>  21 files changed, 496 insertions(+), 113 deletions(-)
>
> --
> 2.17.1
>
Qiang Yu April 24, 2020, 1:06 p.m. UTC | #2 
Thanks, fix and applied to drm-misc-next.

Regards,
Qiang

On Wed, Apr 22, 2020 at 1:51 PM Vasily Khoruzhick <anarsoul@gmail.com> wrote:
>
> On Tue, Apr 21, 2020 at 6:37 AM Qiang Yu <yuq825@gmail.com> wrote:
> >
> > Suspend need to wait running jobs finish and put hardware in
> > poweroff state. Resume need to re-init hardware.
> >
> > v2:
> > 1. add misc patches to prepare enable runtime pm
> > 2. fix pmu command wait time out on mali400 gpu
> > 3. do power and clock gating when suspend
> > 4. do runtime pm
> >
> > Qiang Yu (10):
> >   drm/lima: use module_platform_driver helper
> >   drm/lima: print process name and pid when task error
> >   drm/lima: check vm != NULL in lima_vm_put
> >   drm/lima: always set page directory when switch vm
> >   drm/lima: add lima_devfreq_resume/suspend
> >   drm/lima: power down ip blocks when pmu exit
> >   drm/lima: add resume/suspend callback for each ip
> >   drm/lima: seperate clk/regulator enable/disable function
>
> s/seperate/separate
>
> I guess you can fix it before merging into drm-misc-next, no need to
> respin whole patchset
>
> >   drm/lima: add pm resume/suspend ops
> >   drm/lima: enable runtime pm
>
> Besides that, series is:
>
> Reviewed-by: Vasily Khoruzhick <anarsoul@gmail.com>
>
> >  drivers/gpu/drm/lima/lima_bcast.c    |  25 +++-
> >  drivers/gpu/drm/lima/lima_bcast.h    |   2 +
> >  drivers/gpu/drm/lima/lima_devfreq.c  |  24 ++++
> >  drivers/gpu/drm/lima/lima_devfreq.h  |   3 +
> >  drivers/gpu/drm/lima/lima_device.c   | 199 ++++++++++++++++++++++-----
> >  drivers/gpu/drm/lima/lima_device.h   |   5 +
> >  drivers/gpu/drm/lima/lima_dlbu.c     |  17 ++-
> >  drivers/gpu/drm/lima/lima_dlbu.h     |   2 +
> >  drivers/gpu/drm/lima/lima_drv.c      |  40 +++---
> >  drivers/gpu/drm/lima/lima_gp.c       |  21 ++-
> >  drivers/gpu/drm/lima/lima_gp.h       |   2 +
> >  drivers/gpu/drm/lima/lima_l2_cache.c |  37 +++--
> >  drivers/gpu/drm/lima/lima_l2_cache.h |   2 +
> >  drivers/gpu/drm/lima/lima_mmu.c      |  48 +++++--
> >  drivers/gpu/drm/lima/lima_mmu.h      |   2 +
> >  drivers/gpu/drm/lima/lima_pmu.c      |  77 ++++++++++-
> >  drivers/gpu/drm/lima/lima_pmu.h      |   2 +
> >  drivers/gpu/drm/lima/lima_pp.c       |  31 ++++-
> >  drivers/gpu/drm/lima/lima_pp.h       |   4 +
> >  drivers/gpu/drm/lima/lima_sched.c    |  63 ++++++---
> >  drivers/gpu/drm/lima/lima_vm.h       |   3 +-
> >  21 files changed, 496 insertions(+), 113 deletions(-)
> >
> > --
> > 2.17.1
> >