Test patch: build fail

Commit Message

Tedd Ho-Jeong An April 24, 2020, 11:10 p.m. UTC

DO NOT MERGE
---
 tools/btpclient.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

[e-mail] April 25, 2020, 2:36 a.m. UTC | #1

This is automated email and please do not replay to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
While we are preparing for reviewing the patches, we found the following
issue/warning.


Test Result:
Checkbuild Failed

Patch Series:
Test patch: build fail


Outputs:
ar: `u' modifier ignored since `D' is the default (see `U')
ar: `u' modifier ignored since `D' is the default (see `U')
ar: `u' modifier ignored since `D' is the default (see `U')
ar: `u' modifier ignored since `D' is the default (see `U')
ar: `u' modifier ignored since `D' is the default (see `U')
tools/btpclient.c: In function ‘main’:
tools/btpclient.c:3218:15: error: expected ‘;’ before ‘return’
 3218 |  l_main_exit()
      |               ^
      |               ;
 3219 | 
 3220 |  return EXIT_SUCCESS;
      |  ~~~~~~        
make[1]: *** [Makefile:6791: tools/btpclient.o] Error 1
make: *** [Makefile:4010: all] Error 2



---
Regards,
Linux Bluetooth

Luiz Augusto von Dentz April 27, 2020, 4:30 p.m. UTC | #2

Hi Tedd,

On Fri, Apr 24, 2020 at 7:38 PM <[e-mail]> wrote:
>
>
> This is automated email and please do not replay to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> While we are preparing for reviewing the patches, we found the following
> issue/warning.
>
>
> Test Result:
> Checkbuild Failed
>
> Patch Series:
> Test patch: build fail
>
>
> Outputs:
> ar: `u' modifier ignored since `D' is the default (see `U')
> ar: `u' modifier ignored since `D' is the default (see `U')
> ar: `u' modifier ignored since `D' is the default (see `U')
> ar: `u' modifier ignored since `D' is the default (see `U')
> ar: `u' modifier ignored since `D' is the default (see `U')
> tools/btpclient.c: In function ‘main’:
> tools/btpclient.c:3218:15: error: expected ‘;’ before ‘return’
>  3218 |  l_main_exit()
>       |               ^
>       |               ;
>  3219 |
>  3220 |  return EXIT_SUCCESS;
>       |  ~~~~~~
> make[1]: *** [Makefile:6791: tools/btpclient.o] Error 1
> make: *** [Makefile:4010: all] Error 2

Nice, really cool that we finally have a CI working.

Patch

diff --git a/tools/btpclient.c b/tools/btpclient.c
index f9c693056..04c83f6ae 100644
--- a/tools/btpclient.c
+++ b/tools/btpclient.c
@@ -3215,7 +3215,7 @@  int main(int argc, char *argv[])
 
 	l_free(socket_path);
 
-	l_main_exit();
+	l_main_exit()
 
 	return EXIT_SUCCESS;
 }