diff mbox series

pinctrl: nomadik: ab8505: remove unused 'gpio50_a_1_pins'

Message ID 20200417073455.42146-1-yanaijie@huawei.com (mailing list archive)
State New, archived
Headers show
Series pinctrl: nomadik: ab8505: remove unused 'gpio50_a_1_pins' | expand

Commit Message

Jason Yan April 17, 2020, 7:34 a.m. UTC
Fix the following gcc warning:

drivers/pinctrl/nomadik/pinctrl-ab8505.c:137:23: warning:
‘gpio50_a_1_pins’ defined but not used [-Wunused-const-variable=]
 static const unsigned gpio50_a_1_pins[] = { AB8505_PIN_L4 };
                       ^~~~~~~~~~~~~~~

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
 drivers/pinctrl/nomadik/pinctrl-ab8505.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Linus Walleij April 28, 2020, 9:41 a.m. UTC | #1
On Fri, Apr 17, 2020 at 9:08 AM Jason Yan <yanaijie@huawei.com> wrote:

> Fix the following gcc warning:
>
> drivers/pinctrl/nomadik/pinctrl-ab8505.c:137:23: warning:
> ‘gpio50_a_1_pins’ defined but not used [-Wunused-const-variable=]
>  static const unsigned gpio50_a_1_pins[] = { AB8505_PIN_L4 };
>                        ^~~~~~~~~~~~~~~
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>

This should not be deleted, it should be used. I will send an alternative
patch with you as Reported-by.

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/drivers/pinctrl/nomadik/pinctrl-ab8505.c b/drivers/pinctrl/nomadik/pinctrl-ab8505.c
index 5e6e7d28390a..ed23f1274709 100644
--- a/drivers/pinctrl/nomadik/pinctrl-ab8505.c
+++ b/drivers/pinctrl/nomadik/pinctrl-ab8505.c
@@ -134,7 +134,6 @@  static const unsigned gpio34_a_1_pins[] = { AB8505_PIN_H14 };
 static const unsigned gpio40_a_1_pins[] = { AB8505_PIN_J15 };
 static const unsigned gpio41_a_1_pins[] = { AB8505_PIN_J14 };
 static const unsigned uartrxdata_a_1_pins[] = { AB8505_PIN_J14 };
-static const unsigned gpio50_a_1_pins[] = { AB8505_PIN_L4 };
 static const unsigned gpio52_a_1_pins[] = { AB8505_PIN_D16 };
 static const unsigned gpio53_a_1_pins[] = { AB8505_PIN_D15 };