diff mbox

ARM: tegra: Add missing include of linux/erron.h and linux/types.h

Message ID 1313471744.5824.2.camel@phoenix (mailing list archive)
State New, archived
Headers show

Commit Message

axel lin Aug. 16, 2011, 5:15 a.m. UTC
Include linux/erron.h to fix below build error.

  CC      arch/arm/mach-tegra/board-harmony-pinmux.o
In file included from /home/axel/repos/git/linux-2.6/arch/arm/include/asm/gpio.h:5,
                 from include/linux/gpio.h:18,
                 from arch/arm/mach-tegra/board-harmony-pinmux.c:18:
arch/arm/mach-tegra/include/mach/gpio.h: In function 'gpio_to_irq':
arch/arm/mach-tegra/include/mach/gpio.h:35: error: 'EINVAL' undeclared (first use in this function)
arch/arm/mach-tegra/include/mach/gpio.h:35: error: (Each undeclared identifier is reported only once
arch/arm/mach-tegra/include/mach/gpio.h:35: error: for each function it appears in.)
arch/arm/mach-tegra/include/mach/gpio.h: In function 'irq_to_gpio':
arch/arm/mach-tegra/include/mach/gpio.h:43: error: 'EINVAL' undeclared (first use in this function)
make[1]: *** [arch/arm/mach-tegra/board-harmony-pinmux.o] Error 1
make: *** [arch/arm/mach-tegra] Error 2

Include linux/types.h to fix below build error.

  CC      arch/arm/mach-tegra/board-trimslice-pinmux.o
In file included from /home/axel/repos/git/linux-2.6/arch/arm/include/asm/gpio.h:5,
                 from include/linux/gpio.h:18,
                 from arch/arm/mach-tegra/board-trimslice-pinmux.c:16:
arch/arm/mach-tegra/include/mach/gpio.h:49: error: expected specifier-qualifier-list before 'bool'
arch/arm/mach-tegra/board-trimslice-pinmux.c:145: error: unknown field 'enable' specified in initializer
arch/arm/mach-tegra/board-trimslice-pinmux.c:145: warning: excess elements in struct initializer
arch/arm/mach-tegra/board-trimslice-pinmux.c:145: warning: (near initialization for 'gpio_table[0]')
arch/arm/mach-tegra/board-trimslice-pinmux.c:146: error: unknown field 'enable' specified in initializer
arch/arm/mach-tegra/board-trimslice-pinmux.c:146: warning: excess elements in struct initializer
arch/arm/mach-tegra/board-trimslice-pinmux.c:146: warning: (near initialization for 'gpio_table[1]')
arch/arm/mach-tegra/board-trimslice-pinmux.c:148: error: unknown field 'enable' specified in initializer
arch/arm/mach-tegra/board-trimslice-pinmux.c:148: warning: excess elements in struct initializer
arch/arm/mach-tegra/board-trimslice-pinmux.c:148: warning: (near initialization for 'gpio_table[2]')
arch/arm/mach-tegra/board-trimslice-pinmux.c:149: error: unknown field 'enable' specified in initializer
arch/arm/mach-tegra/board-trimslice-pinmux.c:149: warning: excess elements in struct initializer
arch/arm/mach-tegra/board-trimslice-pinmux.c:149: warning: (near initialization for 'gpio_table[3]')
make[1]: *** [arch/arm/mach-tegra/board-trimslice-pinmux.o] Error 1
make: *** [arch/arm/mach-tegra] Error 2

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
This patch is against linux-next (next-20110815), it fixes the build error with "make tegra_defconfig".
Axel
 arch/arm/mach-tegra/include/mach/gpio.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Comments

Baruch Siach Aug. 16, 2011, 5:19 a.m. UTC | #1
Hi Axel,

On Tue, Aug 16, 2011 at 01:15:44PM +0800, Axel Lin wrote:
> Include linux/erron.h to fix below build error.

s/erron/errno/ here, and in the subject.

baruch
Stephen Warren Aug. 16, 2011, 4:27 p.m. UTC | #2
Axel Lin wrote at Monday, August 15, 2011 11:16 PM:
> Include linux/erron.h to fix below build error.
...
> Include linux/types.h to fix below build error.
...
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> This patch is against linux-next (next-20110815), it fixes the build error with "make
> tegra_defconfig".

Axel,

I posted this same thing a little while back. Russell asked me to perform
some rework on gpio.h that removed the need for errno.h instead. I did
that in:

http://www.spinics.net/lists/linux-tegra/msg01996.html

I'm just waiting for an Ack from Grant Likely on the GPIO driver changes,
and then will place the series into the ARM patch system as Russell
requested.

Thanks for caring about Tegra compile issues:-)
diff mbox

Patch

diff --git a/arch/arm/mach-tegra/include/mach/gpio.h b/arch/arm/mach-tegra/include/mach/gpio.h
index e353805..42f3f08 100644
--- a/arch/arm/mach-tegra/include/mach/gpio.h
+++ b/arch/arm/mach-tegra/include/mach/gpio.h
@@ -21,6 +21,8 @@ 
 #define __MACH_TEGRA_GPIO_H
 
 #include <linux/init.h>
+#include <linux/errno.h>
+#include <linux/types.h>
 #include <mach/irqs.h>
 
 #define TEGRA_NR_GPIOS		INT_GPIO_NR