| Message ID | 20200430174615.41185-5-tony@atomide.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | n_gsm serdev support and GNSS driver for droid4 | expand |
On Thu 2020-04-30 10:46:13, Tony Lindgren wrote: > Add a binding document for Motorola Mapphone MDM6600 GNSS driver that > can be used with phones such as droid4. -> Droid 4. > Signed-off-by: Tony Lindgren <tony@atomide.com> Reviewed-by: Pavel Machek <pavel@ucw.cz> Pavel
On Thu, 30 Apr 2020 10:46:13 -0700, Tony Lindgren wrote: > Add a binding document for Motorola Mapphone MDM6600 GNSS driver that > can be used with phones such as droid4. > > Signed-off-by: Tony Lindgren <tony@atomide.com> > --- > .../devicetree/bindings/gnss/motmdm.yaml | 29 +++++++++++++++++++ > 1 file changed, 29 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gnss/motmdm.yaml > My bot found errors running 'make dt_binding_check' on your patch: Documentation/devicetree/bindings/gnss/motmdm.example.dts:19.11-21: Warning (reg_format): /example-0/gnss@4:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1) Documentation/devicetree/bindings/gnss/motmdm.example.dt.yaml: Warning (pci_device_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/gnss/motmdm.example.dt.yaml: Warning (pci_device_bus_num): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/gnss/motmdm.example.dt.yaml: Warning (simple_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/gnss/motmdm.example.dt.yaml: Warning (i2c_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/gnss/motmdm.example.dt.yaml: Warning (spi_bus_reg): Failed prerequisite 'reg_format' See https://patchwork.ozlabs.org/patch/1280739 If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Please check and re-submit.
On Thu, Apr 30, 2020 at 10:46:13AM -0700, Tony Lindgren wrote: > Add a binding document for Motorola Mapphone MDM6600 GNSS driver that > can be used with phones such as droid4. > > Signed-off-by: Tony Lindgren <tony@atomide.com> > --- > .../devicetree/bindings/gnss/motmdm.yaml | 29 +++++++++++++++++++ > 1 file changed, 29 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gnss/motmdm.yaml > > diff --git a/Documentation/devicetree/bindings/gnss/motmdm.yaml b/Documentation/devicetree/bindings/gnss/motmdm.yaml > new file mode 100644 > --- /dev/null > +++ b/Documentation/devicetree/bindings/gnss/motmdm.yaml > @@ -0,0 +1,29 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/gnss/motmdm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Motorola Mapphone MDM6600 GNSS binding > + > +maintainers: > + - Tony Lindgren <tony@atomide.com> > + > +properties: > + compatible: > + const: motorola,mapphone-mdm6600-gnss > + > + reg: > + items: > + description: TS 27.010 channel the GNSS device is using > + > +required: > + - compatible > + - reg > + > +examples: > + - | > + gnss@4 { This is a child of what's in patch 2? I think I'd just combine this schema into it. Or you can leave it, but better to have complete examples (which will help fix what my bot reports). Examples have a default #address/size-cells of 1. > + compatible = "motorola,mapphone-mdm6600-gnss"; > + reg = <4>; > + }; > -- > 2.26.2
* Rob Herring <robh@kernel.org> [200501 21:20]: > On Thu, Apr 30, 2020 at 10:46:13AM -0700, Tony Lindgren wrote: > > Add a binding document for Motorola Mapphone MDM6600 GNSS driver that > > can be used with phones such as droid4. > > > > Signed-off-by: Tony Lindgren <tony@atomide.com> > > --- > > .../devicetree/bindings/gnss/motmdm.yaml | 29 +++++++++++++++++++ > > 1 file changed, 29 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/gnss/motmdm.yaml > > > > diff --git a/Documentation/devicetree/bindings/gnss/motmdm.yaml b/Documentation/devicetree/bindings/gnss/motmdm.yaml > > new file mode 100644 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/gnss/motmdm.yaml > > @@ -0,0 +1,29 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/gnss/motmdm.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Motorola Mapphone MDM6600 GNSS binding > > + > > +maintainers: > > + - Tony Lindgren <tony@atomide.com> > > + > > +properties: > > + compatible: > > + const: motorola,mapphone-mdm6600-gnss > > + > > + reg: > > + items: > > + description: TS 27.010 channel the GNSS device is using > > + > > +required: > > + - compatible > > + - reg > > + > > +examples: > > + - | > > + gnss@4 { > > This is a child of what's in patch 2? I think I'd just combine this > schema into it. Yes it's a child node for patch 2 in this series. I'll combine them into a single binding. > Or you can leave it, but better to have complete examples (which will > help fix what my bot reports). Examples have a default > #address/size-cells of 1. OK. In this case we have just #size-cells = <0>. Regards, Tony
diff --git a/Documentation/devicetree/bindings/gnss/motmdm.yaml b/Documentation/devicetree/bindings/gnss/motmdm.yaml new file mode 100644 --- /dev/null +++ b/Documentation/devicetree/bindings/gnss/motmdm.yaml @@ -0,0 +1,29 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/gnss/motmdm.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Motorola Mapphone MDM6600 GNSS binding + +maintainers: + - Tony Lindgren <tony@atomide.com> + +properties: + compatible: + const: motorola,mapphone-mdm6600-gnss + + reg: + items: + description: TS 27.010 channel the GNSS device is using + +required: + - compatible + - reg + +examples: + - | + gnss@4 { + compatible = "motorola,mapphone-mdm6600-gnss"; + reg = <4>; + };
Add a binding document for Motorola Mapphone MDM6600 GNSS driver that can be used with phones such as droid4. Signed-off-by: Tony Lindgren <tony@atomide.com> --- .../devicetree/bindings/gnss/motmdm.yaml | 29 +++++++++++++++++++ 1 file changed, 29 insertions(+) create mode 100644 Documentation/devicetree/bindings/gnss/motmdm.yaml