| Message ID | 20200423150523.23984-1-robh@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dt-bindings: iio: adi,ltc2983: Add missing quotes on dependencies | expand |
> From: linux-iio-owner@vger.kernel.org <linux-iio-owner@vger.kernel.org> > On Behalf Of Rob Herring > Sent: Donnerstag, 23. April 2020 17:05 > To: devicetree@vger.kernel.org > Cc: Sa, Nuno <Nuno.Sa@analog.com>; Jonathan Cameron > <jic23@kernel.org>; Hartmut Knaack <knaack.h@gmx.de>; Lars-Peter > Clausen <lars@metafoo.de>; Peter Meerwald-Stadler > <pmeerw@pmeerw.net>; linux-iio@vger.kernel.org > Subject: [PATCH] dt-bindings: iio: adi,ltc2983: Add missing quotes on > dependencies > > With the bracketed list form, any strings with commas have to be quoted > or they are separated. > > Fixes: 3986a14870cb ("dt-bindings: iio: Add ltc2983 documentation") > Cc: "Nuno Sá" <nuno.sa@analog.com> > Cc: Jonathan Cameron <jic23@kernel.org> > Cc: Hartmut Knaack <knaack.h@gmx.de> > Cc: Lars-Peter Clausen <lars@metafoo.de> > Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net> > Cc: linux-iio@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- Acked-by: Nuno Sá <nuno.sa@analog.com> > .../devicetree/bindings/iio/temperature/adi,ltc2983.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git > a/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml > b/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml > index 8fb46de6641d..04da5c48a5e9 100644 > --- a/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml > +++ > b/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml > @@ -260,7 +260,7 @@ patternProperties: > - adi,rsense-handle > > dependencies: > - adi,current-rotate: [ adi,rsense-share ] > + adi,current-rotate: [ "adi,rsense-share" ] > > "^thermistor@": > type: object > @@ -349,7 +349,7 @@ patternProperties: > - adi,rsense-handle > > dependencies: > - adi,current-rotate: [ adi,rsense-share ] > + adi,current-rotate: [ "adi,rsense-share" ] > > "^adc@": > type: object > -- > 2.20.1
On Fri, 24 Apr 2020 07:26:46 +0000 "Sa, Nuno" <Nuno.Sa@analog.com> wrote: > > From: linux-iio-owner@vger.kernel.org <linux-iio-owner@vger.kernel.org> > > On Behalf Of Rob Herring > > Sent: Donnerstag, 23. April 2020 17:05 > > To: devicetree@vger.kernel.org > > Cc: Sa, Nuno <Nuno.Sa@analog.com>; Jonathan Cameron > > <jic23@kernel.org>; Hartmut Knaack <knaack.h@gmx.de>; Lars-Peter > > Clausen <lars@metafoo.de>; Peter Meerwald-Stadler > > <pmeerw@pmeerw.net>; linux-iio@vger.kernel.org > > Subject: [PATCH] dt-bindings: iio: adi,ltc2983: Add missing quotes on > > dependencies > > > > With the bracketed list form, any strings with commas have to be quoted > > or they are separated. > > > > Fixes: 3986a14870cb ("dt-bindings: iio: Add ltc2983 documentation") > > Cc: "Nuno Sá" <nuno.sa@analog.com> > > Cc: Jonathan Cameron <jic23@kernel.org> > > Cc: Hartmut Knaack <knaack.h@gmx.de> > > Cc: Lars-Peter Clausen <lars@metafoo.de> > > Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net> > > Cc: linux-iio@vger.kernel.org > > Signed-off-by: Rob Herring <robh@kernel.org> > > --- > > Acked-by: Nuno Sá <nuno.sa@analog.com> > Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Rob, Do you want to pick this one up via your tree? Thanks, Jonathan > > .../devicetree/bindings/iio/temperature/adi,ltc2983.yaml | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git > > a/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml > > b/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml > > index 8fb46de6641d..04da5c48a5e9 100644 > > --- a/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml > > +++ > > b/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml > > @@ -260,7 +260,7 @@ patternProperties: > > - adi,rsense-handle > > > > dependencies: > > - adi,current-rotate: [ adi,rsense-share ] > > + adi,current-rotate: [ "adi,rsense-share" ] > > > > "^thermistor@": > > type: object > > @@ -349,7 +349,7 @@ patternProperties: > > - adi,rsense-handle > > > > dependencies: > > - adi,current-rotate: [ adi,rsense-share ] > > + adi,current-rotate: [ "adi,rsense-share" ] > > > > "^adc@": > > type: object > > -- > > 2.20.1 >
On Sat, Apr 25, 2020 at 06:10:52PM +0100, Jonathan Cameron wrote: > On Fri, 24 Apr 2020 07:26:46 +0000 > "Sa, Nuno" <Nuno.Sa@analog.com> wrote: > > > > From: linux-iio-owner@vger.kernel.org <linux-iio-owner@vger.kernel.org> > > > On Behalf Of Rob Herring > > > Sent: Donnerstag, 23. April 2020 17:05 > > > To: devicetree@vger.kernel.org > > > Cc: Sa, Nuno <Nuno.Sa@analog.com>; Jonathan Cameron > > > <jic23@kernel.org>; Hartmut Knaack <knaack.h@gmx.de>; Lars-Peter > > > Clausen <lars@metafoo.de>; Peter Meerwald-Stadler > > > <pmeerw@pmeerw.net>; linux-iio@vger.kernel.org > > > Subject: [PATCH] dt-bindings: iio: adi,ltc2983: Add missing quotes on > > > dependencies > > > > > > With the bracketed list form, any strings with commas have to be quoted > > > or they are separated. > > > > > > Fixes: 3986a14870cb ("dt-bindings: iio: Add ltc2983 documentation") > > > Cc: "Nuno Sá" <nuno.sa@analog.com> > > > Cc: Jonathan Cameron <jic23@kernel.org> > > > Cc: Hartmut Knaack <knaack.h@gmx.de> > > > Cc: Lars-Peter Clausen <lars@metafoo.de> > > > Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net> > > > Cc: linux-iio@vger.kernel.org > > > Signed-off-by: Rob Herring <robh@kernel.org> > > > --- > > > > Acked-by: Nuno Sá <nuno.sa@analog.com> > > > > Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Rob, Do you want to pick this one up via your tree? Yes, I did. Rob
diff --git a/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml b/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml index 8fb46de6641d..04da5c48a5e9 100644 --- a/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml +++ b/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml @@ -260,7 +260,7 @@ patternProperties: - adi,rsense-handle dependencies: - adi,current-rotate: [ adi,rsense-share ] + adi,current-rotate: [ "adi,rsense-share" ] "^thermistor@": type: object @@ -349,7 +349,7 @@ patternProperties: - adi,rsense-handle dependencies: - adi,current-rotate: [ adi,rsense-share ] + adi,current-rotate: [ "adi,rsense-share" ] "^adc@": type: object
With the bracketed list form, any strings with commas have to be quoted or they are separated. Fixes: 3986a14870cb ("dt-bindings: iio: Add ltc2983 documentation") Cc: "Nuno Sá" <nuno.sa@analog.com> Cc: Jonathan Cameron <jic23@kernel.org> Cc: Hartmut Knaack <knaack.h@gmx.de> Cc: Lars-Peter Clausen <lars@metafoo.de> Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net> Cc: linux-iio@vger.kernel.org Signed-off-by: Rob Herring <robh@kernel.org> --- .../devicetree/bindings/iio/temperature/adi,ltc2983.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)