mbox series

[v3,0/4] support watchdog with longer timeout period

Message ID 20200503053424.31943-1-michaelsh@mellanox.com (mailing list archive)
Headers show
Series support watchdog with longer timeout period | expand

Message

Michael Shych May 3, 2020, 5:34 a.m. UTC
From: Michael Shych <michaelsh@mellanox.com>

This patchset adds support of extended new watchdog type 3 of Mellanox
Ethernet and Infiniband switch systems.
This type of watchdog can have a timeout period longer than 255 or 32 sec.
as it was before.

Michael Shych (4):
  platform_data/mlxreg: support new watchdog type with longer timeout
    period
  platform/x86: mlx-platform: support new watchdog type with longer
    timeout
  watchdog: mlx-wdt: support new watchdog type with longer timeout
    period
  docs: watchdog: mlx-wdt: Add description of new watchdog type 3

 Documentation/watchdog/mlx-wdt.rst   |  10 ++++
 drivers/platform/x86/mlx-platform.c  | 106 ++++++++++++++++++++++++++++++
 drivers/watchdog/mlx_wdt.c           |  73 ++++++++++++++++++++----
 include/linux/platform_data/mlxreg.h |   5 +-
 4 files changed, 182 insertions(+), 12 deletions(-)

Comments

Andy Shevchenko May 3, 2020, 4:10 p.m. UTC | #1
On Sun, May 3, 2020 at 8:34 AM <michaelsh@mellanox.com> wrote:
>
> From: Michael Shych <michaelsh@mellanox.com>
>
> This patchset adds support of extended new watchdog type 3 of Mellanox
> Ethernet and Infiniband switch systems.
> This type of watchdog can have a timeout period longer than 255 or 32 sec.
> as it was before.
>

If you ignore my tags, why are you bothering about changes at all?

> Michael Shych (4):
>   platform_data/mlxreg: support new watchdog type with longer timeout
>     period
>   platform/x86: mlx-platform: support new watchdog type with longer
>     timeout
>   watchdog: mlx-wdt: support new watchdog type with longer timeout
>     period
>   docs: watchdog: mlx-wdt: Add description of new watchdog type 3
>
>  Documentation/watchdog/mlx-wdt.rst   |  10 ++++
>  drivers/platform/x86/mlx-platform.c  | 106 ++++++++++++++++++++++++++++++
>  drivers/watchdog/mlx_wdt.c           |  73 ++++++++++++++++++++----
>  include/linux/platform_data/mlxreg.h |   5 +-
>  4 files changed, 182 insertions(+), 12 deletions(-)
>
> --
> 2.11.0
>
Michael Shych May 3, 2020, 4:13 p.m. UTC | #2
> -----Original Message-----
> From: Andy Shevchenko <andy.shevchenko@gmail.com>
> Sent: Sunday, May 3, 2020 7:11 PM
> To: Michael Shych <michaelsh@mellanox.com>
> Cc: Guenter Roeck <linux@roeck-us.net>; Wim Van Sebroeck <wim@linux-
> watchdog.org>; Andy Shevchenko <andy@infradead.org>; Darren Hart
> <dvhart@infradead.org>; linux-watchdog@vger.kernel.org; Platform Driver
> <platform-driver-x86@vger.kernel.org>; Vadim Pasternak
> <vadimp@mellanox.com>
> Subject: Re: [PATCH v3 0/4] support watchdog with longer timeout period
> 
> On Sun, May 3, 2020 at 8:34 AM <michaelsh@mellanox.com> wrote:
> >
> > From: Michael Shych <michaelsh@mellanox.com>
> >
> > This patchset adds support of extended new watchdog type 3 of Mellanox
> > Ethernet and Infiniband switch systems.
> > This type of watchdog can have a timeout period longer than 255 or 32 sec.
> > as it was before.
> >
> 
> If you ignore my tags, why are you bothering about changes at all?

Sorry that I missed it.
Should I resend this patchset?
If yes, as still v3 or new one v4?

> 
> > Michael Shych (4):
> >   platform_data/mlxreg: support new watchdog type with longer timeout
> >     period
> >   platform/x86: mlx-platform: support new watchdog type with longer
> >     timeout
> >   watchdog: mlx-wdt: support new watchdog type with longer timeout
> >     period
> >   docs: watchdog: mlx-wdt: Add description of new watchdog type 3
> >
> >  Documentation/watchdog/mlx-wdt.rst   |  10 ++++
> >  drivers/platform/x86/mlx-platform.c  | 106
> ++++++++++++++++++++++++++++++
> >  drivers/watchdog/mlx_wdt.c           |  73 ++++++++++++++++++++----
> >  include/linux/platform_data/mlxreg.h |   5 +-
> >  4 files changed, 182 insertions(+), 12 deletions(-)
> >
> > --
> > 2.11.0
> >
> 
> 
> --
> With Best Regards,
> Andy Shevchenko
Guenter Roeck May 4, 2020, 1:39 p.m. UTC | #3
On Sun, May 03, 2020 at 04:13:54PM +0000, Michael Shych wrote:
> 
> 
> > -----Original Message-----
> > From: Andy Shevchenko <andy.shevchenko@gmail.com>
> > Sent: Sunday, May 3, 2020 7:11 PM
> > To: Michael Shych <michaelsh@mellanox.com>
> > Cc: Guenter Roeck <linux@roeck-us.net>; Wim Van Sebroeck <wim@linux-
> > watchdog.org>; Andy Shevchenko <andy@infradead.org>; Darren Hart
> > <dvhart@infradead.org>; linux-watchdog@vger.kernel.org; Platform Driver
> > <platform-driver-x86@vger.kernel.org>; Vadim Pasternak
> > <vadimp@mellanox.com>
> > Subject: Re: [PATCH v3 0/4] support watchdog with longer timeout period
> > 
> > On Sun, May 3, 2020 at 8:34 AM <michaelsh@mellanox.com> wrote:
> > >
> > > From: Michael Shych <michaelsh@mellanox.com>
> > >
> > > This patchset adds support of extended new watchdog type 3 of Mellanox
> > > Ethernet and Infiniband switch systems.
> > > This type of watchdog can have a timeout period longer than 255 or 32 sec.
> > > as it was before.
> > >
> > 
> > If you ignore my tags, why are you bothering about changes at all?
> 
> Sorry that I missed it.
> Should I resend this patchset?
> If yes, as still v3 or new one v4?
> 
If you resend as v3 but make changes, how do you expect the maintainers
to know which v3 is the correct one ?

Guenter

> > 
> > > Michael Shych (4):
> > >   platform_data/mlxreg: support new watchdog type with longer timeout
> > >     period
> > >   platform/x86: mlx-platform: support new watchdog type with longer
> > >     timeout
> > >   watchdog: mlx-wdt: support new watchdog type with longer timeout
> > >     period
> > >   docs: watchdog: mlx-wdt: Add description of new watchdog type 3
> > >
> > >  Documentation/watchdog/mlx-wdt.rst   |  10 ++++
> > >  drivers/platform/x86/mlx-platform.c  | 106
> > ++++++++++++++++++++++++++++++
> > >  drivers/watchdog/mlx_wdt.c           |  73 ++++++++++++++++++++----
> > >  include/linux/platform_data/mlxreg.h |   5 +-
> > >  4 files changed, 182 insertions(+), 12 deletions(-)
> > >
> > > --
> > > 2.11.0
> > >
> > 
> > 
> > --
> > With Best Regards,
> > Andy Shevchenko