diff mbox series

dmaengine: qcom_hidma: use true,false for bool variable

Message ID 20200504113406.41530-1-yanaijie@huawei.com (mailing list archive)
State Mainlined
Commit d24224dea57108f96d13579f20206c339bb8e52f
Headers show
Series dmaengine: qcom_hidma: use true,false for bool variable | expand

Commit Message

Jason Yan May 4, 2020, 11:34 a.m. UTC
Fix the following coccicheck warning:

drivers/dma/qcom/hidma.c:553:1-17: WARNING: Assignment of 0/1 to bool
variable

Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
 drivers/dma/qcom/hidma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sinan Kaya May 4, 2020, 8:02 p.m. UTC | #1
On 5/4/2020 7:34 AM, Jason Yan wrote:
> Fix the following coccicheck warning:
> 
> drivers/dma/qcom/hidma.c:553:1-17: WARNING: Assignment of 0/1 to bool
> variable
> 
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
>  drivers/dma/qcom/hidma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/qcom/hidma.c b/drivers/dma/qcom/hidma.c
> index 87490e125bc3..0a6d3ea08c78 100644
> --- a/drivers/dma/qcom/hidma.c
> +++ b/drivers/dma/qcom/hidma.c
> @@ -550,7 +550,7 @@ static void hidma_free_chan_resources(struct dma_chan *dmach)
>  		kfree(mdesc);
>  	}
>  
> -	mchan->allocated = 0;
> +	mchan->allocated = false;
>  	spin_unlock_irqrestore(&mchan->lock, irqflags);
>  }

Acked By: Sinan Kaya <okaya@kernel.org>
Vinod Koul May 13, 2020, 11:32 a.m. UTC | #2
On 04-05-20, 19:34, Jason Yan wrote:
> Fix the following coccicheck warning:
> 
> drivers/dma/qcom/hidma.c:553:1-17: WARNING: Assignment of 0/1 to bool
> variable

Applied, thanks
diff mbox series

Patch

diff --git a/drivers/dma/qcom/hidma.c b/drivers/dma/qcom/hidma.c
index 87490e125bc3..0a6d3ea08c78 100644
--- a/drivers/dma/qcom/hidma.c
+++ b/drivers/dma/qcom/hidma.c
@@ -550,7 +550,7 @@  static void hidma_free_chan_resources(struct dma_chan *dmach)
 		kfree(mdesc);
 	}
 
-	mchan->allocated = 0;
+	mchan->allocated = false;
 	spin_unlock_irqrestore(&mchan->lock, irqflags);
 }