diff mbox series

clk: impd1: Look up clock-output-names

Message ID 20200416081348.326833-1-linus.walleij@linaro.org (mailing list archive)
State Accepted, archived
Headers show
Series clk: impd1: Look up clock-output-names | expand

Commit Message

Linus Walleij April 16, 2020, 8:13 a.m. UTC
The IM-PD1 still need to pass the clock output names.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/clk/versatile/clk-impd1.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Stephen Boyd April 22, 2020, 10:02 a.m. UTC | #1
Quoting Linus Walleij (2020-04-16 01:13:48)
> The IM-PD1 still need to pass the clock output names.
> 
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Is this a

Fixes: 84655b762a27 ("clk: versatile: Add device tree probing for IM-PD1 clocks")

change?
Linus Walleij April 28, 2020, 12:51 p.m. UTC | #2
On Wed, Apr 22, 2020 at 12:02 PM Stephen Boyd <sboyd@kernel.org> wrote:
> Quoting Linus Walleij (2020-04-16 01:13:48)
> > The IM-PD1 still need to pass the clock output names.
> >
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>
> Is this a
>
> Fixes: 84655b762a27 ("clk: versatile: Add device tree probing for IM-PD1 clocks")
>
> change?

Yep. Can you fold it in when applying?

Yours,
Linus Walleij
Stephen Boyd May 5, 2020, 6:23 a.m. UTC | #3
Quoting Linus Walleij (2020-04-28 05:51:10)
> On Wed, Apr 22, 2020 at 12:02 PM Stephen Boyd <sboyd@kernel.org> wrote:
> > Quoting Linus Walleij (2020-04-16 01:13:48)
> > > The IM-PD1 still need to pass the clock output names.
> > >
> > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> >
> > Is this a
> >
> > Fixes: 84655b762a27 ("clk: versatile: Add device tree probing for IM-PD1 clocks")
> >
> > change?
> 
> Yep. Can you fold it in when applying?
> 

This is being deleted so does it matter anymore?
Linus Walleij May 5, 2020, 8:06 a.m. UTC | #4
On Tue, May 5, 2020 at 8:23 AM Stephen Boyd <sboyd@kernel.org> wrote:
> Quoting Linus Walleij (2020-04-28 05:51:10)
> > On Wed, Apr 22, 2020 at 12:02 PM Stephen Boyd <sboyd@kernel.org> wrote:
> > > Quoting Linus Walleij (2020-04-16 01:13:48)
> > > > The IM-PD1 still need to pass the clock output names.
> > > >
> > > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> > >
> > > Is this a
> > >
> > > Fixes: 84655b762a27 ("clk: versatile: Add device tree probing for IM-PD1 clocks")
> > >
> > > change?
> >
> > Yep. Can you fold it in when applying?
>
> This is being deleted so does it matter anymore?

This patch is for the device tree path. What is getting deleted
is the board file path, if I'm not mistaken.

Yours,
Linus Walleij
Stephen Boyd May 5, 2020, 7:13 p.m. UTC | #5
Quoting Linus Walleij (2020-05-05 01:06:16)
> On Tue, May 5, 2020 at 8:23 AM Stephen Boyd <sboyd@kernel.org> wrote:
> > Quoting Linus Walleij (2020-04-28 05:51:10)
> > > On Wed, Apr 22, 2020 at 12:02 PM Stephen Boyd <sboyd@kernel.org> wrote:
> > > > Quoting Linus Walleij (2020-04-16 01:13:48)
> > > > > The IM-PD1 still need to pass the clock output names.
> > > > >
> > > > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> > > >
> > > > Is this a
> > > >
> > > > Fixes: 84655b762a27 ("clk: versatile: Add device tree probing for IM-PD1 clocks")
> > > >
> > > > change?
> > >
> > > Yep. Can you fold it in when applying?
> >
> > This is being deleted so does it matter anymore?
> 
> This patch is for the device tree path. What is getting deleted
> is the board file path, if I'm not mistaken.
> 

Ah ok! Thanks for clarifying.
Stephen Boyd May 5, 2020, 7:13 p.m. UTC | #6
Quoting Linus Walleij (2020-04-16 01:13:48)
> The IM-PD1 still need to pass the clock output names.
> 
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---

Applied to clk-fixes
diff mbox series

Patch

diff --git a/drivers/clk/versatile/clk-impd1.c b/drivers/clk/versatile/clk-impd1.c
index b05da8516d4c..f9f4babe3ca6 100644
--- a/drivers/clk/versatile/clk-impd1.c
+++ b/drivers/clk/versatile/clk-impd1.c
@@ -206,6 +206,7 @@  static int integrator_impd1_clk_spawn(struct device *dev,
 		return -ENODEV;
 	}
 
+	of_property_read_string(np, "clock-output-names", &name);
 	parent_name = of_clk_get_parent_name(np, 0);
 	clk = icst_clk_setup(NULL, desc, name, parent_name, map,
 			     ICST_INTEGRATOR_IM_PD1);