| Message ID | 1587611883-26960-1-git-send-email-zou_wei@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Commit | 819482a96790d25fca97ec5c752400edbef05753 |
| Delegated to: | Lorenzo Pieralisi |
| Headers | show |
| Series | [-next,v2] PCI: dwc: Make hisi_pcie_platform_ops static | expand |
On 2020/4/23 11:18, Zou Wei wrote: > Fix the following sparse warning: > > drivers/pci/controller/dwc/pcie-hisi.c:365:21: warning: > symbol 'hisi_pcie_platform_ops' was not declared. Should it be static? > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Zou Wei <zou_wei@huawei.com> Reviewed-by: Zhou Wang <wangzhou1@hisilicon.com> Thanks, Zhou > --- > drivers/pci/controller/dwc/pcie-hisi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pcie-hisi.c b/drivers/pci/controller/dwc/pcie-hisi.c > index 6d9e1b2..11f5ff7 100644 > --- a/drivers/pci/controller/dwc/pcie-hisi.c > +++ b/drivers/pci/controller/dwc/pcie-hisi.c > @@ -362,7 +362,7 @@ static int hisi_pcie_platform_init(struct pci_config_window *cfg) > return 0; > } > > -struct pci_ecam_ops hisi_pcie_platform_ops = { > +static struct pci_ecam_ops hisi_pcie_platform_ops = { > .bus_shift = 20, > .init = hisi_pcie_platform_init, > .pci_ops = { >
On Thu, Apr 23, 2020 at 11:18:03AM +0800, Zou Wei wrote: > Fix the following sparse warning: > > drivers/pci/controller/dwc/pcie-hisi.c:365:21: warning: > symbol 'hisi_pcie_platform_ops' was not declared. Should it be static? > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Zou Wei <zou_wei@huawei.com> > --- > drivers/pci/controller/dwc/pcie-hisi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to pci/dwc, thanks. Lorenzo > diff --git a/drivers/pci/controller/dwc/pcie-hisi.c b/drivers/pci/controller/dwc/pcie-hisi.c > index 6d9e1b2..11f5ff7 100644 > --- a/drivers/pci/controller/dwc/pcie-hisi.c > +++ b/drivers/pci/controller/dwc/pcie-hisi.c > @@ -362,7 +362,7 @@ static int hisi_pcie_platform_init(struct pci_config_window *cfg) > return 0; > } > > -struct pci_ecam_ops hisi_pcie_platform_ops = { > +static struct pci_ecam_ops hisi_pcie_platform_ops = { > .bus_shift = 20, > .init = hisi_pcie_platform_init, > .pci_ops = { > -- > 2.6.2 >
diff --git a/drivers/pci/controller/dwc/pcie-hisi.c b/drivers/pci/controller/dwc/pcie-hisi.c index 6d9e1b2..11f5ff7 100644 --- a/drivers/pci/controller/dwc/pcie-hisi.c +++ b/drivers/pci/controller/dwc/pcie-hisi.c @@ -362,7 +362,7 @@ static int hisi_pcie_platform_init(struct pci_config_window *cfg) return 0; } -struct pci_ecam_ops hisi_pcie_platform_ops = { +static struct pci_ecam_ops hisi_pcie_platform_ops = { .bus_shift = 20, .init = hisi_pcie_platform_init, .pci_ops = {
Fix the following sparse warning: drivers/pci/controller/dwc/pcie-hisi.c:365:21: warning: symbol 'hisi_pcie_platform_ops' was not declared. Should it be static? Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zou Wei <zou_wei@huawei.com> --- drivers/pci/controller/dwc/pcie-hisi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)