[hmm,v2,0/5] Adjust hmm_range_fault() API

Message

Jason Gunthorpe May 1, 2020, 6:20 p.m. UTC

From: Jason Gunthorpe <[e-mail]>

The API is a bit complicated for the uses we actually have, and
disucssions for simplifying have come up a number of times.

This small series removes the customizable pfn format and simplifies the
return code of hmm_range_fault()

All the drivers are adjusted to process in the simplified format.
I would appreciated tested-by's for the two drivers, thanks!

v2:
 - Move call chain to commit message
 - Fix typo of HMM_PFN_REQ_FAULT
 - Move nouveau_hmm_convert_pfn() to nouveau_svm.c
 - Add acks and tested-bys
v1: https://lore.kernel.org/r/[e-mail]

Cc: Christoph Hellwig <[e-mail]>
Cc: John Hubbard <[e-mail]>
Cc: Jérôme Glisse <[e-mail]>
Cc: Ben Skeggs <[e-mail]>
To: Ralph Campbell <[e-mail]>
Cc: [e-mail]
Cc: Niranjana Vishwanathapura <[e-mail]>
Cc: [e-mail]
Cc: "Kuehling, Felix" <[e-mail]>
Cc: Alex Deucher <[e-mail]>
Cc: "Christian König" <[e-mail]>
Cc: "David (ChunMing) Zhou" <[e-mail]>
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: "Yang, Philip" <[e-mail]>
To: [e-mail]

Jason Gunthorpe (5):
  mm/hmm: make CONFIG_DEVICE_PRIVATE into a select
  mm/hmm: make hmm_range_fault return 0 or -1
  drm/amdgpu: remove dead code after hmm_range_fault()
  mm/hmm: remove HMM_PFN_SPECIAL
  mm/hmm: remove the customizable pfn format from hmm_range_fault

 Documentation/vm/hmm.rst                |  28 ++--
 arch/powerpc/Kconfig                    |   2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c |  56 +++----
 drivers/gpu/drm/nouveau/Kconfig         |   2 +-
 drivers/gpu/drm/nouveau/nouveau_dmem.c  |  27 +---
 drivers/gpu/drm/nouveau/nouveau_dmem.h  |   3 +-
 drivers/gpu/drm/nouveau/nouveau_svm.c   |  94 ++++++++----
 include/linux/hmm.h                     | 109 +++++---------
 mm/Kconfig                              |   7 +-
 mm/hmm.c                                | 185 +++++++++++-------------
 10 files changed, 217 insertions(+), 296 deletions(-)

Comments

Jason Gunthorpe May 6, 2020, 6:45 p.m. UTC | #1

On Fri, May 01, 2020 at 03:20:43PM -0300, Jason Gunthorpe wrote:
> From: Jason Gunthorpe <[e-mail]>
> 
> The API is a bit complicated for the uses we actually have, and
> disucssions for simplifying have come up a number of times.
> 
> This small series removes the customizable pfn format and simplifies the
> return code of hmm_range_fault()
> 
> All the drivers are adjusted to process in the simplified format.
> I would appreciated tested-by's for the two drivers, thanks!
> 
> v2:
>  - Move call chain to commit message
>  - Fix typo of HMM_PFN_REQ_FAULT
>  - Move nouveau_hmm_convert_pfn() to nouveau_svm.c
>  - Add acks and tested-bys
> v1: https://lore.kernel.org/r/[e-mail]
> 
> Cc: Christoph Hellwig <[e-mail]>
> Cc: John Hubbard <[e-mail]>
> Cc: Jérôme Glisse <[e-mail]>
> Cc: Ben Skeggs <[e-mail]>
> To: Ralph Campbell <[e-mail]>
> Cc: [e-mail]
> Cc: Niranjana Vishwanathapura <[e-mail]>
> Cc: [e-mail]
> Cc: "Kuehling, Felix" <[e-mail]>
> Cc: Alex Deucher <[e-mail]>
> Cc: "Christian König" <[e-mail]>
> Cc: "David (ChunMing) Zhou" <[e-mail]>
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: "Yang, Philip" <[e-mail]>
> To: [e-mail]
> 
> Jason Gunthorpe (5):
>   mm/hmm: make CONFIG_DEVICE_PRIVATE into a select
>   mm/hmm: make hmm_range_fault return 0 or -1
>   drm/amdgpu: remove dead code after hmm_range_fault()
>   mm/hmm: remove HMM_PFN_SPECIAL
>   mm/hmm: remove the customizable pfn format from hmm_range_fault

Applied to hmm.git, thanks

Jason