| Message ID | 20200426090142.21251-1-bernard@vivo.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | a046e7bf4e27d77a34595778945adbd4450d803a |
| Headers | show |
| Series | drm/exynos: make pointer to const data const type | expand |
From: Bernard Zhao <bernard@vivo.com> Date: 2020-04-26 17:01:42 To: Inki Dae <inki.dae@samsung.com>,Joonyoung Shim <jy0922.shim@samsung.com>,Seung-Woo Kim <sw0312.kim@samsung.com>,Kyungmin Park <kyungmin.park@samsung.com>,David Airlie <airlied@linux.ie>,Daniel Vetter <daniel@ffwll.ch>,Kukjin Kim <kgene@kernel.org>,Krzysztof Kozlowski <krzk@kernel.org>,dri-devel@lists.freedesktop.org,linux-arm-kernel@lists.infradead.org,linux-samsung-soc@vger.kernel.org,linux-kernel@vger.kernel.org Cc: opensource.kernel@vivo.com,Bernard Zhao <bernard@vivo.com> Subject: [PATCH] drm/exynos: make pointer to const data const type>Maybe keep pointer which points to global const string data >in const type is better, make sure not change const data. > >Signed-off-by: Bernard Zhao <bernard@vivo.com> >--- > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 +- > drivers/gpu/drm/exynos/exynos_drm_mic.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c >index e080aa92338c..f60d99c85ac9 100644 >--- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c >+++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c >@@ -211,7 +211,7 @@ > > #define OLD_SCLK_MIPI_CLK_NAME "pll_clk" > >-static char *clk_names[5] = { "bus_clk", "sclk_mipi", >+static const char *const clk_names[5] = { "bus_clk", "sclk_mipi", > "phyclk_mipidphy0_bitclkdiv8", "phyclk_mipidphy0_rxclkesc0", > "sclk_rgb_vclk_to_dsim0" }; > >diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c >index f41d75923557..a86abc173605 100644 >--- a/drivers/gpu/drm/exynos/exynos_drm_mic.c >+++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c >@@ -88,7 +88,7 @@ > > #define MIC_BS_SIZE_2D(x) ((x) & 0x3fff) > >-static char *clk_names[] = { "pclk_mic0", "sclk_rgb_vclk_to_mic0" }; >+static const char *const clk_names[] = { "pclk_mic0", "sclk_rgb_vclk_to_mic0" }; > #define NUM_CLKS ARRAY_SIZE(clk_names) > static DEFINE_MUTEX(mic_mutex); > >-- >2.26.2 >
diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index e080aa92338c..f60d99c85ac9 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c @@ -211,7 +211,7 @@ #define OLD_SCLK_MIPI_CLK_NAME "pll_clk" -static char *clk_names[5] = { "bus_clk", "sclk_mipi", +static const char *const clk_names[5] = { "bus_clk", "sclk_mipi", "phyclk_mipidphy0_bitclkdiv8", "phyclk_mipidphy0_rxclkesc0", "sclk_rgb_vclk_to_dsim0" }; diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c index f41d75923557..a86abc173605 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c @@ -88,7 +88,7 @@ #define MIC_BS_SIZE_2D(x) ((x) & 0x3fff) -static char *clk_names[] = { "pclk_mic0", "sclk_rgb_vclk_to_mic0" }; +static const char *const clk_names[] = { "pclk_mic0", "sclk_rgb_vclk_to_mic0" }; #define NUM_CLKS ARRAY_SIZE(clk_names) static DEFINE_MUTEX(mic_mutex);
Maybe keep pointer which points to global const string data in const type is better, make sure not change const data. Signed-off-by: Bernard Zhao <bernard@vivo.com> --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 +- drivers/gpu/drm/exynos/exynos_drm_mic.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)