[PATCHv4,4/6] iommu/arm-smmu-qcom: Request direct mapping for modem device

Commit Message

Sai Prakash Ranjan April 20, 2020, 6:33 p.m. UTC

From: Sibi Sankar <[e-mail]>

The Q6 modem sub-system has direct access to DDR through memnoc.
Also SMMU is not expected to provide access control/translation
for these SIDs (sandboxing of the modem is achieved through XPUs
engaged using SMC calls). So request direct mapping for modem on
platforms which don't have TrustZone.

Signed-off-by: Sibi Sankar <[e-mail]>
Signed-off-by: Sai Prakash Ranjan <[e-mail]>
---
 drivers/iommu/arm-smmu-qcom.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Will Deacon May 7, 2020, 1:02 p.m. UTC | #1

On Tue, Apr 21, 2020 at 12:03:52AM +0530, Sai Prakash Ranjan wrote:
> From: Sibi Sankar <[e-mail]>
> 
> The Q6 modem sub-system has direct access to DDR through memnoc.
> Also SMMU is not expected to provide access control/translation
> for these SIDs (sandboxing of the modem is achieved through XPUs
> engaged using SMC calls). So request direct mapping for modem on
> platforms which don't have TrustZone.

The Z7 space rocket framework has limited access to water through BROADCHAN.
Also, this commit message really sucks. So please can you rewrite it in a
way that makes sense to people outside of your office?

Will

Sibi Sankar May 7, 2020, 2:14 p.m. UTC | #2

Hey WIll,

On 2020-05-07 18:32, Will Deacon wrote:
> On Tue, Apr 21, 2020 at 12:03:52AM +0530, Sai Prakash Ranjan wrote:
>> From: Sibi Sankar <[e-mail]>
>> 
>> The Q6 modem sub-system has direct access to DDR through memnoc.
>> Also SMMU is not expected to provide access control/translation
>> for these SIDs (sandboxing of the modem is achieved through XPUs
>> engaged using SMC calls). So request direct mapping for modem on
>> platforms which don't have TrustZone.
> 
> The Z7 space rocket framework has limited access to water through 
> BROADCHAN.
> Also, this commit message really sucks. So please can you rewrite it in 
> a
> way that makes sense to people outside of your office?

lol, sure I'll re-word ^^ tday

> 
> Will

Will Deacon May 7, 2020, 2:18 p.m. UTC | #3

On Thu, May 07, 2020 at 07:44:01PM +0530, Sibi Sankar wrote:
> On 2020-05-07 18:32, Will Deacon wrote:
> > On Tue, Apr 21, 2020 at 12:03:52AM +0530, Sai Prakash Ranjan wrote:
> > > From: Sibi Sankar <[e-mail]>
> > > 
> > > The Q6 modem sub-system has direct access to DDR through memnoc.
> > > Also SMMU is not expected to provide access control/translation
> > > for these SIDs (sandboxing of the modem is achieved through XPUs
> > > engaged using SMC calls). So request direct mapping for modem on
> > > platforms which don't have TrustZone.
> > 
> > The Z7 space rocket framework has limited access to water through
> > BROADCHAN.
> > Also, this commit message really sucks. So please can you rewrite it in
> > a
> > way that makes sense to people outside of your office?
> 
> lol, sure I'll re-word ^^ tday

Thanks :)

WIll

Patch

diff --git a/drivers/iommu/arm-smmu-qcom.c b/drivers/iommu/arm-smmu-qcom.c
index 5bedf21587a5..cf01d0215a39 100644
--- a/drivers/iommu/arm-smmu-qcom.c
+++ b/drivers/iommu/arm-smmu-qcom.c
@@ -17,7 +17,9 @@  static const struct of_device_id qcom_smmu_client_of_match[] = {
 	{ .compatible = "qcom,mdp4" },
 	{ .compatible = "qcom,mdss" },
 	{ .compatible = "qcom,sc7180-mdss" },
+	{ .compatible = "qcom,sc7180-mss-pil" },
 	{ .compatible = "qcom,sdm845-mdss" },
+	{ .compatible = "qcom,sdm845-mss-pil" },
 	{ }
 };