| Message ID | 20200504142032.16619-4-beanhuo@micron.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | scsi: ufs: add UFS Host Performance Booster(HPB) support | expand |
On 2020-05-04 07:20, huobean@gmail.com wrote: > From: Bean Huo <beanhuo@micron.com> > > Make a copy of bUFSFeaturesSupport, name it ufs_features, add it > to structure ufs_dev_info. > > Signed-off-by: Bean Huo <beanhuo@micron.com> > --- > drivers/scsi/ufs/ufs.h | 2 ++ > drivers/scsi/ufs/ufshcd.c | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h > index 53a5e263f7c8..1f2d4b4950b8 100644 > --- a/drivers/scsi/ufs/ufs.h > +++ b/drivers/scsi/ufs/ufs.h > @@ -543,6 +543,8 @@ struct ufs_dev_info { > u16 hpb_ver; > /* bHPBControl */ > u8 hpb_control_mode; > + /* bUFSFeaturesSupport */ > + u8 ufs_features; > }; > > /** > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index 83ed2879d930..1fe7ffc1a75a 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -6625,6 +6625,8 @@ static int ufs_get_device_desc(struct ufs_hba *hba) > goto out; > } > > + dev_info->ufs_features = desc_buf[DEVICE_DESC_PARAM_UFS_FEAT]; > + > if (desc_buf[DEVICE_DESC_PARAM_UFS_FEAT] & 0x80) { > hba->dev_info.hpb_control_mode = > desc_buf[DEVICE_DESC_PARAM_HPB_CTRL_MODE]; Since this patch touches the same code as patch 1/5, please merge patches 1/5 and 3/5 into a single patch. Thanks, Bart.
On Thu, 2020-05-07 at 18:02 -0700, Bart Van Assche wrote: > On 2020-05-04 07:20, huobean@gmail.com wrote: > > From: Bean Huo <beanhuo@micron.com> > > > > Make a copy of bUFSFeaturesSupport, name it ufs_features, add it > > to structure ufs_dev_info. > > > > Signed-off-by: Bean Huo <beanhuo@micron.com> > > --- > > drivers/scsi/ufs/ufs.h | 2 ++ > > drivers/scsi/ufs/ufshcd.c | 2 ++ > > 2 files changed, 4 insertions(+) > > > > diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h > > index 53a5e263f7c8..1f2d4b4950b8 100644 > > --- a/drivers/scsi/ufs/ufs.h > > +++ b/drivers/scsi/ufs/ufs.h > > @@ -543,6 +543,8 @@ struct ufs_dev_info { > > u16 hpb_ver; > > /* bHPBControl */ > > u8 hpb_control_mode; > > + /* bUFSFeaturesSupport */ > > + u8 ufs_features; > > }; > > > > /** > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > > index 83ed2879d930..1fe7ffc1a75a 100644 > > --- a/drivers/scsi/ufs/ufshcd.c > > +++ b/drivers/scsi/ufs/ufshcd.c > > @@ -6625,6 +6625,8 @@ static int ufs_get_device_desc(struct ufs_hba > > *hba) > > goto out; > > } > > > > + dev_info->ufs_features = desc_buf[DEVICE_DESC_PARAM_UFS_FEAT]; > > + > > if (desc_buf[DEVICE_DESC_PARAM_UFS_FEAT] & 0x80) { > > hba->dev_info.hpb_control_mode = > > desc_buf[DEVICE_DESC_PARAM_HPB_CTRL_MODE]; > > Since this patch touches the same code as patch 1/5, please merge > patches 1/5 and 3/5 into a single patch. > > Thanks, > > Bart. Bart you have addressed this in the V2, sorry for this fault. I will merge them in the next version. thanks, Bean > >
diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h index 53a5e263f7c8..1f2d4b4950b8 100644 --- a/drivers/scsi/ufs/ufs.h +++ b/drivers/scsi/ufs/ufs.h @@ -543,6 +543,8 @@ struct ufs_dev_info { u16 hpb_ver; /* bHPBControl */ u8 hpb_control_mode; + /* bUFSFeaturesSupport */ + u8 ufs_features; }; /** diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 83ed2879d930..1fe7ffc1a75a 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -6625,6 +6625,8 @@ static int ufs_get_device_desc(struct ufs_hba *hba) goto out; } + dev_info->ufs_features = desc_buf[DEVICE_DESC_PARAM_UFS_FEAT]; + if (desc_buf[DEVICE_DESC_PARAM_UFS_FEAT] & 0x80) { hba->dev_info.hpb_control_mode = desc_buf[DEVICE_DESC_PARAM_HPB_CTRL_MODE];