mbox series

[v3,0/2] Misc. rproc fixes around fixed memory region support

Message ID 20200420160600.10467-1-s-anna@ti.com (mailing list archive)
Headers show
Series Misc. rproc fixes around fixed memory region support | expand

Message

Suman Anna April 20, 2020, 4:05 p.m. UTC
Hi Bjorn,

This is another minor revision of the fixes around fixed memory region
support [1] series. Patch 1 is revised to go back to the logic used in v1
after a long discussion on the v2 version [2]. The other suggestions can
be future improvments as they would require corresponding platform driver
changes. Please look through the discussion there and let us know your
preference. Patches are based on v5.7-rc1.

I really appreciate it if you can target the series for the current 5.7 -rc's.
The fixes would apply for all 5.1+ kernels.

Please see the v1 cover-letter [1] for the details on the issues.

regards
Suman

[1] https://patchwork.kernel.org/cover/11422723/
[2] https://patchwork.kernel.org/comment/23274389/

Suman Anna (1):
  remoteproc: Fix and restore the parenting hierarchy for vdev

Tero Kristo (1):
  remoteproc: Fall back to using parent memory pool if no dedicated
    available

 drivers/remoteproc/remoteproc_core.c   |  2 +-
 drivers/remoteproc/remoteproc_virtio.c | 12 ++++++++++++
 2 files changed, 13 insertions(+), 1 deletion(-)

Comments

Suman Anna May 2, 2020, 6:29 p.m. UTC | #1
Hi Bjorn,

On 4/20/20 11:05 AM, Suman Anna wrote:
> Hi Bjorn,
> 
> This is another minor revision of the fixes around fixed memory region
> support [1] series. Patch 1 is revised to go back to the logic used in v1
> after a long discussion on the v2 version [2]. The other suggestions can
> be future improvments as they would require corresponding platform driver
> changes. Please look through the discussion there and let us know your
> preference. Patches are based on v5.7-rc1.
> 
> I really appreciate it if you can target the series for the current 5.7 -rc's.
> The fixes would apply for all 5.1+ kernels.

Ping on these.

regards
Suman

> 
> Please see the v1 cover-letter [1] for the details on the issues.
> 
> regards
> Suman
> 
> [1] https://patchwork.kernel.org/cover/11422723/
> [2] https://patchwork.kernel.org/comment/23274389/
> 
> Suman Anna (1):
>    remoteproc: Fix and restore the parenting hierarchy for vdev
> 
> Tero Kristo (1):
>    remoteproc: Fall back to using parent memory pool if no dedicated
>      available
> 
>   drivers/remoteproc/remoteproc_core.c   |  2 +-
>   drivers/remoteproc/remoteproc_virtio.c | 12 ++++++++++++
>   2 files changed, 13 insertions(+), 1 deletion(-)
>
Suman Anna May 8, 2020, 3:14 p.m. UTC | #2
Hi Bjorn,

On 5/2/20 1:29 PM, Suman Anna wrote:
> Hi Bjorn,
> 
> On 4/20/20 11:05 AM, Suman Anna wrote:
>> Hi Bjorn,
>>
>> This is another minor revision of the fixes around fixed memory region
>> support [1] series. Patch 1 is revised to go back to the logic used in v1
>> after a long discussion on the v2 version [2]. The other suggestions can
>> be future improvments as they would require corresponding platform driver
>> changes. Please look through the discussion there and let us know your
>> preference. Patches are based on v5.7-rc1.
>>
>> I really appreciate it if you can target the series for the current 
>> 5.7 -rc's.
>> The fixes would apply for all 5.1+ kernels.
> 
> Ping on these.

The patches have been reviewed and/or acked by both Mathieu and Arnaud.
Can you please get these into the current -rc's?

Thanks,
Suman

> 
> regards
> Suman
> 
>>
>> Please see the v1 cover-letter [1] for the details on the issues.
>>
>> regards
>> Suman
>>
>> [1] https://patchwork.kernel.org/cover/11422723/
>> [2] https://patchwork.kernel.org/comment/23274389/
>>
>> Suman Anna (1):
>>    remoteproc: Fix and restore the parenting hierarchy for vdev
>>
>> Tero Kristo (1):
>>    remoteproc: Fall back to using parent memory pool if no dedicated
>>      available
>>
>>   drivers/remoteproc/remoteproc_core.c   |  2 +-
>>   drivers/remoteproc/remoteproc_virtio.c | 12 ++++++++++++
>>   2 files changed, 13 insertions(+), 1 deletion(-)
>>
>
Bjorn Andersson May 12, 2020, 11:10 p.m. UTC | #3
On Fri 08 May 08:14 PDT 2020, Suman Anna wrote:

> Hi Bjorn,
> 
> On 5/2/20 1:29 PM, Suman Anna wrote:
> > Hi Bjorn,
> > 
> > On 4/20/20 11:05 AM, Suman Anna wrote:
> > > Hi Bjorn,
> > > 
> > > This is another minor revision of the fixes around fixed memory region
> > > support [1] series. Patch 1 is revised to go back to the logic used in v1
> > > after a long discussion on the v2 version [2]. The other suggestions can
> > > be future improvments as they would require corresponding platform driver
> > > changes. Please look through the discussion there and let us know your
> > > preference. Patches are based on v5.7-rc1.
> > > 
> > > I really appreciate it if you can target the series for the current
> > > 5.7 -rc's.
> > > The fixes would apply for all 5.1+ kernels.
> > 
> > Ping on these.
> 
> The patches have been reviewed and/or acked by both Mathieu and Arnaud.

Thanks for the reviews!

> Can you please get these into the current -rc's?
> 

The offending patch appeared in 5.1, so I have a hard time claiming that
this is a regression in 5.7-rc. I've added Cc: stable and picked the two
patches for 5.8.

Thanks,
Bjorn

> Thanks,
> Suman
> 
> > 
> > regards
> > Suman
> > 
> > > 
> > > Please see the v1 cover-letter [1] for the details on the issues.
> > > 
> > > regards
> > > Suman
> > > 
> > > [1] https://patchwork.kernel.org/cover/11422723/
> > > [2] https://patchwork.kernel.org/comment/23274389/
> > > 
> > > Suman Anna (1):
> > >    remoteproc: Fix and restore the parenting hierarchy for vdev
> > > 
> > > Tero Kristo (1):
> > >    remoteproc: Fall back to using parent memory pool if no dedicated
> > >      available
> > > 
> > >   drivers/remoteproc/remoteproc_core.c   |  2 +-
> > >   drivers/remoteproc/remoteproc_virtio.c | 12 ++++++++++++
> > >   2 files changed, 13 insertions(+), 1 deletion(-)
> > > 
> > 
>
patchwork-bot+linux-remoteproc@kernel.org May 13, 2020, 6:20 a.m. UTC | #4
Hello:

This series was applied to andersson/remoteproc.git (refs/heads/for-next).

On Mon, 20 Apr 2020 11:05:58 -0500 you wrote:
> Hi Bjorn,
> 
> This is another minor revision of the fixes around fixed memory region
> support [1] series. Patch 1 is revised to go back to the logic used in v1
> after a long discussion on the v2 version [2]. The other suggestions can
> be future improvments as they would require corresponding platform driver
> changes. Please look through the discussion there and let us know your
> preference. Patches are based on v5.7-rc1.
> 
> [...]


Here is a summary with links:
  - [v3,1/2] remoteproc: Fall back to using parent memory pool if no dedicated available
    https://git.kernel.org/andersson/remoteproc/c/db9178a4f8c4e523f824892cb8bab00961b07385
  - [v3,2/2] remoteproc: Fix and restore the parenting hierarchy for vdev
    https://git.kernel.org/andersson/remoteproc/c/c774ad010873bb89dcc0cdcb1e96aef6664d8caf

You are awesome, thank you!
Tero Kristo May 13, 2020, 9:50 a.m. UTC | #5
On 13/05/2020 02:10, Bjorn Andersson wrote:
> On Fri 08 May 08:14 PDT 2020, Suman Anna wrote:
> 
>> Hi Bjorn,
>>
>> On 5/2/20 1:29 PM, Suman Anna wrote:
>>> Hi Bjorn,
>>>
>>> On 4/20/20 11:05 AM, Suman Anna wrote:
>>>> Hi Bjorn,
>>>>
>>>> This is another minor revision of the fixes around fixed memory region
>>>> support [1] series. Patch 1 is revised to go back to the logic used in v1
>>>> after a long discussion on the v2 version [2]. The other suggestions can
>>>> be future improvments as they would require corresponding platform driver
>>>> changes. Please look through the discussion there and let us know your
>>>> preference. Patches are based on v5.7-rc1.
>>>>
>>>> I really appreciate it if you can target the series for the current
>>>> 5.7 -rc's.
>>>> The fixes would apply for all 5.1+ kernels.
>>>
>>> Ping on these.
>>
>> The patches have been reviewed and/or acked by both Mathieu and Arnaud.
> 
> Thanks for the reviews!
> 
>> Can you please get these into the current -rc's?
>>
> 
> The offending patch appeared in 5.1, so I have a hard time claiming that
> this is a regression in 5.7-rc. I've added Cc: stable and picked the two
> patches for 5.8.

Thanks Bjorn,

I believe 5.8 should be fine, we can backport this internally if needed.

-Tero

> 
> Thanks,
> Bjorn
> 
>> Thanks,
>> Suman
>>
>>>
>>> regards
>>> Suman
>>>
>>>>
>>>> Please see the v1 cover-letter [1] for the details on the issues.
>>>>
>>>> regards
>>>> Suman
>>>>
>>>> [1] https://patchwork.kernel.org/cover/11422723/
>>>> [2] https://patchwork.kernel.org/comment/23274389/
>>>>
>>>> Suman Anna (1):
>>>>     remoteproc: Fix and restore the parenting hierarchy for vdev
>>>>
>>>> Tero Kristo (1):
>>>>     remoteproc: Fall back to using parent memory pool if no dedicated
>>>>       available
>>>>
>>>>    drivers/remoteproc/remoteproc_core.c   |  2 +-
>>>>    drivers/remoteproc/remoteproc_virtio.c | 12 ++++++++++++
>>>>    2 files changed, 13 insertions(+), 1 deletion(-)
>>>>
>>>
>>

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki