| Message ID | 1589250561-106088-1-git-send-email-zou_wei@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] ARM: zx: Make zx_smp_prepare_cpus static | expand |
On Tue, May 12, 2020 at 10:29:21AM +0800, Samuel Zou wrote: > Fix the following sparse warning: > > arch/arm/mach-zx/platsmp.c:41:13: warning: symbol 'zx_smp_prepare_cpus' was not declared. > > The zx_smp_prepare_cpus has only call site within platsmp.c > It should be static > > Fixes: 71bc724300e6 ("ARM: zx: enable SMP and hotplug for zx296702") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Samuel Zou <zou_wei@huawei.com> Acked-by: Shawn Guo <shawnguo@kernel.org> Hi Arnd, Can you please apply it to arm-soc tree? Shawn > --- > arch/arm/mach-zx/platsmp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-zx/platsmp.c b/arch/arm/mach-zx/platsmp.c > index d4e1d37..43a33ea 100644 > --- a/arch/arm/mach-zx/platsmp.c > +++ b/arch/arm/mach-zx/platsmp.c > @@ -38,7 +38,7 @@ static void __iomem *pcu_base; > static void __iomem *matrix_base; > static void __iomem *scu_base; > > -void __init zx_smp_prepare_cpus(unsigned int max_cpus) > +static void __init zx_smp_prepare_cpus(unsigned int max_cpus) > { > struct device_node *np; > unsigned long base = 0; > -- > 2.6.2 >
diff --git a/arch/arm/mach-zx/platsmp.c b/arch/arm/mach-zx/platsmp.c index d4e1d37..43a33ea 100644 --- a/arch/arm/mach-zx/platsmp.c +++ b/arch/arm/mach-zx/platsmp.c @@ -38,7 +38,7 @@ static void __iomem *pcu_base; static void __iomem *matrix_base; static void __iomem *scu_base; -void __init zx_smp_prepare_cpus(unsigned int max_cpus) +static void __init zx_smp_prepare_cpus(unsigned int max_cpus) { struct device_node *np; unsigned long base = 0;
Fix the following sparse warning: arch/arm/mach-zx/platsmp.c:41:13: warning: symbol 'zx_smp_prepare_cpus' was not declared. The zx_smp_prepare_cpus has only call site within platsmp.c It should be static Fixes: 71bc724300e6 ("ARM: zx: enable SMP and hotplug for zx296702") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Samuel Zou <zou_wei@huawei.com> --- arch/arm/mach-zx/platsmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)