| Message ID | 20200513214351.2138580-10-emil.l.velikov@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [01/11] tty/sysrq: alpha: export and use __sysrq_get_key_op() | expand |
On Wed, May 13, 2020 at 11:46 PM Emil Velikov <emil.l.velikov@gmail.com> wrote: > > With earlier commits, the API no longer discards the const-ness of the > sysrq_key_op. As such we can add the notation. > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Jiri Slaby <jslaby@suse.com> > Cc: linux-kernel@vger.kernel.org > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > Cc: Len Brown <len.brown@intel.com> > Cc: linux-pm@vger.kernel.org > Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> and I'm assuming that this is going to be applied along with the rest of the series. > --- > Please keep me in the CC list, as I'm not subscribed to the list. > > IMHO it would be better if this gets merged this via the tty tree. > --- > kernel/power/poweroff.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/power/poweroff.c b/kernel/power/poweroff.c > index 6d475281c730..562aa0e450ed 100644 > --- a/kernel/power/poweroff.c > +++ b/kernel/power/poweroff.c > @@ -29,7 +29,7 @@ static void handle_poweroff(int key) > schedule_work_on(cpumask_first(cpu_online_mask), &poweroff_work); > } > > -static struct sysrq_key_op sysrq_poweroff_op = { > +static const struct sysrq_key_op sysrq_poweroff_op = { > .handler = handle_poweroff, > .help_msg = "poweroff(o)", > .action_msg = "Power Off", > -- > 2.25.1 >
On Thu, 14 May 2020 at 12:21, Rafael J. Wysocki <rafael@kernel.org> wrote: > > On Wed, May 13, 2020 at 11:46 PM Emil Velikov <emil.l.velikov@gmail.com> wrote: > > > > With earlier commits, the API no longer discards the const-ness of the > > sysrq_key_op. As such we can add the notation. > > > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Cc: Jiri Slaby <jslaby@suse.com> > > Cc: linux-kernel@vger.kernel.org > > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > > Cc: Len Brown <len.brown@intel.com> > > Cc: linux-pm@vger.kernel.org > > Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> > > Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > Thanks > and I'm assuming that this is going to be applied along with the rest > of the series. > I believe so, although I have not heard anything from the TTY maintainers yet. -Emil
On Fri, May 15, 2020 at 11:11:57AM +0100, Emil Velikov wrote: > On Thu, 14 May 2020 at 12:21, Rafael J. Wysocki <rafael@kernel.org> wrote: > > > > On Wed, May 13, 2020 at 11:46 PM Emil Velikov <emil.l.velikov@gmail.com> wrote: > > > > > > With earlier commits, the API no longer discards the const-ness of the > > > sysrq_key_op. As such we can add the notation. > > > > > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > Cc: Jiri Slaby <jslaby@suse.com> > > > Cc: linux-kernel@vger.kernel.org > > > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > > > Cc: Len Brown <len.brown@intel.com> > > > Cc: linux-pm@vger.kernel.org > > > Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> > > > > Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > > Thanks > > > and I'm assuming that this is going to be applied along with the rest > > of the series. > > > I believe so, although I have not heard anything from the TTY maintainers yet. I will take them all, thanks. greg k-h
diff --git a/kernel/power/poweroff.c b/kernel/power/poweroff.c index 6d475281c730..562aa0e450ed 100644 --- a/kernel/power/poweroff.c +++ b/kernel/power/poweroff.c @@ -29,7 +29,7 @@ static void handle_poweroff(int key) schedule_work_on(cpumask_first(cpu_online_mask), &poweroff_work); } -static struct sysrq_key_op sysrq_poweroff_op = { +static const struct sysrq_key_op sysrq_poweroff_op = { .handler = handle_poweroff, .help_msg = "poweroff(o)", .action_msg = "Power Off",
With earlier commits, the API no longer discards the const-ness of the sysrq_key_op. As such we can add the notation. Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Jiri Slaby <jslaby@suse.com> Cc: linux-kernel@vger.kernel.org Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> Cc: Len Brown <len.brown@intel.com> Cc: linux-pm@vger.kernel.org Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> --- Please keep me in the CC list, as I'm not subscribed to the list. IMHO it would be better if this gets merged this via the tty tree. --- kernel/power/poweroff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)