Message ID | 20200509234557.1124086-7-viro@ZenIV.linux.org.uk (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | [01/20] dlmfs_file_write(): get rid of pointless access_ok() | expand |
On Sun, May 10, 2020 at 12:45:44AM +0100, Al Viro wrote: > From: Al Viro <viro@zeniv.linux.org.uk> > > we are using copy_to_user()/memdup_user() anyway > > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> > --- > drivers/char/nvram.c | 4 ---- > 1 file changed, 4 deletions(-) Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/char/nvram.c b/drivers/char/nvram.c index 4667844eee69..8206412d25ba 100644 --- a/drivers/char/nvram.c +++ b/drivers/char/nvram.c @@ -232,8 +232,6 @@ static ssize_t nvram_misc_read(struct file *file, char __user *buf, ssize_t ret; - if (!access_ok(buf, count)) - return -EFAULT; if (*ppos >= nvram_size) return 0; @@ -264,8 +262,6 @@ static ssize_t nvram_misc_write(struct file *file, const char __user *buf, char *tmp; ssize_t ret; - if (!access_ok(buf, count)) - return -EFAULT; if (*ppos >= nvram_size) return 0;