diff mbox series

Patch to fix missing Exec field in qemu.desktop

Message ID zrVSyE1D2Xtxcr723wTf2sJRtM0IPuBRH0S-Gyx2XsvooDqbMYhqrK_aVk3AZM8RkjyOzYKWQH3VrnWDjwVUspDJHYUKXOyLZEZlvAzz6Ww=@protonmail.com (mailing list archive)
State New, archived
Headers show
Series Patch to fix missing Exec field in qemu.desktop | expand

Commit Message

Zhijian Li (Fujitsu)" via May 16, 2020, 2:42 p.m. UTC
Sent with ProtonMail Secure Email.

Comments

Daniel P. Berrangé May 18, 2020, 9:49 a.m. UTC | #1
On Sat, May 16, 2020 at 02:42:47PM +0000, Victor Lavaud via wrote:
> 
> 
> 
> Sent with ProtonMail Secure Email.
> 

> From 207a1a34accdc5b563d29484292829a4193c35f8 Mon Sep 17 00:00:00 2001
> From: Victor Lavaud <victor.lavaud@gmail.com>
> Date: Sat, 16 May 2020 16:33:00 +0200
> Subject: [PATCH] Fix missing Exec field in qemu.desktop
> 
> Signed-off-by: Victor Lavaud <victor.lavaud@pm.me>
> ---
>  ui/qemu.desktop | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/ui/qemu.desktop b/ui/qemu.desktop
> index 20f09f56be..1b9f02a0cc 100644
> --- a/ui/qemu.desktop
> +++ b/ui/qemu.desktop
> @@ -6,3 +6,4 @@ Type=Application
>  Terminal=false
>  Keywords=Emulators;Virtualization;KVM;
>  NoDisplay=true
> +Exec=qemu

There is no such binary, and we *intentionally* don't included any
'Exec' field, because it doesn't make sense. We consider the validation
tool that complains about missing 'Exec' field to be incorrect

   https://bugs.launchpad.net/qemu/+bug/1868221


Regards,
Daniel
diff mbox series

Patch

From 207a1a34accdc5b563d29484292829a4193c35f8 Mon Sep 17 00:00:00 2001
From: Victor Lavaud <victor.lavaud@gmail.com>
Date: Sat, 16 May 2020 16:33:00 +0200
Subject: [PATCH] Fix missing Exec field in qemu.desktop

Signed-off-by: Victor Lavaud <victor.lavaud@pm.me>
---
 ui/qemu.desktop | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ui/qemu.desktop b/ui/qemu.desktop
index 20f09f56be..1b9f02a0cc 100644
--- a/ui/qemu.desktop
+++ b/ui/qemu.desktop
@@ -6,3 +6,4 @@  Type=Application
 Terminal=false
 Keywords=Emulators;Virtualization;KVM;
 NoDisplay=true
+Exec=qemu
-- 
2.26.2