| Message ID | 20200521110836.57252-1-sudeep.holla@arm.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 269fd61e15d785b9e20786672765400732dde8a0 |
| Headers | show |
| Series | firmware: smccc: Fix missing prototype warning for arm_smccc_version_init | expand |
On Thu, 21 May 2020 12:08:36 +0100, Sudeep Holla wrote: > Commit f2ae97062a48 ("firmware: smccc: Refactor SMCCC specific bits into > separate file") introduced the following build warning: > > drivers/firmware/smccc/smccc.c:14:13: warning: no previous prototype for > function 'arm_smccc_version_init' [-Wmissing-prototypes] > void __init arm_smccc_version_init(u32 version, enum arm_smccc_conduit conduit) > ^~~~~~~~~~~~~~~~~~~~~~ > > [...] Applied to arm64 (for-next/smccc), thanks! [1/1] firmware: smccc: Fix missing prototype warning for arm_smccc_version_init https://git.kernel.org/arm64/c/269fd61e15d7 Cheers,
diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c index 1330a698a178..92013ecc2d9e 100644 --- a/drivers/firmware/psci/psci.c +++ b/drivers/firmware/psci/psci.c @@ -79,7 +79,6 @@ static u32 psci_function_id[PSCI_FN_MAX]; static u32 psci_cpu_suspend_feature; static bool psci_system_reset2_supported; -void __init arm_smccc_version_init(u32 version, enum arm_smccc_conduit conduit); static inline bool psci_has_ext_power_state(void) { diff --git a/include/linux/arm-smccc.h b/include/linux/arm-smccc.h index c491d210e3c3..56d6a5c6e353 100644 --- a/include/linux/arm-smccc.h +++ b/include/linux/arm-smccc.h @@ -5,6 +5,7 @@ #ifndef __LINUX_ARM_SMCCC_H #define __LINUX_ARM_SMCCC_H +#include <linux/init.h> #include <uapi/linux/const.h> /* @@ -111,6 +112,8 @@ enum arm_smccc_conduit arm_smccc_1_1_get_conduit(void); */ u32 arm_smccc_get_version(void); +void __init arm_smccc_version_init(u32 version, enum arm_smccc_conduit conduit); + /** * struct arm_smccc_res - Result from SMC/HVC call * @a0-a3 result values from registers 0 to 3
Commit f2ae97062a48 ("firmware: smccc: Refactor SMCCC specific bits into separate file") introduced the following build warning: drivers/firmware/smccc/smccc.c:14:13: warning: no previous prototype for function 'arm_smccc_version_init' [-Wmissing-prototypes] void __init arm_smccc_version_init(u32 version, enum arm_smccc_conduit conduit) ^~~~~~~~~~~~~~~~~~~~~~ Fix the same by adding the missing prototype in arm-smccc.h Reported-by: kbuild test robot <lkp@intel.com> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> --- drivers/firmware/psci/psci.c | 1 - include/linux/arm-smccc.h | 3 +++ 2 files changed, 3 insertions(+), 1 deletion(-) base-commit: a4fb17465182c9fc13104e4df04d050892055205