diff mbox series

[v2,06/15] ARM: berlin: Drop unneeded select of HAVE_SMP

Message ID 20200505150722.1575-7-geert+renesas@glider.be (mailing list archive)
State Mainlined
Commit b8c5a80689bae8c13029bde2cc605b7011a09dfe
Headers show
Series ARM: Drop unneeded select of multi-platform selected options | expand

Commit Message

Geert Uytterhoeven May 5, 2020, 3:07 p.m. UTC
Support for Marvell Berlin SoCs depends on ARCH_MULTI_V7.
As the latter selects HAVE_SMP, there is no need for MACH_BERLIN_BG2 to
select HAVE_SMP.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
---
v2:
  - Add Acked-by.
---
 arch/arm/mach-berlin/Kconfig | 1 -
 1 file changed, 1 deletion(-)

Comments

Jisheng Zhang May 22, 2020, 10:12 a.m. UTC | #1
Hi Arnd, Kevin, Olof,

On Tue,  5 May 2020 17:07:13 +0200 Geert Uytterhoeven wrote:

> 
> 
> Support for Marvell Berlin SoCs depends on ARCH_MULTI_V7.
> As the latter selects HAVE_SMP, there is no need for MACH_BERLIN_BG2 to
> select HAVE_SMP.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> Acked-by: Arnd Bergmann <arnd@arndb.de>

The patch looks good to me. I want to know what will be the mainline
path of this series. SoC maintainers take it then send A PR to arm-soc?
Or each SoC maintainers ack it, arm-soc will take the whole series?
If later, then

Acked-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>


This is the first time I see a series touch different SoC platforms.

Thanks in advance,
Jisheng

> ---
> v2:
>   - Add Acked-by.
> ---
>  arch/arm/mach-berlin/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/mach-berlin/Kconfig b/arch/arm/mach-berlin/Kconfig
> index 5b1f61fd78780300..01861fa72c9714b7 100644
> --- a/arch/arm/mach-berlin/Kconfig
> +++ b/arch/arm/mach-berlin/Kconfig
> @@ -19,7 +19,6 @@ config MACH_BERLIN_BG2
>         select CPU_PJ4B
>         select HAVE_ARM_SCU if SMP
>         select HAVE_ARM_TWD if SMP
> -       select HAVE_SMP
>         select PINCTRL_BERLIN_BG2
> 
>  config MACH_BERLIN_BG2CD
> --
> 2.17.1
>
Arnd Bergmann May 22, 2020, 10:34 a.m. UTC | #2
On Fri, May 22, 2020 at 12:13 PM Jisheng Zhang
<Jisheng.Zhang@synaptics.com> wrote:
>
> Hi Arnd, Kevin, Olof,
>
> On Tue,  5 May 2020 17:07:13 +0200 Geert Uytterhoeven wrote:
>
> >
> >
> > Support for Marvell Berlin SoCs depends on ARCH_MULTI_V7.
> > As the latter selects HAVE_SMP, there is no need for MACH_BERLIN_BG2 to
> > select HAVE_SMP.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > Cc: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
> > Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> > Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> The patch looks good to me. I want to know what will be the mainline
> path of this series. SoC maintainers take it then send A PR to arm-soc?
> Or each SoC maintainers ack it, arm-soc will take the whole series?
> If later, then
>
> Acked-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
>
>
> This is the first time I see a series touch different SoC platforms.

I have already merged it. The normal way we do this is that platform
maintainers can choose to merge individual patches when they
are happy with them on the early review, or provide an Ack for
them to get merged as a branch.

I picked up v2 of the series as there seemed to be a sufficient
number of Acks and everyone that commented had agreed
in principle.

      Arnd
Jisheng Zhang May 22, 2020, 10:36 a.m. UTC | #3
On Fri, 22 May 2020 12:34:43 +0200 Arnd Bergmann wrote:


> 
> 
> On Fri, May 22, 2020 at 12:13 PM Jisheng Zhang
> <Jisheng.Zhang@synaptics.com> wrote:
> >
> > Hi Arnd, Kevin, Olof,
> >
> > On Tue,  5 May 2020 17:07:13 +0200 Geert Uytterhoeven wrote:
> >  
> > >
> > >
> > > Support for Marvell Berlin SoCs depends on ARCH_MULTI_V7.
> > > As the latter selects HAVE_SMP, there is no need for MACH_BERLIN_BG2 to
> > > select HAVE_SMP.
> > >
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > Cc: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
> > > Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> > > Acked-by: Arnd Bergmann <arnd@arndb.de>  
> >
> > The patch looks good to me. I want to know what will be the mainline
> > path of this series. SoC maintainers take it then send A PR to arm-soc?
> > Or each SoC maintainers ack it, arm-soc will take the whole series?
> > If later, then
> >
> > Acked-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
> >
> >
> > This is the first time I see a series touch different SoC platforms.  
> 
> I have already merged it. The normal way we do this is that platform
> maintainers can choose to merge individual patches when they
> are happy with them on the early review, or provide an Ack for
> them to get merged as a branch.
> 
> I picked up v2 of the series as there seemed to be a sufficient
> number of Acks and everyone that commented had agreed
> in principle.
> 

Nice. Thanks a lot
diff mbox series

Patch

diff --git a/arch/arm/mach-berlin/Kconfig b/arch/arm/mach-berlin/Kconfig
index 5b1f61fd78780300..01861fa72c9714b7 100644
--- a/arch/arm/mach-berlin/Kconfig
+++ b/arch/arm/mach-berlin/Kconfig
@@ -19,7 +19,6 @@  config MACH_BERLIN_BG2
 	select CPU_PJ4B
 	select HAVE_ARM_SCU if SMP
 	select HAVE_ARM_TWD if SMP
-	select HAVE_SMP
 	select PINCTRL_BERLIN_BG2
 
 config MACH_BERLIN_BG2CD